glazedlists
  1. glazedlists
  2. GLAZEDLISTS-508

[solved] Could 'rebuildMatcher' in 'CompositeMatcherEditor' become 'protected'?

    Details

    • Type: Improvement Improvement
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Won't Fix
    • Affects Version/s: 0.9.1
    • Fix Version/s: 1.9.0
    • Component/s: core
    • Labels:
      None
    • Environment:

      Operating System: All
      Platform: All

    • Issuezilla Id:
      508

      Description

      Imagine a table which have 30 filters fields available but only 3 fields have
      been feed among them. In current 'rebuildMatcher', it will construct 30
      matchers to filter. But obviously, something could be done to reduce the number
      of matchers to use.

      In fact, we have developped some Matcher which have a method "boolean matchesAll
      ()", so could you change the visibility of 'rebuildMatcher' to protected so
      that we can do some performance improvement there?

      thanks.

        Activity

        Hide
        revever added a comment -

        What's more, I can't force the filtering action on a table which
        uses 'CompositeMatcherEditor' because the 'Matcher rebuildMatcher()' is private.

        Show
        revever added a comment - What's more, I can't force the filtering action on a table which uses 'CompositeMatcherEditor' because the 'Matcher rebuildMatcher()' is private.
        Hide
        revever added a comment -

        You have done a beautiful job!

        Just before coding a workaround, I have debugged into the 'rebuildMatcher'. In
        fact, if there is no content in the underlying document, the 'TextEditor' will
        replace its 'TextMatcher' by a 'TrueMatcher'. So there is almost no cost at
        this point because the 'TrueMatcher' returns always 'true'.

        Show
        revever added a comment - You have done a beautiful job! Just before coding a workaround, I have debugged into the 'rebuildMatcher'. In fact, if there is no content in the underlying document, the 'TextEditor' will replace its 'TextMatcher' by a 'TrueMatcher'. So there is almost no cost at this point because the 'TrueMatcher' returns always 'true'.
        Hide
        brands added a comment -

        interpreting this as obsolete, please reopne if you think otherwise...

        Show
        brands added a comment - interpreting this as obsolete, please reopne if you think otherwise...

          People

          • Assignee:
            jessewilson
            Reporter:
            revever
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: