grizzly
  1. grizzly
  2. GRIZZLY-819

Implementation of FilterChain is not threadsafe

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Critical Critical
    • Resolution: Fixed
    • Affects Version/s: 1.9.18
    • Fix Version/s: 1.9.19
    • Component/s: http-servlet
    • Labels:
      None
    • Environment:

      Operating System: All
      Platform: All

    • Issuezilla Id:
      819

      Description

      Hello,
      com.sun.grizzly.http.servlet.FilterChainImpl
      uses an instance-variable pos in doFilter to keep track of the last Filters
      already called.
      There is only one Instance of FilterChainImpl used in all threads, therefore
      this variable is changed concurrently in different threads.
      I propose at least to make this variable threadsafe.

      The problem only shows if more than filter is registered.

      Greetings,
      Andreas

        Activity

        Hide
        oleksiys added a comment -

        should be fixed on the trunk.
        Thank you!

        Date: 2010-05-03 10:07:33+0000
        New Revision: 4521

        Modified:
        trunk/code/modules/http-servlet/src/main/java/com/sun/grizzly/http/servlet/FilterChainImpl.java
        trunk/code/modules/http-
        servlet/src/main/java/com/sun/grizzly/http/servlet/HttpServletRequestImpl.java
        trunk/code/modules/http-servlet/src/main/java/com/sun/grizzly/http/servlet/ServletAdapter.java

        Log:
        fix the issue #819
        https://grizzly.dev.java.net/issues/show_bug.cgi?id=819
        "Implementation of FilterChain is not threadsafe"

        Show
        oleksiys added a comment - should be fixed on the trunk. Thank you! Date: 2010-05-03 10:07:33+0000 New Revision: 4521 Modified: trunk/code/modules/http-servlet/src/main/java/com/sun/grizzly/http/servlet/FilterChainImpl.java trunk/code/modules/http- servlet/src/main/java/com/sun/grizzly/http/servlet/HttpServletRequestImpl.java trunk/code/modules/http-servlet/src/main/java/com/sun/grizzly/http/servlet/ServletAdapter.java Log: fix the issue #819 https://grizzly.dev.java.net/issues/show_bug.cgi?id=819 "Implementation of FilterChain is not threadsafe"

          People

          • Assignee:
            oleksiys
            Reporter:
            aschoerk
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: