hk2
  1. hk2
  2. HK2-109

bom pom should not inherit the parent pom

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Critical Critical
    • Resolution: Fixed
    • Affects Version/s: 2.2.0
    • Fix Version/s: 2.2.0
    • Component/s: None
    • Labels:
      None

      Description

      The BOM pom should not inherit the parent pom otherwise the deendencyManagement of the parent pom is also imported when importing the bom pom which can create conflicts and require specific ordering of the boms imports.

        Activity

        Hide
        Romain Grécourt added a comment -

        Index: pom.xml
        ===================================================================
        — pom.xml (revision 4471)
        +++ pom.xml (working copy)
        @@ -45,16 +45,14 @@
        <modelVersion>4.0.0</modelVersion>

        <parent>

        • <groupId>net.java</groupId>
        • <artifactId>jvnet-parent</artifactId>
        • <version>3</version>
          + <groupId>org.glassfish.hk2</groupId>
          + <artifactId>hk2-bom</artifactId>
          + <version>2.1.81-SNAPSHOT</version>
          + <relativePath>bom/pom.xml</relativePath>
          </parent>
          -
        • <groupId>org.glassfish.hk2</groupId>
          <artifactId>hk2-parent</artifactId>
          <packaging>pom</packaging>
        • <version>2.1.81-SNAPSHOT</version>
          <name>Modules Subsystem</name>
          <description>Generic Modules subsystem</description>

        @@ -326,8 +324,6 @@
        <java.net.username>$

        {user.name}

        </java.net.username>
        <asm.version>3.3</asm.version>
        <cglib.version>2.2</cglib.version>

        • <javax.validation.version>1.1.0.CR3</javax.validation.version>
        • <hibernate-validator.version>5.0.0.CR5</hibernate-validator.version>
          <findbugs.exclude />
          <findbugs.threshold>High</findbugs.threshold>
          <site.url>file:../www/</site.url>
          Index: bom/pom.xml
          ===================================================================
            • bom/pom.xml (revision 4471)
              +++ bom/pom.xml (working copy)
              @@ -43,16 +43,21 @@

        <project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/maven-v4_0_0.xsd">
        <modelVersion>4.0.0</modelVersion>
        -
        <parent>

        • <groupId>org.glassfish.hk2</groupId>
        • <artifactId>hk2-parent</artifactId>
        • <version>2.1.81-SNAPSHOT</version>
          + <groupId>net.java</groupId>
          + <artifactId>jvnet-parent</artifactId>
          + <version>3</version>
          + <relativePath/>
          </parent>
          -
          <groupId>org.glassfish.hk2</groupId>
          <artifactId>hk2-bom</artifactId>
          + <version>2.1.81-SNAPSHOT</version>
          <packaging>pom</packaging>
          +
          + <properties>
          + <javax.validation.version>1.1.0.CR3</javax.validation.version>
          + <hibernate-validator.version>5.0.0.CR5</hibernate-validator.version>
          + </properties>

        <name>HK2 Bom Pom</name>
        <description>Bom Pom for importing hk2 managed dependencies</description>
        romano@dhcp-prague08-third-floor-10-163-25-212:~/workspaces/hk2/trunk/hk2$ svn commit -m "fix HK2-109"
        Sending hk2/bom/pom.xml
        Sending hk2/pom.xml
        Transmitting file data ..
        Committed revision 4472.

        Show
        Romain Grécourt added a comment - Index: pom.xml =================================================================== — pom.xml (revision 4471) +++ pom.xml (working copy) @@ -45,16 +45,14 @@ <modelVersion>4.0.0</modelVersion> <parent> <groupId>net.java</groupId> <artifactId>jvnet-parent</artifactId> <version>3</version> + <groupId>org.glassfish.hk2</groupId> + <artifactId>hk2-bom</artifactId> + <version>2.1.81-SNAPSHOT</version> + <relativePath>bom/pom.xml</relativePath> </parent> - <groupId>org.glassfish.hk2</groupId> <artifactId>hk2-parent</artifactId> <packaging>pom</packaging> <version>2.1.81-SNAPSHOT</version> <name>Modules Subsystem</name> <description>Generic Modules subsystem</description> @@ -326,8 +324,6 @@ <java.net.username>$ {user.name} </java.net.username> <asm.version>3.3</asm.version> <cglib.version>2.2</cglib.version> <javax.validation.version>1.1.0.CR3</javax.validation.version> <hibernate-validator.version>5.0.0.CR5</hibernate-validator.version> <findbugs.exclude /> <findbugs.threshold>High</findbugs.threshold> <site.url> file:../www/ </site.url> Index: bom/pom.xml =================================================================== bom/pom.xml (revision 4471) +++ bom/pom.xml (working copy) @@ -43,16 +43,21 @@ <project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/maven-v4_0_0.xsd "> <modelVersion>4.0.0</modelVersion> - <parent> <groupId>org.glassfish.hk2</groupId> <artifactId>hk2-parent</artifactId> <version>2.1.81-SNAPSHOT</version> + <groupId>net.java</groupId> + <artifactId>jvnet-parent</artifactId> + <version>3</version> + <relativePath/> </parent> - <groupId>org.glassfish.hk2</groupId> <artifactId>hk2-bom</artifactId> + <version>2.1.81-SNAPSHOT</version> <packaging>pom</packaging> + + <properties> + <javax.validation.version>1.1.0.CR3</javax.validation.version> + <hibernate-validator.version>5.0.0.CR5</hibernate-validator.version> + </properties> <name>HK2 Bom Pom</name> <description>Bom Pom for importing hk2 managed dependencies</description> romano@dhcp-prague08-third-floor-10-163-25-212:~/workspaces/hk2/trunk/hk2$ svn commit -m "fix HK2-109 " Sending hk2/bom/pom.xml Sending hk2/pom.xml Transmitting file data .. Committed revision 4472.

          People

          • Assignee:
            Romain Grécourt
            Reporter:
            Romain Grécourt
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: