javaeetutorial
  1. javaeetutorial
  2. JAVAEETUTORIAL-176

Sample code lines should be shorter whenever possible to avoid line-wrapping in the HTML output

    Details

    • Type: Improvement Improvement
    • Status: Resolved
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 7.0.0
    • Fix Version/s: 7.0.3
    • Component/s: None
    • Labels:
      None

      Description

      The HTML output seems to fit around 70 characters in one line for code examples. Line wrapping with CSS has been a great improvement, but the code is still difficult to read when it has more than a few long lines.

        Activity

        Hide
        Kim Haase added a comment -

        Fixed bad breaks in jsf-advanced-cc.fm.

        Show
        Kim Haase added a comment - Fixed bad breaks in jsf-advanced-cc.fm.
        Hide
        Kim Haase added a comment -

        Bad break in usingexamples.fm (Section 2.9.2.1) fixed as a result of JAVAEETUTORIAL-210.

        Show
        Kim Haase added a comment - Bad break in usingexamples.fm (Section 2.9.2.1) fixed as a result of JAVAEETUTORIAL-210 .
        Hide
        Kim Haase added a comment -

        webapp.fm: Fixed bad break in web.xml servlet-class subelement; also fixed in hello1 example trunk and branch files. Fixed two bad breaks in GreetingServlet.java; also fixed in hello2 example trunk and branch files.

        Show
        Kim Haase added a comment - webapp.fm: Fixed bad break in web.xml servlet-class subelement; also fixed in hello1 example trunk and branch files. Fixed two bad breaks in GreetingServlet.java; also fixed in hello2 example trunk and branch files.
        Hide
        Kim Haase added a comment -

        jsf-intro.fm: fixed bad line breaks.

        jsf-facelets.fm: fixed bad line breaks in Frame file as well as in guessnumber-jsf and reservation example files (trunk and branch).

        Show
        Kim Haase added a comment - jsf-intro.fm: fixed bad line breaks. jsf-facelets.fm: fixed bad line breaks in Frame file as well as in guessnumber-jsf and reservation example files (trunk and branch).
        Hide
        Kim Haase added a comment -

        jsf-el.fm: Fixed duplicated item (and bad line break) in Table 9-2.

        jsf-page.fm: Fixed bad line breaks, and some table formatting as well.

        Show
        Kim Haase added a comment - jsf-el.fm: Fixed duplicated item (and bad line break) in Table 9-2. jsf-page.fm: Fixed bad line breaks, and some table formatting as well.
        Hide
        Kim Haase added a comment -

        jsf-develop.fm: Fixed bad line break, table formatting.

        jsf-custom.fm: Fixed bad line breaks. Experimented with specifying "wide" as role for informal example. Fixed jsf-config.xml to reduce line lengths.

        Show
        Kim Haase added a comment - jsf-develop.fm: Fixed bad line break, table formatting. jsf-custom.fm: Fixed bad line breaks. Experimented with specifying "wide" as role for informal example. Fixed jsf-config.xml to reduce line lengths.
        Hide
        Kim Haase added a comment -

        jsf-configure.fm: Fixed bad line breaks.

        Show
        Kim Haase added a comment - jsf-configure.fm: Fixed bad line breaks.
        Hide
        Kim Haase added a comment -

        jms-concepts.fm, jms-examples.fm: fixed bad line breaks (also in producer, shareddurablesubscribererexample, websimplemessage examples).

        Show
        Kim Haase added a comment - jms-concepts.fm, jms-examples.fm: fixed bad line breaks (also in producer, shareddurablesubscribererexample, websimplemessage examples).
        Hide
        Kim Haase added a comment -

        Now that the font for code examples is smaller, we can probably go back to having lines that are as long as the FrameMaker source will allow.

        Show
        Kim Haase added a comment - Now that the font for code examples is smaller, we can probably go back to having lines that are as long as the FrameMaker source will allow.
        Hide
        rcervera added a comment -

        Kim, should we close this issue then?

        Show
        rcervera added a comment - Kim, should we close this issue then?
        Hide
        Kim Haase added a comment -

        Hm! Yes, maybe that's the best choice. We'd have to retitle it to something like "Code lines should fit on a FrameMaker line", which seems like a no-brainer.

        It is unfortunate that our nightly RSB builds don't use the new stylesheets, so we can't test our fixes. I wonder if they could be changed to use them?

        Show
        Kim Haase added a comment - Hm! Yes, maybe that's the best choice. We'd have to retitle it to something like "Code lines should fit on a FrameMaker line", which seems like a no-brainer. It is unfortunate that our nightly RSB builds don't use the new stylesheets, so we can't test our fixes. I wonder if they could be changed to use them?
        Hide
        Kim Haase added a comment -

        Now that the nightly builds use the new stylesheets, maybe you could close this issue as "Works as Designed", Ricardo? That seems to be closest to the actual situation. I have reverted my "fixes".

        Show
        Kim Haase added a comment - Now that the nightly builds use the new stylesheets, maybe you could close this issue as "Works as Designed", Ricardo? That seems to be closest to the actual situation. I have reverted my "fixes".
        Hide
        rcervera added a comment -

        Works as designed with the new style sheets.

        Show
        rcervera added a comment - Works as designed with the new style sheets.

          People

          • Assignee:
            Unassigned
            Reporter:
            rcervera
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: