javaeetutorial
  1. javaeetutorial
  2. JAVAEETUTORIAL-32

html tags in examples must have lang attribute

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 6.0.4
    • Fix Version/s: 7.0.2
    • Component/s: examples
    • Labels:
      None

      Description

      All HTML tags in our examples must have the LANG attribute set.

      It appears that for the simple case where the example is English-only, hardcoding the LANG attribute in the HTML tag may be the way to go:

      <html lang="en"
      xmlns="http://www.w3.org/1999/xhtml"
      xmlns:h="http://java.sun.com/jsf/html"
      xmlns:f="http://java.sun.com/jsf/core">
      ...

      However, it appears that for the case studies, where the locale can change dynamically, we need to do some coding so that the current locale can be retrieved. I don't know how well something like this would actually work, but maybe one of you can try it out:

      http://stackoverflow.com/questions/4830588/jsf-locale-is-set-per-request-not-for-session

      Our apps are different in that they get the locale from the browser setting instead of having the user set it in the app; that might simplify things.

      I can check in fixes for the simple cases and then un-assign myself so the case study authors can work on those.

        Issue Links

          Activity

          Kim Haase created issue -
          Hide
          Kim Haase added a comment -

          I've completed this work for all but the case studies.

          Show
          Kim Haase added a comment - I've completed this work for all but the case studies.
          Hide
          Kim Haase added a comment -

          Unassigning so case study authors can do this work – though I can do it, if you prefer.

          Show
          Kim Haase added a comment - Unassigning so case study authors can do this work – though I can do it, if you prefer.
          Kim Haase made changes -
          Field Original Value New Value
          Assignee Kim Haase [ chaase3 ]
          Ian Evans made changes -
          Assignee Ian Evans [ ievans ]
          Ian Evans made changes -
          Status Open [ 1 ] In Progress [ 3 ]
          Hide
          Kim Haase added a comment -

          Ian, thanks for picking this up. While you are fixing this for dukes-tutoring you might also add a summary attribute to the h:dataTable element in any files that use one. Or would you rather I filed a separate issue for table summary problems?

          Show
          Kim Haase added a comment - Ian, thanks for picking this up. While you are fixing this for dukes-tutoring you might also add a summary attribute to the h:dataTable element in any files that use one. Or would you rather I filed a separate issue for table summary problems?
          Ian Evans logged work - 27/Jul/11 6:53 PM
          Ian Evans made changes -
          Remaining Estimate 0 minutes [ 0 ]
          Time Spent 1 day [ 86400 ]
          Hide
          Ian Evans added a comment -

          Re-assigning to William for Duke's Forest.

          Show
          Ian Evans added a comment - Re-assigning to William for Duke's Forest.
          Ian Evans made changes -
          Assignee Ian Evans [ ievans ] William Markito [ wmarkito ]
          Hide
          Kim Haase added a comment -

          This task is really part of the task of internationalizing dukes-forest. It will probably involve creating a locale bean like the one used by dukes-tutoring, and setting the lang attribute to the value of the locale bean's language property.

          Show
          Kim Haase added a comment - This task is really part of the task of internationalizing dukes-forest. It will probably involve creating a locale bean like the one used by dukes-tutoring, and setting the lang attribute to the value of the locale bean's language property.
          Kim Haase made changes -
          Link This issue is related to JAVAEETUTORIAL-40 [ JAVAEETUTORIAL-40 ]
          Hide
          Kim Haase added a comment -

          A couple of mailconnector pages are missing the lang attribute. Will fix.

          Show
          Kim Haase added a comment - A couple of mailconnector pages are missing the lang attribute. Will fix.
          Ian Evans made changes -
          Affects Version/s 6.0.4 [ 10659 ]
          Affects Version/s 6 [ 10658 ]
          Hide
          William Markito added a comment -

          This issue has been fixed on Duke's Forest since we've applied i18n. The templates pages (shipment & store) has the following syntax:
          <html lang="#

          {localeBean.language}

          "...

          Show
          William Markito added a comment - This issue has been fixed on Duke's Forest since we've applied i18n. The templates pages (shipment & store) has the following syntax: <html lang="# {localeBean.language} "...
          Hide
          William Markito added a comment -

          This issue has been fixed on Duke's Forest since we've applied i18n. The templates pages (shipment & store) has the following syntax:
          <html lang="#

          {localeBean.language}

          "...

          Show
          William Markito added a comment - This issue has been fixed on Duke's Forest since we've applied i18n. The templates pages (shipment & store) has the following syntax: <html lang="# {localeBean.language} "...
          William Markito made changes -
          Status In Progress [ 3 ] Resolved [ 5 ]
          Fix Version/s 7.0.2 [ 16321 ]
          Resolution Fixed [ 1 ]

            People

            • Assignee:
              William Markito
              Reporter:
              Kim Haase
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Time Tracking

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 1 day
                1d