javamoney
  1. javamoney
  2. JAVAMONEY-131

Fail to override load-properties for ExchangeRateProviders in javamoney.properties.

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.0
    • Fix Version/s: 1.1
    • Component/s: Impl: RI
    • Labels:
      None
    • Environment:

      Windows 7

      Description

      The constructor of AbstractECBRateProvider contains loader.loadDataAsync(...). This is the same method-call as in DefaultLoaderService case ONSTARTUP: loadDataAsync. Hence when trying to override this property in javamoney.properties by setting

      {1}

      load.AbstractECBRateProvider=NEVER
      it will still run loadDataAsync.

      This might also be the case for the other ExchangeRateProviders.

      See http://stackoverflow.com/questions/30931631/overriding-properties-in-javamoney-properties for more details.

        Issue Links

          Activity

          Hide
          otaviojava added a comment - - edited

          PR created to solve this problem:
          https://github.com/JavaMoney/jsr354-ri/pull/113
          Just waiting all tests run to merge it.

          Show
          otaviojava added a comment - - edited PR created to solve this problem: https://github.com/JavaMoney/jsr354-ri/pull/113 Just waiting all tests run to merge it.
          Hide
          keilw added a comment -

          It's nice, to fix it in Moneta, but ensure, to solve exactly the same way in Moneta-BP (and where necessary create tests in both )

          Show
          keilw added a comment - It's nice, to fix it in Moneta, but ensure, to solve exactly the same way in Moneta-BP (and where necessary create tests in both )
          Hide
          otaviojava added a comment -

          The solution was just remove a configuration that was wrongly put on constructor.
          The code was merged.

          Show
          otaviojava added a comment - The solution was just remove a configuration that was wrongly put on constructor. The code was merged.
          Hide
          otaviojava added a comment -

          I found the problem on the class LoadableResource.
          https://github.com/JavaMoney/jsr354-ri/pull/116
          The class is difficult to create test, maybe we should create an issues to refactor the class and create a testable design.

          Show
          otaviojava added a comment - I found the problem on the class LoadableResource. https://github.com/JavaMoney/jsr354-ri/pull/116 The class is difficult to create test, maybe we should create an issues to refactor the class and create a testable design.
          Show
          otaviojava added a comment - Finally fixed: https://github.com/JavaMoney/jsr354-ri/pull/116 https://github.com/JavaMoney/jsr354-ri-bp/pull/17

            People

            • Assignee:
              otaviojava
              Reporter:
              itruls
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: