javamoney
  1. javamoney
  2. JAVAMONEY-72

Harmonize Static Inner Builder classes with Builder pattern/JDK

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.8
    • Fix Version/s: 1.0
    • Component/s: None
    • Labels:
      None

      Description

      Both all relevant parts of OpenJDK (e.g. Locale.Builder or Calendar.Builder new in Java 8) and the Builder pattern by sources like Effective Java declare a method called build() for the result.

      A number of places in the API like ExchangeRate.Builder or several *Context.Builder violate this, calling it create(). Those should be harmonized with the Builder pattern/usage and its usage by JDK.

      See also
      http://www.javacodegeeks.com/2013/01/the-builder-pattern-in-practice.html

        Activity

        keilw created issue -
        keilw made changes -
        Field Original Value New Value
        Fix Version/s 0.9 [ 16866 ]
        Affects Version/s 0.8 [ 16791 ]
        keilw made changes -
        Status Open [ 1 ] In Progress [ 3 ]
        keilw made changes -
        Fix Version/s 1.0 [ 16867 ]
        Fix Version/s 0.9 [ 16866 ]
        atsticks made changes -
        Status In Progress [ 3 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        atsticks made changes -
        Status Resolved [ 5 ] Closed [ 6 ]

          People

          • Assignee:
            keilw
            Reporter:
            keilw
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: