javaserverfaces
  1. javaserverfaces
  2. JAVASERVERFACES-103

Inner classes with no use of creating class reference could be static inner

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.1
    • Fix Version/s: 1.0
    • Component/s: None
    • Labels:
      None
    • Environment:

      Operating System: All
      Platform: All

    • Issuezilla Id:
      103

      Description

      Consider making the following static inner classes. They do not use their embedded reference to the
      class creating them, and making them static inner could eliminate the need for this reference which
      makes the class larger than necessary, and also stays alive longer than necessary:

      Should com.sun.faces.application.ApplicationAssociate$CaseStruct be a static inner class?
      Should com.sun.faces.application.ApplicationAssociate$SortIt be a static inner class?
      Should com.sun.faces.application.NavigationHandlerImpl$CaseStruct be a static inner class?
      Should com.sun.faces.config.ConfigureListener$ApplicationMap be a static inner class?
      Should com.sun.faces.context.ExternalContextImpl$LocalesIterator be a static inner class?
      Should com.sun.faces.renderkit.html_basic.HtmlBasicRenderer$Param be a static inner class?

        Activity

        Hide
        Ryan Lubke added a comment -

        All of these have been corrected for 1.2 except for StateManager$SerializedView.
        This can't be changed due to backwards compatibility.

        Show
        Ryan Lubke added a comment - All of these have been corrected for 1.2 except for StateManager$SerializedView. This can't be changed due to backwards compatibility.
        Hide
        Manfred Riem added a comment -

        Closing issue out

        Show
        Manfred Riem added a comment - Closing issue out

          People

          • Assignee:
            javaserverfowner
            Reporter:
            rajprem
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: