javaserverfaces
  1. javaserverfaces
  2. JAVASERVERFACES-113

API performance: inner classes not using creating class reference could be static inner

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.1
    • Fix Version/s: 1.0
    • Component/s: None
    • Labels:
      None
    • Environment:

      Operating System: All
      Platform: All

    • Issuezilla Id:
      113

      Description

      Consider making the following static inner classes:

      Should javax.faces.application.StateManager$SerializedView be a static inner class?
      Should javax.faces.component.UIComponentBase$ChildrenListIterator be a static inner class?
      Should javax.faces.component.UIComponentBase$FacetsAndChildrenIterator be a static inner class?
      Should javax.faces.component.UIComponentBase$FacetsMapEntrySetEntry be a static inner class?
      Should javax.faces.component.UIComponentBase$FacetsMapKeySetIterator be a static inner class?
      Should javax.faces.component.UIComponentBase$FacetsMapValuesIterator be a static inner class?
      Should javax.faces.component.UISelectMany$ArrayIterator be a static inner class?
      Should javax.faces.component.UISelectOne$ArrayIterator be a static inner class?
      Should javax.faces.model.ResultSetDataModel$ResultSetEntry be a static inner class?
      Should javax.faces.model.ResultSetDataModel$ResultSetKeysIterator be a static inner class?
      Should javax.faces.model.ResultSetDataModel$ResultSetValuesIterator be a static inner class?

        Activity

        Hide
        Ryan Lubke added a comment -

        Made all cases static except for
        javax.faces.application.StateManager$SerializedView since this is public and has
        been deprecated.

        Show
        Ryan Lubke added a comment - Made all cases static except for javax.faces.application.StateManager$SerializedView since this is public and has been deprecated.
        Hide
        Manfred Riem added a comment -

        Closing issue out

        Show
        Manfred Riem added a comment - Closing issue out

          People

          • Assignee:
            javaserverfowner
            Reporter:
            rajprem
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: