javaserverfaces
  1. javaserverfaces
  2. JAVASERVERFACES-122

redirect attribute dissappeared from inputSecret

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.2
    • Fix Version/s: 1.0
    • Component/s: None
    • Labels:
      None
    • Environment:

      Operating System: All
      Platform: All

    • Issuezilla Id:
      122

      Description

      It appears redirect doesn't exist as an attribute of the inputSecret tag. I
      noticed the attribute is still used SecretRenderer and HtmlInputSecret. I tried
      to add an f:attribute for redisplay but that didn't work.

      Mike

        Activity

        Hide
        youngm added a comment -

        After doing some poking around I noticed that in
        jsf-api/doc/standard-html-renderkit.xml the component has that property but the
        renderkit doesn't have the attribute.

        The renderer in jsf-api/doc/standard-html-renderkit-base.xml looks like the
        following:

        <component-family>javax.faces.Input</component-family>
        <renderer-type>javax.faces.Secret</renderer-type>
        <renderer-class>
        <xi:include href="standard-html-renderkit-impl.xml"
        xpointer="xpointer(/root/input-secret-renderer-class/text())"/>
        </renderer-class>

        <xi:include href="core-attrs.xml" xpointer="xpointer(/root/*)"/>
        <xi:include href="events-attrs.xml" xpointer="xpointer(/root/*)"/>
        <xi:include href="focus-attrs.xml" xpointer="xpointer(/root/*)"/>
        <xi:include href="i18n-attrs.xml" xpointer="xpointer(/root/*)"/>
        <xi:include href="input-attrs.xml" xpointer="xpointer(/root/*)"/>
        <xi:include href="text-attrs.xml" xpointer="xpointer(/root/*)"/>
        <xi:include href="input-attrs.xml" xpointer="xpointer(/root/*)"/>

        </renderer>

        I assume there is probably supposed to be some sort of input-secret-attrs.xml
        file included here but it is not.

        Mike

        Show
        youngm added a comment - After doing some poking around I noticed that in jsf-api/doc/standard-html-renderkit.xml the component has that property but the renderkit doesn't have the attribute. The renderer in jsf-api/doc/standard-html-renderkit-base.xml looks like the following: <component-family>javax.faces.Input</component-family> <renderer-type>javax.faces.Secret</renderer-type> <renderer-class> <xi:include href="standard-html-renderkit-impl.xml" xpointer="xpointer(/root/input-secret-renderer-class/text())"/> </renderer-class> <xi:include href="core-attrs.xml" xpointer="xpointer(/root/*)"/> <xi:include href="events-attrs.xml" xpointer="xpointer(/root/*)"/> <xi:include href="focus-attrs.xml" xpointer="xpointer(/root/*)"/> <xi:include href="i18n-attrs.xml" xpointer="xpointer(/root/*)"/> <xi:include href="input-attrs.xml" xpointer="xpointer(/root/*)"/> <xi:include href="text-attrs.xml" xpointer="xpointer(/root/*)"/> <xi:include href="input-attrs.xml" xpointer="xpointer(/root/*)"/> </renderer> I assume there is probably supposed to be some sort of input-secret-attrs.xml file included here but it is not. Mike
        Hide
        Ryan Lubke added a comment -

        I'm assuming you mean the redisplay attribute.

        Thanks for catching the typo. That last xinclude for the secret renderer
        should have been input-secret-attrs.xml

        I'll commit the fix shortly.

        Show
        Ryan Lubke added a comment - I'm assuming you mean the redisplay attribute. Thanks for catching the typo. That last xinclude for the secret renderer should have been input-secret-attrs.xml I'll commit the fix shortly.
        Hide
        Ryan Lubke added a comment -

        Assumed ownership

        Show
        Ryan Lubke added a comment - Assumed ownership
        Hide
        Ryan Lubke added a comment -

        Correct typo.

        SECTION: Modified Files
        ----------------------------
        M doc/standard-html-renderkit-base.xml
        M doc/standard-html-renderkit.xml

        SECTION: Diffs
        ----------------------------
        Index: doc/standard-html-renderkit-base.xml
        ===================================================================
        RCS file:
        /cvs/javaserverfaces-sources/jsf-api/doc/standard-html-renderkit-base.xml,v
        retrieving revision 1.8
        diff -u -r1.8 standard-html-renderkit-base.xml
        — doc/standard-html-renderkit-base.xml 21 Apr 2005 18:55:28 -0000 1.8
        +++ doc/standard-html-renderkit-base.xml 12 May 2005 17:23:37 -0000
        @@ -1398,7 +1398,7 @@
        <xi:include href="i18n-attrs.xml" xpointer="xpointer(/root/*)"/>
        <xi:include href="input-attrs.xml" xpointer="xpointer(/root/*)"/>
        <xi:include href="text-attrs.xml" xpointer="xpointer(/root/*)"/>

        • <xi:include href="input-attrs.xml" xpointer="xpointer(/root/*)"/>
          + <xi:include href="input-secret-attrs.xml"
          xpointer="xpointer(/root/*)"/>

        <renderer-extension>
        <renders-children>true</renders-children>
        Index: doc/standard-html-renderkit.xml
        ===================================================================
        RCS file: /cvs/javaserverfaces-sources/jsf-api/doc/standard-html-renderkit.xml,v
        retrieving revision 1.82
        diff -u -r1.82 standard-html-renderkit.xml
        — doc/standard-html-renderkit.xml 9 May 2005 20:24:45 -0000 1.82
        +++ doc/standard-html-renderkit.xml 12 May 2005 17:24:07 -0000
        @@ -18890,66 +18890,16 @@

        <attribute>
        <description>

        • Flag indicating that this element must never
        • receive focus or be included in a subsequent
        • submit.
          + Flag indicating that any existing value
          + in this field should be rendered when the
          + form is created. Because this is a potential
          + security risk, password values are not
          + displayed by default.
          </description>
        • <display-name>Disabled Flag</display-name>
          + <display-name>Redisplay Flag</display-name>
          <icon/>
        • <attribute-name>disabled</attribute-name>
          + <attribute-name>redisplay</attribute-name>
          <attribute-class>boolean</attribute-class>
        • <attribute-extension>
        • <pass-through>true</pass-through>
        • </attribute-extension>
        • </attribute>
        • <attribute>
        • <description>
        • Javascript code executed when this element loses focus
        • and its value has been modified since gaining focus.
        • </description>
        • <display-name>Input Change Script</display-name>
        • <icon/>
        • <attribute-name>onchange</attribute-name>
        • <attribute-class>java.lang.String</attribute-class>
        • <attribute-extension>
        • <pass-through>true</pass-through>
        • </attribute-extension>
        • </attribute>
        • <attribute>
        • <description>
        • Javascript code executed when text within this
        • element is selected by the user.
        • </description>
        • <display-name>Text Select Script</display-name>
        • <icon/>
        • <attribute-name>onselect</attribute-name>
        • <attribute-class>java.lang.String</attribute-class>
        • <attribute-extension>
        • <pass-through>true</pass-through>
        • </attribute-extension>
        • </attribute>
        • <attribute>
        • <description>
        • Flag indicating that this component will prohibit
        • changes by the user. The element may receive focus
        • unless it has also been disabled.
        • </description>
        • <display-name>Read Only Flag</display-name>
        • <icon/>
        • <attribute-name>readonly</attribute-name>
        • <attribute-class>boolean</attribute-class>
        • <attribute-extension>
        • <pass-through>true</pass-through>
        • </attribute-extension>
        • </attribute>
        • <attribute>
        • <description>
        • A localized user presentable name for this component.
        • </description>
        • <display-name>Label</display-name>
        • <icon/>
        • <attribute-name>label</attribute-name>
        • <attribute-class>java.lang.String</attribute-class>
          </attribute>

        <renderer-extension>

        Show
        Ryan Lubke added a comment - Correct typo. SECTION: Modified Files ---------------------------- M doc/standard-html-renderkit-base.xml M doc/standard-html-renderkit.xml SECTION: Diffs ---------------------------- Index: doc/standard-html-renderkit-base.xml =================================================================== RCS file: /cvs/javaserverfaces-sources/jsf-api/doc/standard-html-renderkit-base.xml,v retrieving revision 1.8 diff -u -r1.8 standard-html-renderkit-base.xml — doc/standard-html-renderkit-base.xml 21 Apr 2005 18:55:28 -0000 1.8 +++ doc/standard-html-renderkit-base.xml 12 May 2005 17:23:37 -0000 @@ -1398,7 +1398,7 @@ <xi:include href="i18n-attrs.xml" xpointer="xpointer(/root/*)"/> <xi:include href="input-attrs.xml" xpointer="xpointer(/root/*)"/> <xi:include href="text-attrs.xml" xpointer="xpointer(/root/*)"/> <xi:include href="input-attrs.xml" xpointer="xpointer(/root/*)"/> + <xi:include href="input-secret-attrs.xml" xpointer="xpointer(/root/*)"/> <renderer-extension> <renders-children>true</renders-children> Index: doc/standard-html-renderkit.xml =================================================================== RCS file: /cvs/javaserverfaces-sources/jsf-api/doc/standard-html-renderkit.xml,v retrieving revision 1.82 diff -u -r1.82 standard-html-renderkit.xml — doc/standard-html-renderkit.xml 9 May 2005 20:24:45 -0000 1.82 +++ doc/standard-html-renderkit.xml 12 May 2005 17:24:07 -0000 @@ -18890,66 +18890,16 @@ <attribute> <description> Flag indicating that this element must never receive focus or be included in a subsequent submit. + Flag indicating that any existing value + in this field should be rendered when the + form is created. Because this is a potential + security risk, password values are not + displayed by default. </description> <display-name>Disabled Flag</display-name> + <display-name>Redisplay Flag</display-name> <icon/> <attribute-name>disabled</attribute-name> + <attribute-name>redisplay</attribute-name> <attribute-class>boolean</attribute-class> <attribute-extension> <pass-through>true</pass-through> </attribute-extension> </attribute> <attribute> <description> Javascript code executed when this element loses focus and its value has been modified since gaining focus. </description> <display-name>Input Change Script</display-name> <icon/> <attribute-name>onchange</attribute-name> <attribute-class>java.lang.String</attribute-class> <attribute-extension> <pass-through>true</pass-through> </attribute-extension> </attribute> <attribute> <description> Javascript code executed when text within this element is selected by the user. </description> <display-name>Text Select Script</display-name> <icon/> <attribute-name>onselect</attribute-name> <attribute-class>java.lang.String</attribute-class> <attribute-extension> <pass-through>true</pass-through> </attribute-extension> </attribute> <attribute> <description> Flag indicating that this component will prohibit changes by the user. The element may receive focus unless it has also been disabled. </description> <display-name>Read Only Flag</display-name> <icon/> <attribute-name>readonly</attribute-name> <attribute-class>boolean</attribute-class> <attribute-extension> <pass-through>true</pass-through> </attribute-extension> </attribute> <attribute> <description> A localized user presentable name for this component. </description> <display-name>Label</display-name> <icon/> <attribute-name>label</attribute-name> <attribute-class>java.lang.String</attribute-class> </attribute> <renderer-extension>
        Hide
        youngm added a comment -

        Correct redisplay.

        Show
        youngm added a comment - Correct redisplay.
        Hide
        Ed Burns added a comment -

        r=edburns

        Show
        Ed Burns added a comment - r=edburns
        Hide
        Ryan Lubke added a comment -

        Fix checked in.

        Show
        Ryan Lubke added a comment - Fix checked in.
        Hide
        Manfred Riem added a comment -

        Closing issue out

        Show
        Manfred Riem added a comment - Closing issue out

          People

          • Assignee:
            Ryan Lubke
            Reporter:
            youngm
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: