javaserverfaces
  1. javaserverfaces
  2. JAVASERVERFACES-151

Swallowed exception in ResopnseStateManagerImpl.getTreeStructureToRestore().

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: current
    • Fix Version/s: 1.0
    • Component/s: None
    • Labels:
      None
    • Environment:

      Operating System: All
      Platform: All

    • Issuezilla Id:
      151

      Description

      The following exceptions are swallowed when thrown during tree restoration in
      ResponseStateManager.

      } catch (java.io.OptionalDataException ode)

      { logger.log(Level.SEVERE, ode.getMessage(), ode); }

      catch (java.lang.ClassNotFoundException cnfe)

      { logger.log(Level.SEVERE,cnfe.getMessage(), cnfe); }

      catch (java.io.IOException iox)

      { logger.log(Level.SEVERE,iox.getMessage(), iox); }

      Is this what we want?

      I experienced this as a non-descript NPE in processRestoreState(). It would be
      better to give more correct information.

        Activity

        Hide
        jayashri added a comment -

        Taking ownership

        Show
        jayashri added a comment - Taking ownership
        Hide
        jayashri added a comment -

        Index: src/com/sun/faces/renderkit/ResponseStateManagerImpl.java
        ===================================================================
        RCS file: /cvs/javaserverfaces-sources/jsf-ri/src/com/sun/faces/renderkit/Respon
        seStateManagerImpl.java,v
        retrieving revision 1.22
        diff -u -r1.22 ResponseStateManagerImpl.java
        — src/com/sun/faces/renderkit/ResponseStateManagerImpl.java 23 Jun 2005 15:3
        1:33 -0000 1.22
        +++ src/com/sun/faces/renderkit/ResponseStateManagerImpl.java 16 Jul 2005 00:5
        2:02 -0000
        @@ -25,6 +25,7 @@
        import javax.faces.context.ResponseWriter;
        import javax.faces.render.RenderKitFactory;
        import javax.faces.render.ResponseStateManager;
        +import javax.faces.FacesException;

        import com.sun.faces.util.Base64;
        import com.sun.faces.util.Util;
        @@ -153,10 +154,13 @@
        ois.close();
        } catch (java.io.OptionalDataException ode)

        { logger.log(Level.SEVERE, ode.getMessage(), ode); + throw new FacesException(ode); }

        catch (java.lang.ClassNotFoundException cnfe)

        { logger.log(Level.SEVERE,cnfe.getMessage(), cnfe); + throw new FacesException(cnfe); }

        catch (java.io.IOException iox)

        { logger.log(Level.SEVERE,iox.getMessage(), iox); + throw new FacesException(iox); }

        }
        else {

        Show
        jayashri added a comment - Index: src/com/sun/faces/renderkit/ResponseStateManagerImpl.java =================================================================== RCS file: /cvs/javaserverfaces-sources/jsf-ri/src/com/sun/faces/renderkit/Respon seStateManagerImpl.java,v retrieving revision 1.22 diff -u -r1.22 ResponseStateManagerImpl.java — src/com/sun/faces/renderkit/ResponseStateManagerImpl.java 23 Jun 2005 15:3 1:33 -0000 1.22 +++ src/com/sun/faces/renderkit/ResponseStateManagerImpl.java 16 Jul 2005 00:5 2:02 -0000 @@ -25,6 +25,7 @@ import javax.faces.context.ResponseWriter; import javax.faces.render.RenderKitFactory; import javax.faces.render.ResponseStateManager; +import javax.faces.FacesException; import com.sun.faces.util.Base64; import com.sun.faces.util.Util; @@ -153,10 +154,13 @@ ois.close(); } catch (java.io.OptionalDataException ode) { logger.log(Level.SEVERE, ode.getMessage(), ode); + throw new FacesException(ode); } catch (java.lang.ClassNotFoundException cnfe) { logger.log(Level.SEVERE,cnfe.getMessage(), cnfe); + throw new FacesException(cnfe); } catch (java.io.IOException iox) { logger.log(Level.SEVERE,iox.getMessage(), iox); + throw new FacesException(iox); } } else {
        Hide
        Ed Burns added a comment -

        r=edburns

        Show
        Ed Burns added a comment - r=edburns
        Hide
        jayashri added a comment -

        fix checked in.

        Show
        jayashri added a comment - fix checked in.
        Hide
        Manfred Riem added a comment -

        Closing issue out

        Show
        Manfred Riem added a comment - Closing issue out

          People

          • Assignee:
            jayashri
            Reporter:
            Ed Burns
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: