Details

    • Type: New Feature New Feature
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: current
    • Fix Version/s: 1.0
    • Component/s: None
    • Labels:
      None
    • Environment:

      Operating System: All
      Platform: All

    • Issuezilla Id:
      166

      Description

      Now that the JSTL implementation for c:forEach is complete inside of glassfish,
      it's time to add it to JSF.

      1. issue167_1.diff
        6 kB
        jayashri
      2. issue167_2.diff
        7 kB
        jayashri
      3. issue167.diff
        5 kB
        jayashri
      4. issue167.diff
        0.4 kB
        jayashri
      5. jsfri166-foreach.tar.gz
        15 kB
        Ed Burns

        Activity

        Hide
        jayashri added a comment -

        ok, here is another iteration. This logic uses the existing "createComponents"
        list in UIComponentClassicTagBase to track duplicateIds generically without
        explicitly looking for c:ForEach. This list maintains a list of "ids" for the
        components created by the nearest NamingContainer. The new isDuplicateId()
        method makes use of this list to check for duplicate id, if the current
        facesJspId being processed already exists, we append a counter. The only extra
        step we perform is a list look up which is much more efficient than the earlier
        proposals.
        Please review the most recent attachments that implements the above.
        Thanks

        Show
        jayashri added a comment - ok, here is another iteration. This logic uses the existing "createComponents" list in UIComponentClassicTagBase to track duplicateIds generically without explicitly looking for c:ForEach. This list maintains a list of "ids" for the components created by the nearest NamingContainer. The new isDuplicateId() method makes use of this list to check for duplicate id, if the current facesJspId being processed already exists, we append a counter. The only extra step we perform is a list look up which is much more efficient than the earlier proposals. Please review the most recent attachments that implements the above. Thanks
        Hide
        jayashri added a comment -

        Created an attachment (id=96)
        3rd iteration

        Show
        jayashri added a comment - Created an attachment (id=96) 3rd iteration
        Hide
        Ed Burns added a comment -

        This is good, r=edburns. The bottleneck now is the speed of the contains
        algorithm in ArrayList. Perhaps put a pending comment in saying we may need to
        analyze that for trees with very high numbers of children per parent.

        Ed

        Show
        Ed Burns added a comment - This is good, r=edburns. The bottleneck now is the speed of the contains algorithm in ArrayList. Perhaps put a pending comment in saying we may need to analyze that for trees with very high numbers of children per parent. Ed
        Hide
        jayashri added a comment -

        changes checked in.

        Show
        jayashri added a comment - changes checked in.
        Hide
        Manfred Riem added a comment -

        Closing issue out

        Show
        Manfred Riem added a comment - Closing issue out

          People

          • Assignee:
            jayashri
            Reporter:
            Ed Burns
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: