Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: current
    • Fix Version/s: 1.0
    • Component/s: None
    • Labels:
      None
    • Environment:

      Operating System: All
      Platform:

    • Issuezilla Id:
      167

      Description

      >>>>> On Wed, 25 May 2005 14:15:06 -0700, Ana von Klopp said:

      AVK> Any component that extends UIInput and is bound to a primitive value
      AVK> becomes invalid with a cryptic message (IllegalArgumentException) if
      AVK> nothing is entered.

      AVK> To reproduce: create a page with <h:inputText> and bind the value to a
      AVK> managed bean property that is an int. On the page, add a <h:message>
      AVK> for the field.

      AVK> <h:message for="form:something" />
      AVK> <h:inputText id="something" value="#

      {fieldBean.number}

      " />

      AVK> Create a the bean with a single property that's an int.

      AVK> Run the page. Delete all characters from field and submit the page.
      AVK> The component becomes invalid, and the message doesn't help you fix
      AVK> it.

      AVK> It's probably correct that the component becomes invalid, but that
      AVK> message is not helpful to the user.

      AVK> Ana

      1. jsfri167-remove-jstl-dependency.tar
        50 kB
        Ed Burns
      2. message.txt
        15 kB
        Ed Burns
      3. message.txt
        10 kB
        Ed Burns

        Activity

        Hide
        Ed Burns added a comment -

        accept

        Show
        Ed Burns added a comment - accept
        Hide
        Ed Burns added a comment -

        Fix in progress.

        Show
        Ed Burns added a comment - Fix in progress.
        Hide
        Ed Burns added a comment -

        Created an attachment (id=91)
        Fix for this bug. version 1

        Show
        Ed Burns added a comment - Created an attachment (id=91) Fix for this bug. version 1
        Hide
        Ed Burns added a comment -

        Sent to glassfish dev alias. Provides a nice rationale for this bug.

        >>>>> On Thu, 11 Aug 2005 14:41:51 -0700, Ed Burns <ed.burns@sun.com> said:

        EB> This change-bundle enables localized messages to be generated when an
        EB> error condition arises from deep within the bowels of the EL.

        EB> It relies on a convention I'm currently trying to make a standard in the
        EB> webtier-alignment Expert Group, but even if it doesn't pass, I still
        EB> think it's a useful implementation feature.

        EB> For example, without this feature, if you're using jsf on a text field
        EB> bound to a primitive typed javaBeans property, and you submit a form
        EB> with no value in the text field, you get the message:

        EB> java.lang.IllegalArgumentException.

        EB> With this change, you instead get:

        EB> Can't set property intProperty of type int on class com.foo.Foo to value
        EB> null.

        Show
        Ed Burns added a comment - Sent to glassfish dev alias. Provides a nice rationale for this bug. >>>>> On Thu, 11 Aug 2005 14:41:51 -0700, Ed Burns <ed.burns@sun.com> said: EB> This change-bundle enables localized messages to be generated when an EB> error condition arises from deep within the bowels of the EL. EB> It relies on a convention I'm currently trying to make a standard in the EB> webtier-alignment Expert Group, but even if it doesn't pass, I still EB> think it's a useful implementation feature. EB> For example, without this feature, if you're using jsf on a text field EB> bound to a primitive typed javaBeans property, and you submit a form EB> with no value in the text field, you get the message: EB> java.lang.IllegalArgumentException. EB> With this change, you instead get: EB> Can't set property intProperty of type int on class com.foo.Foo to value EB> null.
        Hide
        Ed Burns added a comment -

        Created an attachment (id=93)
        Fix for this bug. version 2. Include ELContext "locale" property, and mods for UIViewRoot.

        Show
        Ed Burns added a comment - Created an attachment (id=93) Fix for this bug. version 2. Include ELContext "locale" property, and mods for UIViewRoot.
        Hide
        Ed Burns added a comment -

        Fix checked in to JSF and EL.

        Show
        Ed Burns added a comment - Fix checked in to JSF and EL.
        Hide
        Ed Burns added a comment -

        Created an attachment (id=97)
        Tar of files to remove JSF's depenedncy on JSTL. We're not doing this for 1.2, however.

        Show
        Ed Burns added a comment - Created an attachment (id=97) Tar of files to remove JSF's depenedncy on JSTL. We're not doing this for 1.2, however.
        Hide
        Manfred Riem added a comment -

        Closing issue out

        Show
        Manfred Riem added a comment - Closing issue out

          People

          • Assignee:
            Ed Burns
            Reporter:
            Ed Burns
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: