javaserverfaces
  1. javaserverfaces
  2. JAVASERVERFACES-1676

ScriptStyleBaseRenderer uses potentially expensive findComponent() calls

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Trivial Trivial
    • Resolution: Incomplete
    • Affects Version/s: 2.0.1
    • Fix Version/s: None
    • Component/s: None
    • Labels:
      None
    • Environment:

      Operating System: All
      Platform: All

    • Issuezilla Id:
      1,676
    • Status Whiteboard:
      Hide

      size_small importance_small

      Show
      size_small importance_small
    • Tags:

      Description

      Encountered while analyzing the following thread:

      http://mail-archives.apache.org/mod_mbox/myfaces-
      dev/201005.mbox/%3c4BF34C9E.3010108@oracle.com%3e

      ScriptStyleBaseRenderer attempts to ensure that #

      {cc}

      EL context is set up for components that it
      relocates to the UIViewRoot. This results in calls to findComponent() in order to locate the composite
      component at render time:

      public void encodeBegin(FacesContext context, UIComponent component)
      throws IOException {

      String ccID = (String) component.getAttributes().get(COMP_KEY);
      UIComponent cc = context.getViewRoot().findComponent(':' + ccID);

      This can result in full component tree searches, which can be expensive for large component trees.

        Issue Links

          Activity

          Hide
          Ed Burns added a comment -

          Add adf keyword.

          Show
          Ed Burns added a comment - Add adf keyword.
          Hide
          Ed Burns added a comment -

          triage

          Show
          Ed Burns added a comment - triage
          Hide
          Ed Burns added a comment -

          Bulk assign all impl issues to Roger.

          Show
          Ed Burns added a comment - Bulk assign all impl issues to Roger.
          Hide
          Manfred Riem added a comment -

          Can you verify if this is still an issue on the latest 2.1 release?

          Show
          Manfred Riem added a comment - Can you verify if this is still an issue on the latest 2.1 release?
          Hide
          Manfred Riem added a comment -

          Lowering priority because of no response

          Show
          Manfred Riem added a comment - Lowering priority because of no response
          Hide
          Manfred Riem added a comment -

          Lowering priority because of no response

          Show
          Manfred Riem added a comment - Lowering priority because of no response
          Hide
          Manfred Riem added a comment -

          Closing because of inactivity

          Show
          Manfred Riem added a comment - Closing because of inactivity

            People

            • Assignee:
              Unassigned
              Reporter:
              aschwart
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: