javaserverfaces
  1. javaserverfaces
  2. JAVASERVERFACES-1681

Unnecessary event delivery during tag re-execution

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Won't Fix
    • Affects Version/s: 2.0.1
    • Fix Version/s: None
    • Component/s: None
    • Labels:
      None
    • Environment:

      Operating System: All
      Platform: All

    • Issuezilla Id:
      1,681
    • Status Whiteboard:
      Hide

      size_large importance_medium

      Show
      size_large importance_medium
    • Tags:

      Description

      Encountered while analyzing the following thread:

      http://mail-archives.apache.org/mod_mbox/myfaces-
      dev/201005.mbox/%3c4BF34C9E.3010108@oracle.com%3e

      When executing tags against an existing component tree (during render response on postbacks),
      Facelets temporarily removes and then immediately re-adds each component. This results in
      PreRemove/PostAdd events being delivered.

      Aside form being unnecessarily expensive, this is not the right abstraction. The fact that Facelets
      happens to remove/re-add components during tag execution for its own purposes is incidental.
      Component/page authors should not be exposed to this - it is an implementation detail of Facelets.

        Activity

        Hide
        rogerk added a comment -

        ms6

        Show
        rogerk added a comment - ms6
        Hide
        rogerk added a comment -

        Spoke with Andy Schwartz. This appears to be an impl only change.
        If time permits we can attempt to get it in. Worst case is we can deliver
        as first patch release for 2.1 (2.1_B01)

        Show
        rogerk added a comment - Spoke with Andy Schwartz. This appears to be an impl only change. If time permits we can attempt to get it in. Worst case is we can deliver as first patch release for 2.1 (2.1_B01)
        Hide
        rogerk added a comment -

        Andy and I agreed that as a last resort we could target this for first 2.1 patch
        release.

        Show
        rogerk added a comment - Andy and I agreed that as a last resort we could target this for first 2.1 patch release.
        Hide
        rogerk added a comment -

        triage

        Show
        rogerk added a comment - triage
        Hide
        rogerk added a comment -

        This has been fixed since 2.0.3.
        Look for the class/method:

        com.sun.faces.facelets.tag.jsf.ComponentTagHandlerDelegateImpl.doOrphanedChildCleanup().

        Show
        rogerk added a comment - This has been fixed since 2.0.3. Look for the class/method: com.sun.faces.facelets.tag.jsf.ComponentTagHandlerDelegateImpl.doOrphanedChildCleanup().

          People

          • Assignee:
            rogerk
            Reporter:
            aschwart
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: