Issue Details (XML | Word | Printable)

Key: JAVASERVERFACES-1720
Type: Task Task
Status: Closed Closed
Resolution: Fixed
Priority: Major Major
Assignee: Ed Burns
Reporter: Ed Burns
Votes: 0
Watchers: 0
Operations

If you were logged in you would be able to see more operations.
javaserverfaces

Review latest HEAD for 1.2_15 with fixes for 1628, 1630, 1631,1632, 1620, 1621, 1619

Created: 30/Jun/10 02:42 PM   Updated: 26/Jun/12 02:49 PM   Resolved: 13/Jul/10 03:05 PM
Component/s: None
Affects Version/s: 2.0.2
Fix Version/s: 2.1_gf31_m3

Time Tracking:
Not Specified

File Attachments: 1. Text File 1720-diffs-working.txt (125 kB) 02/Jul/10 08:51 AM - Ed Burns
2. Zip Archive 1720-research.zip (900 kB) 30/Jun/10 09:34 PM - Ed Burns
3. Text File 1720.txt (196 kB) 13/Jul/10 10:14 AM - Ed Burns
4. Text File 1720.txt (203 kB) 13/Jul/10 07:46 AM - Ed Burns
5. Text File changebundle.txt (206 kB) 02/Jul/10 02:11 PM - Ed Burns
6. Zip Archive newfiles.zip (64 kB) 02/Jul/10 02:13 PM - Ed Burns

Environment:

Operating System: All
Platform: All


Issuezilla Id: 1,720
Status Whiteboard:

size_large importance_large

Tags: adf performance
Participants: Ed Burns and Manfred Riem


 Description  « Hide

Just do an extra check to make sure nothing was left behind.



Ed Burns added a comment - 30/Jun/10 02:43 PM

This is a TASK for GlassFIsh 3.1 M3


Ed Burns added a comment - 30/Jun/10 09:30 PM

I used the following CVS commands to research this task.

Set the default branch to be JSF_1_2X_ROLLING

cvs admin -bJSF_1_2X_ROLLING

Collect the diffs on this branch between 2010-04-01 and today.

cvs log -d"2010-04-01<2010-06-30" > cvslog-20100401-20100630.txt

Collect the set of files claimed to be modified in the manually entered
CVS log messages.

grep "^M " cvslog-20100401-20100630.txt > cvslog-20100401-20100630-log-message-
modified-files.txt

sort cvslog-20100401-20100630-log-message-modified-files.txt | uniq

store this output back into
cvslog-20100401-20100630-log-message-modified-files.txt

Collect the set of files actually modified by looking for lines starting
with "RCS file:" that correspond to lines that start with "revision ".
I used an emacs keyboard macro for this. Collect this output into
cvslog-20100401-20100630-rcs-modified-files-filenames-only.txt Massage
this file to have the same format as log-message-modified-files.txt.

Diff the two files. By analyzing the diffs, I can see that the CVS
added files show up in the Attic in the RCS file: prefixed lines.
Therefore, I conclude that the RCS file: prefixed lines gives me the
complete set of changed, added, deleted files.

Here it is:

.cvsignore
common/ant/common.xml
jsf-api/src/javax/faces/webapp/UIComponentClassicTagBase.java
jsf-api/test/javax/faces/webapp/AttributeTagTestCase.java
jsf-ri/build-tests.xml
jsf-ri/build.xml
jsf-ri/src/com/sun/faces/application/ApplicationAssociate.java
jsf-ri/src/com/sun/faces/application/ApplicationImpl.java
jsf-ri/src/com/sun/faces/application/ViewHandlerImpl.java
jsf-ri/src/com/sun/faces/config/ConfigureListener.java
jsf-ri/src/com/sun/faces/config/InitFacesContext.java
jsf-ri/src/com/sun/faces/config/configprovider/WebResourceProvider.java
jsf-ri/src/com/sun/faces/el/Attic/ChainTypeCompositeELResolver.java
jsf-ri/src/com/sun/faces/el/Attic/DemuxCompositeELResolver.java
jsf-ri/src/com/sun/faces/el/ChainAwareVariableResolver.java
jsf-ri/src/com/sun/faces/el/ELUtils.java
jsf-ri/src/com/sun/faces/el/FacesCompositeELResolver.java
jsf-ri/src/com/sun/faces/el/ImplicitObjectELResolver.java
jsf-ri/src/com/sun/faces/el/ImplicitObjectELResolverForJsp.java
jsf-ri/src/com/sun/faces/el/ManagedBeanELResolver.java
jsf-ri/src/com/sun/faces/el/ScopedAttributeELResolver.java
jsf-ri/src/com/sun/faces/el/VariableResolverChainWrapper.java
jsf-ri/src/com/sun/faces/el/VariableResolverImpl.java
jsf-ri/src/com/sun/faces/lifecycle/ELResolverInitPhaseListener.java
jsf-ri/src/com/sun/faces/mgbean/BeanBuilder.java
jsf-ri/src/com/sun/faces/mgbean/BeanManager.java
jsf-ri/src/com/sun/faces/taglib/jsf_core/LoadBundleTag.java
jsf-ri/src/com/sun/faces/taglib/jsf_core/SubviewTag.java
jsf-ri/src/com/sun/faces/taglib/jsf_core/ViewTag.java
jsf-ri/src/com/sun/faces/util/RequestStateManager.java
jsf-ri/src/com/sun/faces/util/Util.java
jsf-ri/systest-per-webapp/add-elresolver-and-replace-variableresolver-
programmatically/src/java/com/sun/faces/systest/Attic/AddELResolverAndReplaceVariableresolverP
rogrammaticallyTestCase.java
jsf-ri/systest-per-webapp/add-elresolver-and-replace-variableresolver-
programmatically/src/java/com/sun/faces/systest/Attic/Bean.java
jsf-ri/systest-per-webapp/add-elresolver-and-replace-variableresolver-
programmatically/src/java/com/sun/faces/systest/Attic/NewELResolver.java
jsf-ri/systest-per-webapp/add-elresolver-and-replace-variableresolver-
programmatically/src/java/com/sun/faces/systest/Attic/NewVariableResolver.java
jsf-ri/systest-per-webapp/add-elresolver-and-replace-variableresolver-
programmatically/src/java/com/sun/faces/systest/Attic/ProgrammaticAddELResolverListenerAndSet
VariableResolver.java
jsf-ri/systest-per-webapp/add-elresolver-and-replace-variableresolver-
programmatically/web/Attic/test.jsp
jsf-ri/systest-per-webapp/add-elresolver-and-replace-variableresolver-
programmatically/web/Attic/test1.jsp
jsf-ri/systest-per-webapp/add-elresolver-and-replace-variableresolver-
programmatically/web/WEB-INF/Attic/faces-config.xml
jsf-ri/systest-per-webapp/add-elresolver-and-replace-variableresolver-
programmatically/web/WEB-INF/Attic/web.xml
jsf-ri/systest-per-webapp/build-tests.xml
jsf-ri/systest-per-webapp/build.xml
jsf-ri/systest-per-webapp/replace-variableresolver-and-add-elresolver-
programmatically/src/java/com/sun/faces/systest/Attic/Bean.java
jsf-ri/systest-per-webapp/replace-variableresolver-and-add-elresolver-
programmatically/src/java/com/sun/faces/systest/Attic/NewELResolver.java
jsf-ri/systest-per-webapp/replace-variableresolver-and-add-elresolver-
programmatically/src/java/com/sun/faces/systest/Attic/NewVariableResolver.java
jsf-ri/systest-per-webapp/replace-variableresolver-and-add-elresolver-
programmatically/src/java/com/sun/faces/systest/Attic/ProgrammaticSetVariableResolverAndAddEL
ResolverListenerFilter.java
jsf-ri/systest-per-webapp/replace-variableresolver-and-add-elresolver-
programmatically/src/java/com/sun/faces/systest/Attic/ReplaceVariableResolverAndAddELResolver
ProgrammaticallyTestCase.java
jsf-ri/systest-per-webapp/replace-variableresolver-and-add-elresolver-
programmatically/web/Attic/test.jsp
jsf-ri/systest-per-webapp/replace-variableresolver-and-add-elresolver-
programmatically/web/Attic/test1.jsp
jsf-ri/systest-per-webapp/replace-variableresolver-and-add-elresolver-
programmatically/web/WEB-INF/Attic/faces-config.xml
jsf-ri/systest-per-webapp/replace-variableresolver-and-add-elresolver-
programmatically/web/WEB-INF/Attic/web.xml
jsf-ri/systest-per-webapp/replace-variableresolver-
programmatically/src/java/com/sun/faces/systest/Attic/Bean.java
jsf-ri/systest-per-webapp/replace-variableresolver-
programmatically/src/java/com/sun/faces/systest/Attic/NewVariableResolver.java
jsf-ri/systest-per-webapp/replace-variableresolver-
programmatically/src/java/com/sun/faces/systest/Attic/ProgrammaticAddVariableResolverListener.j
ava
jsf-ri/systest-per-webapp/replace-variableresolver-
programmatically/src/java/com/sun/faces/systest/Attic/ReplaceVariableResolverTestCase.java
jsf-ri/systest-per-webapp/replace-variableresolver-programmatically/web/Attic/test.jsp
jsf-ri/systest-per-webapp/replace-variableresolver-programmatically/web/Attic/test1.jsp
jsf-ri/systest-per-webapp/replace-variableresolver-programmatically/web/WEB-INF/Attic/faces-
config.xml
jsf-ri/systest-per-webapp/replace-variableresolver-programmatically/web/WEB-INF/Attic/web.xml
jsf-ri/systest/build-tests.xml
jsf-ri/systest/build.xml
jsf-ri/systest/src/com/sun/faces/systest/lifecycle/ManagedBeanLifecycleAnnotationTestCase.java
jsf-ri/systest/src/com/sun/faces/systest/model/Attic/NoneScopeBean.java
jsf-ri/systest/src/com/sun/faces/systest/model/TestBean.java
jsf-ri/systest/src/com/sun/faces/systest/resources/Attic/ResourceBundleELResolverTestCase.java
jsf-ri/systest/web/Attic/noneScopeBean.jsp
jsf-ri/systest/web/Attic/resourceBundle05.jsp
jsf-ri/systest/web/WEB-INF/faces-config.xml
jsf-ri/test/com/sun/faces/config/ConfigureListenerTestCase.java
jsf-ri/test/com/sun/faces/el/Attic/TestNestedELResolver.java
nbproject/project.xml


Ed Burns added a comment - 30/Jun/10 09:34 PM

Created an attachment (id=1189)
research for this task


Ed Burns added a comment - 01/Jul/10 07:11 AM

When trying to estimate this task, the one class that's giving me trouble is jsf-
ri/src/com/sun/faces/config/configprovider/WebResourceProvider.java. This class is not in 2.0.


Ed Burns added a comment - 01/Jul/10 07:46 AM

triage


Ed Burns added a comment - 01/Jul/10 07:55 AM

I estimate that this task will take about 17 pomodori.


Ed Burns added a comment - 01/Jul/10 10:41 AM

Target to m3


Ed Burns added a comment - 02/Jul/10 08:51 AM

Created an attachment (id=1191)
Pruned down diffs. Only contains meaningful changes


Ed Burns added a comment - 02/Jul/10 08:52 AM

There are 54 diff regions in the latest attachment. I think this equates to about a half day of work to
carefully apply them.


Ed Burns added a comment - 02/Jul/10 02:11 PM

Created an attachment (id=1192)
fix in progress, changed files


Ed Burns added a comment - 02/Jul/10 02:13 PM

Created an attachment (id=1193)
Fix in progress, new files


Ed Burns added a comment - 13/Jul/10 07:46 AM

Created an attachment (id=1198)
Fix in progress


Ed Burns added a comment - 13/Jul/10 10:14 AM

Created an attachment (id=1199)
Another snapshot, before my machine crashes.


Ed Burns added a comment - 13/Jul/10 03:05 PM

FIx checked in. Hudson successful.


Manfred Riem added a comment - 22/Mar/12 02:12 PM

Closing resolved issue out