javaserverfaces
  1. javaserverfaces
  2. JAVASERVERFACES-1727

Miltiple components in <f:facet> are not marked&swept properly

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: current
    • Fix Version/s: 2.1_gf31_m4
    • Component/s: facelets
    • Labels:
      None
    • Environment:

      Operating System: All
      Platform: All

    • Issuezilla Id:
      1,727
    • Status Whiteboard:
      Hide

      size_medium importance_large

      Show
      size_medium importance_large
    • Tags:

      Description

      ComponentSupport.markForDeletion()/finalizeForDeletion() do not descend into the
      UIPanel created to wrap multiple components inside of <f:facet>

      If you place <c:if> inside of <f:facet> with multiple components to display one
      of them conditionally, I expect that the no-longer-displayed component will not
      be removed from the UIPanel.

      1. changebundle.txt
        4 kB
        Ed Burns

        Activity

        Hide
        Jason Lee added a comment -

        r=jdlee

        Show
        Jason Lee added a comment - r=jdlee
        Hide
        Ed Burns added a comment -

        Running automated tests now.

        Show
        Ed Burns added a comment - Running automated tests now.
        Hide
        mst_70 added a comment -

        Thanks, Ed. The change totally makes sense.
        One very minor thing - I think you might have left a change in the code that was
        done for debugging purposes only:

        String id = null;
        panelGroup.setId(id = getViewRoot(ctx.getFacesContext(), parent).createUniqueId());

        The id variable is not used anywhere in the method.

        Show
        mst_70 added a comment - Thanks, Ed. The change totally makes sense. One very minor thing - I think you might have left a change in the code that was done for debugging purposes only: String id = null; panelGroup.setId(id = getViewRoot(ctx.getFacesContext(), parent).createUniqueId()); The id variable is not used anywhere in the method.
        Hide
        Ed Burns added a comment -

        Committed to HEAD and MOJARRA_2_0X_ROLLING, r8546

        Show
        Ed Burns added a comment - Committed to HEAD and MOJARRA_2_0X_ROLLING, r8546
        Hide
        Manfred Riem added a comment -

        Closing resolved issue out

        Show
        Manfred Riem added a comment - Closing resolved issue out

          People

          • Assignee:
            Ed Burns
            Reporter:
            mst_70
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: