javaserverfaces
  1. javaserverfaces
  2. JAVASERVERFACES-2064

DemuxCompositeELResolver optimization not leveraged

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.1.1
    • Fix Version/s: 2.0.next, 2.1.2, 2.2.0-m01
    • Component/s: None
    • Labels:
      None

      Description

      The DemuxCompositeELResolver optimization that was added in Mojarra 1.2.15
      was not correctly ported forward to the 2.x releases. The
      DemuxCompositeELResolver is present in 2.x. However, the corresponding
      changes in ELUtils.java are missing.

      As a result, all resolvers are added to both the root and property resolver
      chains in DemuxCompositeELResolver, thus losing any optimization.

      1. changebundle-2064.txt
        3 kB
        rogerk
      2. ELUtils.java.patch
        2 kB
        aschwart

        Activity

        Hide
        aschwart added a comment -

        Attached ELUtils.java.patch calls addRootELResolver()/addPropertyELResolver() instead of add() as appropriate.

        Show
        aschwart added a comment - Attached ELUtils.java.patch calls addRootELResolver()/addPropertyELResolver() instead of add() as appropriate.
        Hide
        aschwart added a comment -

        BTW, the attached patch is against 2_0X_ROLLING, since that happens to be the branch that I am on.

        Show
        aschwart added a comment - BTW, the attached patch is against 2_0X_ROLLING, since that happens to be the branch that I am on.
        Hide
        rogerk added a comment -

        r=rogerk

        Show
        rogerk added a comment - r=rogerk
        Hide
        rogerk added a comment -

        Changes inline with provided patch.

        Show
        rogerk added a comment - Changes inline with provided patch.
        Hide
        rogerk added a comment -

        Committed to trunk:

        Sending jsf-ri/src/main/java/com/sun/faces/el/ELUtils.java
        Transmitting file data .
        Committed revision 9107.

        Committed to MOJARRA_2_1X_ROLLING branch:

        Sending jsf-ri/src/main/java/com/sun/faces/el/ELUtils.java
        Transmitting file data .
        Committed revision 9108.

        Show
        rogerk added a comment - Committed to trunk: Sending jsf-ri/src/main/java/com/sun/faces/el/ELUtils.java Transmitting file data . Committed revision 9107. Committed to MOJARRA_2_1X_ROLLING branch: Sending jsf-ri/src/main/java/com/sun/faces/el/ELUtils.java Transmitting file data . Committed revision 9108.
        Hide
        rogerk added a comment -

        reopen to edit fix version

        Show
        rogerk added a comment - reopen to edit fix version
        Hide
        rogerk added a comment -

        fix version

        Show
        rogerk added a comment - fix version
        Hide
        rogerk added a comment -

        re-closing

        Show
        rogerk added a comment - re-closing

          People

          • Assignee:
            rogerk
            Reporter:
            aschwart
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: