Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 2.1.0
    • Fix Version/s: 2.1.2, 2.2.0-m01
    • Component/s: None
    • Labels:
      None

      Description

      This is reported against Mojarra-2.1.0.

      The tag "th" never be rendered when specifying true on the attribute "rowHeader" of h:column as the description in VDL. It seems that the TableRenderer implementation below returns false,

      boolean isRowHeader = Boolean.TRUE.equals(column.getAttributes().get("rowHeader"));

      and there is no chance to enter the following block.

      if (isRowHeader) {
      writer.startElement("th", column);
      writer.writeAttribute("scope", "row", null);
      }

      1. changebundle-2066.txt
        5 kB
        rogerk
      2. changebundle-2066.txt
        5 kB
        rogerk

        Activity

        Hide
        rogerk added a comment -

        Changes.

        Show
        rogerk added a comment - Changes.
        Hide
        rogerk added a comment -

        Revised change bundle per review from jdlee:
        On 5/20/11 3:31 PM, Jason Lee wrote:
        > On 5/20/11 2:19 PM, Roger Kitain wrote:
        >> http://java.net/jira/browse/JAVASERVERFACES-2066
        >>
        >
        > Looks mostly OK, though I think your assignment could simply be:
        >
        > isRowHeader = Boolean.valueOf(rowHeaderValue.toString());
        >
        >
        > Also not a big fan of assignments inside conditionals like that, fwiw.
        > Makes the code a bit harder to read. Other than that, it looks fine to me.
        >

        Show
        rogerk added a comment - Revised change bundle per review from jdlee: On 5/20/11 3:31 PM, Jason Lee wrote: > On 5/20/11 2:19 PM, Roger Kitain wrote: >> http://java.net/jira/browse/JAVASERVERFACES-2066 >> > > Looks mostly OK, though I think your assignment could simply be: > > isRowHeader = Boolean.valueOf(rowHeaderValue.toString()); > > > Also not a big fan of assignments inside conditionals like that, fwiw. > Makes the code a bit harder to read. Other than that, it looks fine to me. >
        Hide
        rogerk added a comment -

        Committed to trunk:
        Committed revision 9065.

        Committed to branch MOJARRA_2_1_X_ROLLING:
        Committed revision 9066.

        Show
        rogerk added a comment - Committed to trunk: Committed revision 9065. Committed to branch MOJARRA_2_1_X_ROLLING: Committed revision 9066.
        Hide
        rogerk added a comment -

        reopen to edit fix version

        Show
        rogerk added a comment - reopen to edit fix version
        Hide
        rogerk added a comment -

        fix version

        Show
        rogerk added a comment - fix version
        Hide
        rogerk added a comment -

        re-closing

        Show
        rogerk added a comment - re-closing

          People

          • Assignee:
            rogerk
            Reporter:
            xj
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: