javaserverfaces
  1. javaserverfaces
  2. JAVASERVERFACES-2109

systest-per-webapp: replace-vdl Test Fails On AIX

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: trunk
    • Fix Version/s: 2.1.8, 2.2.0-m02
    • Component/s: build
    • Labels:
      None

      Description

      ReplaceViewDeclarationLanguageTestCase.testReplaceVDL method relies on the output from produced stack trace output. The test uses a class, VDLImpl that extends ViewDeclarationLanguage and overrides the logMethodInvocation method. This logMethodInvocation method captures stack trace output:
      StackTraceElement stackTrace[] = Thread.currentThread().getStackTrace();
      and specifically expects stackTrace[2] to contain method names expected by the test (getViewMetaData, restoreView, buildView, etc...).. This works fine on non AIX machine as for example:

      [0] =

      {java.lang.StackTraceElement@356}

      "java.lang.Thread.getStackTrace(Thread.java:1503)"
      [1] =

      {java.lang.StackTraceElement@358}

      "com.sun.faces.systest.replacevdl.VDLImpl.logMethodInvocation(VDLImpl.java:69)"
      [2] =

      {java.lang.StackTraceElement@359}

      "com.sun.faces.systest.replacevdl.VDLImpl.getViewMetadata(VDLImpl.java:119)"

      However on AIX, the stacktrace arry looks like:

      [0] =

      {java.lang.StackTraceElement@1606}

      "java.lang.Thread.getStackTraceImpl(Native Method)"
      [1] =

      {java.lang.StackTraceElement@1674}

      "java.lang.Thread.getStackTrace(Thread.java:1042)"
      [2] =

      {java.lang.StackTraceElement@1824}

      "com.sun.faces.systest.replacevdl.VDLImpl.logMethodInvocation(VDLImpl.java:69)"
      [3] =

      {java.lang.StackTraceElement@1904}

      "com.sun.faces.systest.replacevdl.VDLImpl.getViewMetadata(VDLImpl.java:119)"

        Issue Links

          Activity

          Hide
          Manfred Riem added a comment -

          Moved into the new testing harness. The actual test no longer uses the stack
          elements. The logMethodInvocation method now explicitly passes in which
          methods is called.

          Show
          Manfred Riem added a comment - Moved into the new testing harness. The actual test no longer uses the stack elements. The logMethodInvocation method now explicitly passes in which methods is called.
          Hide
          Manfred Riem added a comment - - edited

          Applied to 2.1 branch,

          svn commit -m "Fixes http://java.net/jira/browse/JAVASERVERFACES-2109, r=rogerk, Moved into the new testing harness. The actual test no longer uses the stack elements."
          Sending jsf-ri\systest-per-webapp\replace-vdl\src\java\com\sun\faces\systest\replacevdl\ReplaceViewDeclarationLanguageTestCase.java
          Sending test\agnostic\vdl\facelets\pom.xml
          Adding test\agnostic\vdl\facelets\replace-vdl
          Adding test\agnostic\vdl\facelets\replace-vdl\nbactions.xml
          Adding test\agnostic\vdl\facelets\replace-vdl\pom.xml
          Adding test\agnostic\vdl\facelets\replace-vdl\src
          Adding test\agnostic\vdl\facelets\replace-vdl\src\main
          Adding test\agnostic\vdl\facelets\replace-vdl\src\main\java
          Adding test\agnostic\vdl\facelets\replace-vdl\src\main\java\com
          Adding test\agnostic\vdl\facelets\replace-vdl\src\main\java\com\sun
          Adding test\agnostic\vdl\facelets\replace-vdl\src\main\java\com\sun\faces
          Adding test\agnostic\vdl\facelets\replace-vdl\src\main\java\com\sun\faces\test
          Adding test\agnostic\vdl\facelets\replace-vdl\src\main\java\com\sun\faces\test\agnostic
          Adding test\agnostic\vdl\facelets\replace-vdl\src\main\java\com\sun\faces\test\agnostic\vdl
          Adding test\agnostic\vdl\facelets\replace-vdl\src\main\java\com\sun\faces\test\agnostic\vdl\replacevdl
          Adding test\agnostic\vdl\facelets\replace-vdl\src\main\java\com\sun\faces\test\agnostic\vdl\replacevdl\ReplaceVDLFactory.java
          Adding test\agnostic\vdl\facelets\replace-vdl\src\main\java\com\sun\faces\test\agnostic\vdl\replacevdl\ReplaceVDLImpl.java
          Adding test\agnostic\vdl\facelets\replace-vdl\src\main\resources
          Adding test\agnostic\vdl\facelets\replace-vdl\src\main\webapp
          Adding test\agnostic\vdl\facelets\replace-vdl\src\main\webapp\WEB-INF
          Adding test\agnostic\vdl\facelets\replace-vdl\src\main\webapp\WEB-INF\faces-config.xml
          Adding test\agnostic\vdl\facelets\replace-vdl\src\main\webapp\WEB-INF\glassfish-web.xml
          Adding test\agnostic\vdl\facelets\replace-vdl\src\main\webapp\WEB-INF\web.xml
          Adding test\agnostic\vdl\facelets\replace-vdl\src\main\webapp\index.xhtml
          Adding test\agnostic\vdl\facelets\replace-vdl\src\main\webapp\replacevdl.xhtml
          Adding test\agnostic\vdl\facelets\replace-vdl\src\test
          Adding test\agnostic\vdl\facelets\replace-vdl\src\test\java
          Adding test\agnostic\vdl\facelets\replace-vdl\src\test\java\com
          Adding test\agnostic\vdl\facelets\replace-vdl\src\test\java\com\sun
          Adding test\agnostic\vdl\facelets\replace-vdl\src\test\java\com\sun\faces
          Adding test\agnostic\vdl\facelets\replace-vdl\src\test\java\com\sun\faces\test
          Adding test\agnostic\vdl\facelets\replace-vdl\src\test\java\com\sun\faces\test\agnostic
          Adding test\agnostic\vdl\facelets\replace-vdl\src\test\java\com\sun\faces\test\agnostic\vdl
          Adding test\agnostic\vdl\facelets\replace-vdl\src\test\java\com\sun\faces\test\agnostic\vdl\replacevdl
          Adding test\agnostic\vdl\facelets\replace-vdl\src\test\java\com\sun\faces\test\agnostic\vdl\replacevdl\ReplaceVDLIT.java
          Transmitting file data ............
          Committed revision 9912.

          Show
          Manfred Riem added a comment - - edited Applied to 2.1 branch, svn commit -m "Fixes http://java.net/jira/browse/JAVASERVERFACES-2109 , r=rogerk, Moved into the new testing harness. The actual test no longer uses the stack elements." Sending jsf-ri\systest-per-webapp\replace-vdl\src\java\com\sun\faces\systest\replacevdl\ReplaceViewDeclarationLanguageTestCase.java Sending test\agnostic\vdl\facelets\pom.xml Adding test\agnostic\vdl\facelets\replace-vdl Adding test\agnostic\vdl\facelets\replace-vdl\nbactions.xml Adding test\agnostic\vdl\facelets\replace-vdl\pom.xml Adding test\agnostic\vdl\facelets\replace-vdl\src Adding test\agnostic\vdl\facelets\replace-vdl\src\main Adding test\agnostic\vdl\facelets\replace-vdl\src\main\java Adding test\agnostic\vdl\facelets\replace-vdl\src\main\java\com Adding test\agnostic\vdl\facelets\replace-vdl\src\main\java\com\sun Adding test\agnostic\vdl\facelets\replace-vdl\src\main\java\com\sun\faces Adding test\agnostic\vdl\facelets\replace-vdl\src\main\java\com\sun\faces\test Adding test\agnostic\vdl\facelets\replace-vdl\src\main\java\com\sun\faces\test\agnostic Adding test\agnostic\vdl\facelets\replace-vdl\src\main\java\com\sun\faces\test\agnostic\vdl Adding test\agnostic\vdl\facelets\replace-vdl\src\main\java\com\sun\faces\test\agnostic\vdl\replacevdl Adding test\agnostic\vdl\facelets\replace-vdl\src\main\java\com\sun\faces\test\agnostic\vdl\replacevdl\ReplaceVDLFactory.java Adding test\agnostic\vdl\facelets\replace-vdl\src\main\java\com\sun\faces\test\agnostic\vdl\replacevdl\ReplaceVDLImpl.java Adding test\agnostic\vdl\facelets\replace-vdl\src\main\resources Adding test\agnostic\vdl\facelets\replace-vdl\src\main\webapp Adding test\agnostic\vdl\facelets\replace-vdl\src\main\webapp\WEB-INF Adding test\agnostic\vdl\facelets\replace-vdl\src\main\webapp\WEB-INF\faces-config.xml Adding test\agnostic\vdl\facelets\replace-vdl\src\main\webapp\WEB-INF\glassfish-web.xml Adding test\agnostic\vdl\facelets\replace-vdl\src\main\webapp\WEB-INF\web.xml Adding test\agnostic\vdl\facelets\replace-vdl\src\main\webapp\index.xhtml Adding test\agnostic\vdl\facelets\replace-vdl\src\main\webapp\replacevdl.xhtml Adding test\agnostic\vdl\facelets\replace-vdl\src\test Adding test\agnostic\vdl\facelets\replace-vdl\src\test\java Adding test\agnostic\vdl\facelets\replace-vdl\src\test\java\com Adding test\agnostic\vdl\facelets\replace-vdl\src\test\java\com\sun Adding test\agnostic\vdl\facelets\replace-vdl\src\test\java\com\sun\faces Adding test\agnostic\vdl\facelets\replace-vdl\src\test\java\com\sun\faces\test Adding test\agnostic\vdl\facelets\replace-vdl\src\test\java\com\sun\faces\test\agnostic Adding test\agnostic\vdl\facelets\replace-vdl\src\test\java\com\sun\faces\test\agnostic\vdl Adding test\agnostic\vdl\facelets\replace-vdl\src\test\java\com\sun\faces\test\agnostic\vdl\replacevdl Adding test\agnostic\vdl\facelets\replace-vdl\src\test\java\com\sun\faces\test\agnostic\vdl\replacevdl\ReplaceVDLIT.java Transmitting file data ............ Committed revision 9912.
          Hide
          Manfred Riem added a comment -

          Applied to trunk (2.2),

          svn commit -m "Fixes http://java.net/jira/browse/JAVASERVERFACES-2109, r=rogerk, Moved into the new testing harness. The actual test no longer uses the stack elements."
          Sending jsf-ri\systest-per-webapp\replace-vdl\src\java\com\sun\faces\systest\replacevdl\ReplaceViewDeclarationLanguageTestCase.java
          Adding test\agnostic\vdl
          Adding test\agnostic\vdl\facelets
          Adding test\agnostic\vdl\facelets\replace-vdl
          Adding test\agnostic\vdl\facelets\replace-vdl\nbactions.xml
          Adding test\agnostic\vdl\facelets\replace-vdl\pom.xml
          Adding test\agnostic\vdl\facelets\replace-vdl\src
          Adding test\agnostic\vdl\facelets\replace-vdl\src\main
          Adding test\agnostic\vdl\facelets\replace-vdl\src\main\java
          Adding test\agnostic\vdl\facelets\replace-vdl\src\main\java\com
          Adding test\agnostic\vdl\facelets\replace-vdl\src\main\java\com\sun
          Adding test\agnostic\vdl\facelets\replace-vdl\src\main\java\com\sun\faces
          Adding test\agnostic\vdl\facelets\replace-vdl\src\main\java\com\sun\faces\test
          Adding test\agnostic\vdl\facelets\replace-vdl\src\main\java\com\sun\faces\test\agnostic
          Adding test\agnostic\vdl\facelets\replace-vdl\src\main\java\com\sun\faces\test\agnostic\vdl
          Adding test\agnostic\vdl\facelets\replace-vdl\src\main\java\com\sun\faces\test\agnostic\vdl\replacevdl
          Adding test\agnostic\vdl\facelets\replace-vdl\src\main\java\com\sun\faces\test\agnostic\vdl\replacevdl\ReplaceVDLFactory.java
          Adding test\agnostic\vdl\facelets\replace-vdl\src\main\java\com\sun\faces\test\agnostic\vdl\replacevdl\ReplaceVDLImpl.java
          Adding test\agnostic\vdl\facelets\replace-vdl\src\main\webapp
          Adding test\agnostic\vdl\facelets\replace-vdl\src\main\webapp\WEB-INF
          Adding test\agnostic\vdl\facelets\replace-vdl\src\main\webapp\WEB-INF\faces-config.xml
          Adding test\agnostic\vdl\facelets\replace-vdl\src\main\webapp\WEB-INF\glassfish-web.xml
          Adding test\agnostic\vdl\facelets\replace-vdl\src\main\webapp\WEB-INF\web.xml
          Adding test\agnostic\vdl\facelets\replace-vdl\src\main\webapp\index.xhtml
          Adding test\agnostic\vdl\facelets\replace-vdl\src\main\webapp\replacevdl.xhtml
          Adding test\agnostic\vdl\facelets\replace-vdl\src\test
          Adding test\agnostic\vdl\facelets\replace-vdl\src\test\java
          Adding test\agnostic\vdl\facelets\replace-vdl\src\test\java\com
          Adding test\agnostic\vdl\facelets\replace-vdl\src\test\java\com\sun
          Adding test\agnostic\vdl\facelets\replace-vdl\src\test\java\com\sun\faces
          Adding test\agnostic\vdl\facelets\replace-vdl\src\test\java\com\sun\faces\test
          Adding test\agnostic\vdl\facelets\replace-vdl\src\test\java\com\sun\faces\test\agnostic
          Adding test\agnostic\vdl\facelets\replace-vdl\src\test\java\com\sun\faces\test\agnostic\vdl
          Adding test\agnostic\vdl\facelets\replace-vdl\src\test\java\com\sun\faces\test\agnostic\vdl\replacevdl
          Adding test\agnostic\vdl\facelets\replace-vdl\src\test\java\com\sun\faces\test\agnostic\vdl\replacevdl\ReplaceVDLIT.java
          Transmitting file data ...........
          Committed revision 9920.

          Show
          Manfred Riem added a comment - Applied to trunk (2.2), svn commit -m "Fixes http://java.net/jira/browse/JAVASERVERFACES-2109 , r=rogerk, Moved into the new testing harness. The actual test no longer uses the stack elements." Sending jsf-ri\systest-per-webapp\replace-vdl\src\java\com\sun\faces\systest\replacevdl\ReplaceViewDeclarationLanguageTestCase.java Adding test\agnostic\vdl Adding test\agnostic\vdl\facelets Adding test\agnostic\vdl\facelets\replace-vdl Adding test\agnostic\vdl\facelets\replace-vdl\nbactions.xml Adding test\agnostic\vdl\facelets\replace-vdl\pom.xml Adding test\agnostic\vdl\facelets\replace-vdl\src Adding test\agnostic\vdl\facelets\replace-vdl\src\main Adding test\agnostic\vdl\facelets\replace-vdl\src\main\java Adding test\agnostic\vdl\facelets\replace-vdl\src\main\java\com Adding test\agnostic\vdl\facelets\replace-vdl\src\main\java\com\sun Adding test\agnostic\vdl\facelets\replace-vdl\src\main\java\com\sun\faces Adding test\agnostic\vdl\facelets\replace-vdl\src\main\java\com\sun\faces\test Adding test\agnostic\vdl\facelets\replace-vdl\src\main\java\com\sun\faces\test\agnostic Adding test\agnostic\vdl\facelets\replace-vdl\src\main\java\com\sun\faces\test\agnostic\vdl Adding test\agnostic\vdl\facelets\replace-vdl\src\main\java\com\sun\faces\test\agnostic\vdl\replacevdl Adding test\agnostic\vdl\facelets\replace-vdl\src\main\java\com\sun\faces\test\agnostic\vdl\replacevdl\ReplaceVDLFactory.java Adding test\agnostic\vdl\facelets\replace-vdl\src\main\java\com\sun\faces\test\agnostic\vdl\replacevdl\ReplaceVDLImpl.java Adding test\agnostic\vdl\facelets\replace-vdl\src\main\webapp Adding test\agnostic\vdl\facelets\replace-vdl\src\main\webapp\WEB-INF Adding test\agnostic\vdl\facelets\replace-vdl\src\main\webapp\WEB-INF\faces-config.xml Adding test\agnostic\vdl\facelets\replace-vdl\src\main\webapp\WEB-INF\glassfish-web.xml Adding test\agnostic\vdl\facelets\replace-vdl\src\main\webapp\WEB-INF\web.xml Adding test\agnostic\vdl\facelets\replace-vdl\src\main\webapp\index.xhtml Adding test\agnostic\vdl\facelets\replace-vdl\src\main\webapp\replacevdl.xhtml Adding test\agnostic\vdl\facelets\replace-vdl\src\test Adding test\agnostic\vdl\facelets\replace-vdl\src\test\java Adding test\agnostic\vdl\facelets\replace-vdl\src\test\java\com Adding test\agnostic\vdl\facelets\replace-vdl\src\test\java\com\sun Adding test\agnostic\vdl\facelets\replace-vdl\src\test\java\com\sun\faces Adding test\agnostic\vdl\facelets\replace-vdl\src\test\java\com\sun\faces\test Adding test\agnostic\vdl\facelets\replace-vdl\src\test\java\com\sun\faces\test\agnostic Adding test\agnostic\vdl\facelets\replace-vdl\src\test\java\com\sun\faces\test\agnostic\vdl Adding test\agnostic\vdl\facelets\replace-vdl\src\test\java\com\sun\faces\test\agnostic\vdl\replacevdl Adding test\agnostic\vdl\facelets\replace-vdl\src\test\java\com\sun\faces\test\agnostic\vdl\replacevdl\ReplaceVDLIT.java Transmitting file data ........... Committed revision 9920.

            People

            • Assignee:
              Ed Burns
              Reporter:
              rogerk
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: