Details

    • Type: New Feature New Feature
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.2.0-m06
    • Component/s: None
    • Labels:
      None

      Description

      Implement JAVASERVERFACES_SPEC_PUBLIC-1087. Though this annotation is in the flow package, it does not need to use any of the existing flow machinery. However, it is probably advisable to take the code from FlowCDIContext and its helpers as an guide.

        Issue Links

          Activity

          Ed Burns created issue -
          Hide
          arjan tijms added a comment -

          JAVASERVERFACES_SPEC_PUBLIC-1034 may be related to this.

          Show
          arjan tijms added a comment - JAVASERVERFACES_SPEC_PUBLIC-1034 may be related to this.
          Ed Burns made changes -
          Field Original Value New Value
          Link This issue depends on JAVASERVERFACES_SPEC_PUBLIC-898 [ JAVASERVERFACES_SPEC_PUBLIC-898 ]
          Ed Burns made changes -
          Ed Burns made changes -
          Assignee Ed Burns [ edburns ]
          Ed Burns made changes -
          Ed Burns logged work - 28/Sep/12 4:13 AM
          • Time Spent:
            6 hours
             
            Implement @ViewScoped on top of CDI

            SECTION: Modified Files
            ----------------------------
            M jsf-api/src/main/java/javax/faces/flow/ViewScoped.java

              * <p class="changed_added_2_2">When this annotation, along with {@code
              * javax.inject.Named} is found on a class, the runtime must place the
            + * bean in a CDI scope such that it remains active as long as
            + * {@link javax.faces.application.NavigationHandler#handleNavigation}
            + * does not cause a navigation to a view with a viewId that is different
            + * than the viewId of the current view. Any injections and notifications required
            + * by CDI and the Java EE platform must occur as usual at the expected time.</p>
            + *
            + * <div class="changed_added_2_2">
            + *
            + * <p>Use of this annotation requires that any beans stored in view scope
            + * must be serializable and proxyable as defined in the CDI specification.
            + * </p>
            + *
            + *
            + * </div>
             

            A + jsf-ri/src/main/java/com/sun/faces/flow/ViewScopedCDIExtension.java
            A + jsf-ri/src/main/java/com/sun/faces/flow/ViewScopedCDIContext.java
            M jsf-ri/conf/share/javax.enterprise.inject.spi.Extension

            - Add ViewScopedCDIExtension

            M jsf-ri/src/main/java/com/sun/faces/application/NavigationHandlerImpl.java

            - Clear the view scope at the right time

            M test/agnostic/renderKit/passthrough/src/test/java/com/sun/faces/test/agnostic/renderKit/passthrough/Issue1111IT.java

            - Remove unused import

            M test/web-profile/flow/basic/src/main/java/com/sun/faces/test/webprofile/flow/basic/FlowBean.java

            - Remove ctor

            M test/web-profile/flow/pom.xml
            M nbproject/project.xml
            M jsf-demo/sandbox/scrumtoys2009/eclipseProject/src/main/java/jsf2/demo/scrum/web/controller/SkinManager.java
            M jsf-demo/sandbox/scrumtoys2009/eclipseProject/src/main/java/jsf2/demo/scrum/web/controller/ProjectManager.java
            M jsf-demo/sandbox/scrumtoys2009/eclipseProject/src/main/java/jsf2/demo/scrum/web/controller/ProjectList.java
            M jsf-demo/sandbox/scrumtoys2009/eclipseProject/src/main/java/jsf2/demo/scrum/web/controller/SprintManager.java
            M jsf-demo/sandbox/scrumtoys2009/eclipseProject/src/main/java/jsf2/demo/scrum/web/controller/SprintList.java
            M jsf-demo/sandbox/scrumtoys2009/eclipseProject/src/main/java/jsf2/demo/scrum/web/controller/StoryManager.java
            M jsf-demo/sandbox/scrumtoys2009/eclipseProject/src/main/java/jsf2/demo/scrum/web/controller/StoryList.java
            M jsf-demo/sandbox/scrumtoys2009/eclipseProject/src/main/java/jsf2/demo/scrum/web/controller/SkinValuesManager.java
            M jsf-demo/sandbox/scrumtoys2009/eclipseProject/src/main/java/jsf2/demo/scrum/web/controller/DashboardManager.java
            M jsf-demo/sandbox/scrumtoys2009/eclipseProject/src/main/java/jsf2/demo/scrum/web/controller/SkinUrlManager.java
            M jsf-demo/sandbox/scrumtoys2009/eclipseProject/src/main/java/jsf2/demo/scrum/web/controller/AuthManager.java
            M jsf-demo/sandbox/scrumtoys2009/eclipseProject/src/main/java/jsf2/demo/scrum/web/controller/TaskManager.java
            M jsf-demo/sandbox/scrumtoys2009/eclipseProject/src/main/java/jsf2/demo/scrum/web/controller/AbstractManager.java
            M jsf-demo/sandbox/scrumtoys2009/eclipseProject/src/main/java/jsf2/demo/scrum/web/controller/TaskList.java
            M jsf-demo/sandbox/scrumtoys2009/eclipseProject/pom.xml


            A test/web-profile/flow/viewScoped
            A test/web-profile/flow/viewScoped/nbactions.xml
            A test/web-profile/flow/viewScoped/src
            A test/web-profile/flow/viewScoped/src/test
            A test/web-profile/flow/viewScoped/src/test/java
            A test/web-profile/flow/viewScoped/src/test/java/com
            A test/web-profile/flow/viewScoped/src/test/java/com/sun
            A test/web-profile/flow/viewScoped/src/test/java/com/sun/faces
            A test/web-profile/flow/viewScoped/src/test/java/com/sun/faces/test
            A test/web-profile/flow/viewScoped/src/test/java/com/sun/faces/test/webprofile
            A test/web-profile/flow/viewScoped/src/test/java/com/sun/faces/test/webprofile/flow
            A test/web-profile/flow/viewScoped/src/test/java/com/sun/faces/test/webprofile/flow/viewScoped
            A test/web-profile/flow/viewScoped/src/test/java/com/sun/faces/test/webprofile/flow/viewScoped/Issue1034IT.java
            A test/web-profile/flow/viewScoped/src/main
            A test/web-profile/flow/viewScoped/src/main/java
            A test/web-profile/flow/viewScoped/src/main/java/com
            A test/web-profile/flow/viewScoped/src/main/java/com/sun
            A test/web-profile/flow/viewScoped/src/main/java/com/sun/faces
            A test/web-profile/flow/viewScoped/src/main/java/com/sun/faces/test
            A test/web-profile/flow/viewScoped/src/main/java/com/sun/faces/test/webprofile
            A test/web-profile/flow/viewScoped/src/main/java/com/sun/faces/test/webprofile/flow
            A test/web-profile/flow/viewScoped/src/main/java/com/sun/faces/test/webprofile/flow/viewScoped
            A test/web-profile/flow/viewScoped/src/main/java/com/sun/faces/test/webprofile/flow/viewScoped/ViewScopedBean.java
            A test/web-profile/flow/viewScoped/src/main/resources
            A test/web-profile/flow/viewScoped/src/main/resources/META-INF
            A test/web-profile/flow/viewScoped/src/main/resources/META-INF/persistence.xml
            A test/web-profile/flow/viewScoped/src/main/webapp
            A test/web-profile/flow/viewScoped/src/main/webapp/index.xhtml
            A test/web-profile/flow/viewScoped/src/main/webapp/WEB-INF
            A test/web-profile/flow/viewScoped/src/main/webapp/WEB-INF/beans.xml
            A test/web-profile/flow/viewScoped/src/main/webapp/WEB-INF/web.xml
            A test/web-profile/flow/viewScoped/src/main/webapp/otherPage.xhtml
            A test/web-profile/flow/viewScoped/pom.xml
            Sending jsf-api/src/main/java/javax/faces/flow/ViewScoped.java
            Sending jsf-ri/conf/share/javax.enterprise.inject.spi.Extension
            Sending jsf-ri/src/main/java/com/sun/faces/application/NavigationHandlerImpl.java
            Adding jsf-ri/src/main/java/com/sun/faces/flow/ViewScopedCDIContext.java
            Adding jsf-ri/src/main/java/com/sun/faces/flow/ViewScopedCDIExtension.java
            Sending test/agnostic/renderKit/passthrough/src/test/java/com/sun/faces/test/agnostic/renderKit/passthrough/Issue1111IT.java
            Sending test/web-profile/flow/basic/src/main/java/com/sun/faces/test/webprofile/flow/basic/FlowBean.java
            Sending test/web-profile/flow/pom.xml
            Adding test/web-profile/flow/viewScoped
            Adding test/web-profile/flow/viewScoped/nbactions.xml
            Adding test/web-profile/flow/viewScoped/pom.xml
            Adding test/web-profile/flow/viewScoped/src
            Adding test/web-profile/flow/viewScoped/src/main
            Adding test/web-profile/flow/viewScoped/src/main/java
            Adding test/web-profile/flow/viewScoped/src/main/java/com
            Adding test/web-profile/flow/viewScoped/src/main/java/com/sun
            Adding test/web-profile/flow/viewScoped/src/main/java/com/sun/faces
            Adding test/web-profile/flow/viewScoped/src/main/java/com/sun/faces/test
            Adding test/web-profile/flow/viewScoped/src/main/java/com/sun/faces/test/webprofile
            Adding test/web-profile/flow/viewScoped/src/main/java/com/sun/faces/test/webprofile/flow
            Adding test/web-profile/flow/viewScoped/src/main/java/com/sun/faces/test/webprofile/flow/viewScoped
            Adding test/web-profile/flow/viewScoped/src/main/java/com/sun/faces/test/webprofile/flow/viewScoped/ViewScopedBean.java
            Adding test/web-profile/flow/viewScoped/src/main/resources
            Adding test/web-profile/flow/viewScoped/src/main/resources/META-INF
            Adding test/web-profile/flow/viewScoped/src/main/resources/META-INF/persistence.xml
            Adding test/web-profile/flow/viewScoped/src/main/webapp
            Adding test/web-profile/flow/viewScoped/src/main/webapp/WEB-INF
            Adding test/web-profile/flow/viewScoped/src/main/webapp/WEB-INF/beans.xml
            Adding test/web-profile/flow/viewScoped/src/main/webapp/WEB-INF/web.xml
            Adding test/web-profile/flow/viewScoped/src/main/webapp/index.xhtml
            Adding test/web-profile/flow/viewScoped/src/main/webapp/otherPage.xhtml
            Adding test/web-profile/flow/viewScoped/src/test
            Adding test/web-profile/flow/viewScoped/src/test/java
            Adding test/web-profile/flow/viewScoped/src/test/java/com
            Adding test/web-profile/flow/viewScoped/src/test/java/com/sun
            Adding test/web-profile/flow/viewScoped/src/test/java/com/sun/faces
            Adding test/web-profile/flow/viewScoped/src/test/java/com/sun/faces/test
            Adding test/web-profile/flow/viewScoped/src/test/java/com/sun/faces/test/webprofile
            Adding test/web-profile/flow/viewScoped/src/test/java/com/sun/faces/test/webprofile/flow
            Adding test/web-profile/flow/viewScoped/src/test/java/com/sun/faces/test/webprofile/flow/viewScoped
            Adding test/web-profile/flow/viewScoped/src/test/java/com/sun/faces/test/webprofile/flow/viewScoped/Issue1034IT.java
            Transmitting file data .................
            Committed revision 10753.
          Ed Burns made changes -
          Remaining Estimate 4 days [ 345600 ] 3 days, 18 hours [ 324000 ]
          Time Spent 6 hours [ 21600 ]
          Ed Burns made changes -
          Status Open [ 1 ] Closed [ 6 ]
          Fix Version/s 2.2-m06 [ 15885 ]
          Resolution Fixed [ 1 ]
          Hide
          Ed Burns added a comment -

          Failing serialization.

          Show
          Ed Burns added a comment - Failing serialization.
          Ed Burns made changes -
          Resolution Fixed [ 1 ]
          Status Closed [ 6 ] Reopened [ 4 ]
          Ed Burns logged work - 28/Sep/12 5:23 PM
          • Time Spent:
            1 hour, 20 minutes
             
            SECTION: Modified Files
            ----------------------------
            M jsf-ri/src/main/java/com/sun/faces/config/ConfigureListener.java
            M jsf-ri/src/main/java/com/sun/faces/flow/ViewScopedCDIContext.java
            M test/web-profile/flow/viewScoped/nbactions.xml
            M test/web-profile/flow/viewScoped/src/test/java/com/sun/faces/test/webprofile/flow/viewScoped/Issue1034IT.java

            - Tested with all tests on 8 permutations on Mac OS X and Solaris 10
              x64. All passed.
            Sending jsf-ri/src/main/java/com/sun/faces/config/ConfigureListener.java
            Sending jsf-ri/src/main/java/com/sun/faces/flow/ViewScopedCDIContext.java
            Sending test/web-profile/flow/viewScoped/nbactions.xml
            Sending test/web-profile/flow/viewScoped/src/test/java/com/sun/faces/test/webprofile/flow/viewScoped/Issue1034IT.java
            Transmitting file data ....
            Committed revision 10761.
          Ed Burns made changes -
          Remaining Estimate 3 days, 18 hours [ 324000 ] 3 days, 16 hours, 40 minutes [ 319200 ]
          Time Spent 6 hours [ 21600 ] 7 hours, 20 minutes [ 26400 ]
          Ed Burns made changes -
          Status Reopened [ 4 ] Closed [ 6 ]
          Resolution Fixed [ 1 ]

            People

            • Assignee:
              Ed Burns
              Reporter:
              Ed Burns
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Time Tracking

                Estimated:
                Original Estimate - 4 days
                4d
                Remaining:
                Time Spent - 7 hours, 20 minutes Remaining Estimate - 3 days, 16 hours, 40 minutes
                3d 16h 40m
                Logged:
                Time Spent - 7 hours, 20 minutes Remaining Estimate - 3 days, 16 hours, 40 minutes
                7h 20m