javaserverfaces
  1. javaserverfaces
  2. JAVASERVERFACES-2575

After updating to version 2.1.14 Mojarra stopped returning my doctype, making browsers show my pages in quirks mode

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Critical Critical
    • Resolution: Fixed
    • Affects Version/s: 2.1.14
    • Fix Version/s: 2.1.17
    • Component/s: None
    • Labels:
      None

      Description

      The layout template we uses.

      In the result (when running under v2.1.14 the first line (the doctype) is simply missing.

      <!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.01//EN" "http://www.w3.org/TR/html4/strict.dtd">
      <html xmlns="http://www.w3.org/1999/xhtml"
      	xmlns:h="http://java.sun.com/jsf/html"
      	xmlns:f="http://java.sun.com/jsf/core"
      	xmlns:ui="http://java.sun.com/jsf/facelets">
      <ui:insert name="metadata" />
      <h:head>
      	<f:facet name="first">
      		<title>
      			<ui:insert name="windowTitle">Bla</ui:insert>
      		</title>
      		<link href="#{request.contextPath}/javax.faces.resource/reset.css.xhtml?ln=css" rel="stylesheet" type="text/css"></link>
      	</f:facet>
      	<f:facet name="middle">
      		<link href="#{request.contextPath}/javax.faces.resource/basic.css.xhtml?ln=css" rel="stylesheet" type="text/css"></link>
      	</f:facet>
      	<h:outputScript library="primefaces" name="jquery/jquery.js" />
      	<link rel="shortcut icon" type="image/vnd.microsoft.icon" href="#{request.contextPath}/images/favicon.ico" />
      	<ui:insert name="header" />
      </h:head>
      <h:body>
      	<ui:insert name="menu" />
      	<ui:insert name="tabs" />
      	<div id="content">
      		<ui:insert name="content"/>
      	</div>
      </h:body>
      </html>
      

        Issue Links

          Activity

          Show
          Ed Burns added a comment - - edited Safe to forward port to trunk when CLEAN: < http://tim-vm9.us.oracle.com:7070/hudson/view/Mojarra%202.1.x/job/2_1_x-test-glassfish-3_1_2_2-development-pss-client/16/ > and its siblings and CLEAN: < http://hudson-sca.us.oracle.com/view/MOJARRA_ALL/job/MOJARRA_2_1X_ROLLING_DEPLOY/23/ > are clear.
          Show
          Ed Burns added a comment - Safe to mark closed when < http://tim-vm9.us.oracle.com:7070/hudson/view/Mojarra%20Trunk/job/trunk-test-glassfish-3_1_2_2-development-pss-client/8/ > and siblings and < http://hudson-sca.us.oracle.com/view/MOJARRA_ALL/job/MOJARRA_TRUNK_GLASSFISH_3_1_2_2_NO_CLUSTER/83/ > are clean.
          Hide
          Toskan added a comment -

          the problem I was facing (all versions 2.1.14 - 2.1.16) was actually this one here. I think one can argue that it is a good idea to remove 2.1.14 - 2.1.16 from the stable releases web page, as it seems 2.1.13 was the last unaffected version. I think everbody coming after me would be thankful, or they stay on the web page and just consume everybody's time.

          Show
          Toskan added a comment - the problem I was facing (all versions 2.1.14 - 2.1.16) was actually this one here. I think one can argue that it is a good idea to remove 2.1.14 - 2.1.16 from the stable releases web page, as it seems 2.1.13 was the last unaffected version. I think everbody coming after me would be thankful, or they stay on the web page and just consume everybody's time.
          Hide
          chris_dezide added a comment -

          Hi,

          With the new 2.1.17 release being out, I noticed that this issue was not mentioned. It seems that it is missing a fix version? - I'll take it that it is included in the actual release?


          Chris

          Show
          chris_dezide added a comment - Hi, With the new 2.1.17 release being out, I noticed that this issue was not mentioned. It seems that it is missing a fix version? - I'll take it that it is included in the actual release? – Chris
          Hide
          fabmars added a comment -

          I just upgraded GFv3 to JSF 2.1.17 and I confirm it's fixed there!
          I guess Ed needs to reopen the issue to make the fix version. Damn administration.

          Show
          fabmars added a comment - I just upgraded GFv3 to JSF 2.1.17 and I confirm it's fixed there! I guess Ed needs to reopen the issue to make the fix version. Damn administration.

            People

            • Assignee:
              Ed Burns
              Reporter:
              chris_dezide
            • Votes:
              6 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Time Tracking

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 4 hours, 49 minutes
                4h 49m