javaserverfaces
  1. javaserverfaces
  2. JAVASERVERFACES-2716

StateContext$AddRemoveListener.handleAdd() a walks twice over the facets map entries

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Trivial Trivial
    • Resolution: Fixed
    • Affects Version/s: 2.2.0-m08
    • Fix Version/s: 2.1.18, 2.2.0-m09
    • Component/s: None
    • Labels:
      None

      Description

      In line 416 the following statement causes a walk over the map entries:

      if (component.getParent().getFacets().containsValue(component)) {

      If that is true a second walk over the map entries is needed to find the Entry.getKey() for the facet component.

      The attached changebundle makes a proposal to walk the entries only once. Its just a very small improvement - I think.

        Activity

        Hide
        Manfred Riem added a comment -

        Applied to 2.1 branch,

        svn commit -m "Fixes http://java.net/jira/browse/JAVASERVERFACES-2716, r=mriem, StateContext$AddRemoveListener.handleAdd() walks twice over the facets map entries, patch supplied by Hanspeter. Thanks!"
        Sending jsf-ri\src\main\java\com\sun\faces\context\StateContext.java
        Transmitting file data .
        Committed revision 11490.

        Show
        Manfred Riem added a comment - Applied to 2.1 branch, svn commit -m "Fixes http://java.net/jira/browse/JAVASERVERFACES-2716 , r=mriem, StateContext$AddRemoveListener.handleAdd() walks twice over the facets map entries, patch supplied by Hanspeter. Thanks!" Sending jsf-ri\src\main\java\com\sun\faces\context\StateContext.java Transmitting file data . Committed revision 11490.
        Hide
        Manfred Riem added a comment -

        Applied to 2.2 trunk,

        svn commit -m "Fixes http://java.net/jira/browse/JAVASERVERFACES-2716, r=mriem, StateContext$AddRemoveListener.handleAdd() walks twice over the facets map entries, patch supplied by Hanspeter. Thanks!"
        Sending jsf-ri\src\main\java\com\sun\faces\context\StateContext.java
        Transmitting file data .
        Committed revision 11491.

        Show
        Manfred Riem added a comment - Applied to 2.2 trunk, svn commit -m "Fixes http://java.net/jira/browse/JAVASERVERFACES-2716 , r=mriem, StateContext$AddRemoveListener.handleAdd() walks twice over the facets map entries, patch supplied by Hanspeter. Thanks!" Sending jsf-ri\src\main\java\com\sun\faces\context\StateContext.java Transmitting file data . Committed revision 11491.

          People

          • Assignee:
            Manfred Riem
            Reporter:
            Hanspeter Duennenberger
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: