javaserverfaces
  1. javaserverfaces
  2. JAVASERVERFACES-2997

None flow command actions navigation failed when entered a flow

    Details

    • Type: Task Task
    • Status: Closed
    • Priority: Trivial Trivial
    • Resolution: Fixed
    • Affects Version/s: 2.2.2
    • Fix Version/s: 2.2.3
    • Component/s: flow
    • Labels:
      None
    • Environment:

      Glassfish 4.0 and Mojarra 2.2.2

      Description

      The code is hosted on my github.com.

      https://github.com/hantsy/ee7-sandbox

      In the jsf/flow, there is a registration flow definition...when enter the registraion flow, the none flow actions,

      <h:commandButton id="home" value="home" action="/index" immediate="true"/><h:commandButton id="userList" value="User List" action="/users" immediate="true" />

      They did not work as I expected.

      If this is also "WORK AS DESIGNED", it is terrible in the real projects. All none flow action links will become blind links when a flow is activated.

        Issue Links

          Activity

          Show
          Ed Burns added a comment - Safe to close when < http://hudson-sca.us.oracle.com/view/MOJARRA_ALL/job/MOJARRA_2_2X_ROLLING_GLASSFISH_3_1_2_2_NO_CLUSTER/170/ >, < http://slc03qna.us.oracle.com:7070/hudson/view/Mojarra%202.2/job/2_2_x-gf-3_1_2_2-no-cluster/205/ >, < http://slc03qna.us.oracle.com:7070/hudson/view/Mojarra%202.2/job/2_2_x-gf-3_1_2_2/234/ >, and < http://slc03qna.us.oracle.com:7070/hudson/view/Mojarra%202.2/job/2_2_x-gf-4_0/443/ > are clean.
          Hide
          Ed Burns added a comment -

          All tests passed. Closing.

          Show
          Ed Burns added a comment - All tests passed. Closing.
          Hide
          Ed Burns added a comment -

          Found one additional wrinkle when updating scrumtoys with this very useful bug fix: we should never push the abandoned flow.

          SECTION: Modified Files
          ----------------------------
          M jsf-ri/src/main/java/com/sun/faces/flow/FlowHandlerImpl.java

          • Don't push the abandoned flow

          M test/javaee7/cdi/initDestroy/src/test/java/com/sun/faces/test/javaee7/cdi/initDestroy/Issue2997IT.java

          • Assert correctness
            Sending jsf-ri/src/main/java/com/sun/faces/flow/FlowHandlerImpl.java
            Sending test/javaee7/cdi/initDestroy/src/test/java/com/sun/faces/test/javaee7/cdi/initDestroy/Issue2997IT.java
            Transmitting file data ..
            Committed revision 12443.
          Show
          Ed Burns added a comment - Found one additional wrinkle when updating scrumtoys with this very useful bug fix: we should never push the abandoned flow. SECTION: Modified Files ---------------------------- M jsf-ri/src/main/java/com/sun/faces/flow/FlowHandlerImpl.java Don't push the abandoned flow M test/javaee7/cdi/initDestroy/src/test/java/com/sun/faces/test/javaee7/cdi/initDestroy/Issue2997IT.java Assert correctness Sending jsf-ri/src/main/java/com/sun/faces/flow/FlowHandlerImpl.java Sending test/javaee7/cdi/initDestroy/src/test/java/com/sun/faces/test/javaee7/cdi/initDestroy/Issue2997IT.java Transmitting file data .. Committed revision 12443.
          Hide
          hantsy added a comment -

          Where I can find the example to demo my problem is fixed exactly...

          I will apply it in my example when 2.3 is released.

          I found the example for this issue in 2_2ROLLING branch used a implicit flow.

          In fact, I have more questions about leaving a flow.

          1. how to leave a flow temporarily(the flow is still active in backgroud) or permanently(the flow is terminated)?

          2. how to join a existed flow...imagine there is a scene, there are some steps are done(for example 3 steps done in a 4 steps flow) in a flow, and user leaves the flow to browse some other content, but when he is back, how to continue his step, and not start a new flow?

          Hantsy

          Show
          hantsy added a comment - Where I can find the example to demo my problem is fixed exactly... I will apply it in my example when 2.3 is released. I found the example for this issue in 2_2ROLLING branch used a implicit flow. In fact, I have more questions about leaving a flow. 1. how to leave a flow temporarily(the flow is still active in backgroud) or permanently(the flow is terminated)? 2. how to join a existed flow...imagine there is a scene, there are some steps are done(for example 3 steps done in a 4 steps flow) in a flow, and user leaves the flow to browse some other content, but when he is back, how to continue his step, and not start a new flow? Hantsy
          Hide
          Ed Burns added a comment -

          At this point, I have no choice but to observe that you are using the issue tracker as a mailing list. We have a mailing list for that purpose. I did you the favor of forwarding your request there.

          https://java.net/projects/javaserverfaces/lists/users/archive/2013-08/message/4

          I replied as well.

          Show
          Ed Burns added a comment - At this point, I have no choice but to observe that you are using the issue tracker as a mailing list. We have a mailing list for that purpose. I did you the favor of forwarding your request there. https://java.net/projects/javaserverfaces/lists/users/archive/2013-08/message/4 I replied as well.

            People

            • Assignee:
              Ed Burns
              Reporter:
              hantsy
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Time Tracking

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 2 hours, 49 minutes
                2h 49m