javaserverfaces
  1. javaserverfaces
  2. JAVASERVERFACES-3156

ClassCastException when custom VisitContextFactory is used

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 2.2.5
    • Fix Version/s: 2.2.6
    • Component/s: ajax
    • Labels:
      None
    • Environment:

      2.2.6-SNAPSHOT

      Description

      The fix incosporated in JAVASERVERFACES-3151 allows to use custom VisitContextFactory for PartialViewContext processing,

      however it also incorrectly casts created instance of javax.faces.component.visit to com.sun.faces.component.visit.PartialVisitContext.

      I have created a patch that fixes this issue:
      https://github.com/lfryc/mojarra/commit/1717fbcd89c9d9cb40588b8673c6fc5bfe2a7760

        Activity

        Hide
        Manfred Riem added a comment -

        Lukas, can you send the diff to issues@javaserverfaces.java.net? Thanks!

        Show
        Manfred Riem added a comment - Lukas, can you send the diff to issues@javaserverfaces.java.net? Thanks!
        Hide
        lfryc added a comment -

        Sure, I have sent the patch to issues@javaserverfaces.java.net.

        Show
        lfryc added a comment - Sure, I have sent the patch to issues@javaserverfaces.java.net.
        Hide
        Manfred Riem added a comment -

        Applied to 2.2 branch,

        svn commit -m "Fixes https://java.net/jira/browse/JAVASERVERFACES-3156, r=mriem, make sure the VisitContext gets unwrapped when using a PartialVisitContext that is wrapped. Thanks Lukas."
        Sending jsf-ri/src/main/java/com/sun/faces/context/PartialViewContextImpl.java
        Transmitting file data .
        Committed revision 12802.

        Show
        Manfred Riem added a comment - Applied to 2.2 branch, svn commit -m "Fixes https://java.net/jira/browse/JAVASERVERFACES-3156 , r=mriem, make sure the VisitContext gets unwrapped when using a PartialVisitContext that is wrapped. Thanks Lukas." Sending jsf-ri/src/main/java/com/sun/faces/context/PartialViewContextImpl.java Transmitting file data . Committed revision 12802.

          People

          • Assignee:
            Manfred Riem
            Reporter:
            lfryc
          • Votes:
            2 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: