javaserverfaces
  1. javaserverfaces
  2. JAVASERVERFACES-3785

Implement JAVASERVERFACES_SPEC_PUBLIC-1103 UIRepeat and UIData supports iterable

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.3.0-m02, 2.3.0
    • Component/s: renderkit
    • Labels:
      None

      Description

      Please handle the new testcase and implementation changes in this issue.

        Issue Links

          Activity

          Hide
          Ed Burns added a comment -

          Regarding the changebundle posted by Arjan on 2015-02-18.

          A test/servlet40/facelets

          I don't think this test should be called "facelets". This should be in test/servlet40/component/dataRepeat. Or, if Manfred's preference for flatter directory hierarchies is observed, test/servlet40/dataRepeat.

          Other than that, r=edburns.

          Show
          Ed Burns added a comment - Regarding the changebundle posted by Arjan on 2015-02-18. A test/servlet40/facelets I don't think this test should be called "facelets". This should be in test/servlet40/component/dataRepeat. Or, if Manfred's preference for flatter directory hierarchies is observed, test/servlet40/dataRepeat. Other than that, r=edburns.
          Hide
          arjan tijms added a comment -

          The test/servlet40/facelets directory was chosen based on the very similar test that tests for the support of UIData's Collection in test/servlet30/facelets/src/main/webapp/dataTableCollection.xhtml.

          I personally don't have a strong preference either way.

          Show
          arjan tijms added a comment - The test/servlet40/facelets directory was chosen based on the very similar test that tests for the support of UIData's Collection in test/servlet30/facelets/src/main/webapp/dataTableCollection.xhtml . I personally don't have a strong preference either way.
          Hide
          Manfred Riem added a comment -

          Applied to 2.3 trunk,

          svn commit -m "Fixes https://java.net/jira/browse/JAVASERVERFACES-3785, Implement JAVASERVERFACES_SPEC_PUBLIC-1103 UIRepeat and UIData supports iterable"
          Sending jsf-api/src/main/java/javax/faces/component/UIData.java
          Adding jsf-api/src/main/java/javax/faces/model/IterableDataModel.java
          Sending jsf-ri/src/main/java/com/sun/faces/facelets/component/UIRepeat.java
          Adding test/servlet40/facelets
          Adding test/servlet40/facelets/pom.xml
          Adding test/servlet40/facelets/src
          Adding test/servlet40/facelets/src/main
          Adding test/servlet40/facelets/src/main/java
          Adding test/servlet40/facelets/src/main/java/com
          Adding test/servlet40/facelets/src/main/java/com/sun
          Adding test/servlet40/facelets/src/main/java/com/sun/faces
          Adding test/servlet40/facelets/src/main/java/com/sun/faces/test
          Adding test/servlet40/facelets/src/main/java/com/sun/faces/test/servlet40
          Adding test/servlet40/facelets/src/main/java/com/sun/faces/test/servlet40/facelets
          Adding test/servlet40/facelets/src/main/java/com/sun/faces/test/servlet40/facelets/CollectionBean.java
          Adding test/servlet40/facelets/src/main/java/com/sun/faces/test/servlet40/facelets/IterableBean.java
          Adding test/servlet40/facelets/src/main/webapp
          Adding test/servlet40/facelets/src/main/webapp/WEB-INF
          Adding test/servlet40/facelets/src/main/webapp/WEB-INF/glassfish-web.xml
          Adding test/servlet40/facelets/src/main/webapp/WEB-INF/web.xml
          Adding test/servlet40/facelets/src/main/webapp/datatableIterable.xhtml
          Adding test/servlet40/facelets/src/main/webapp/uirepeatCollection.xhtml
          Adding test/servlet40/facelets/src/main/webapp/uirepeatIterable.xhtml
          Adding test/servlet40/facelets/src/test
          Adding test/servlet40/facelets/src/test/java
          Adding test/servlet40/facelets/src/test/java/com
          Adding test/servlet40/facelets/src/test/java/com/sun
          Adding test/servlet40/facelets/src/test/java/com/sun/faces
          Adding test/servlet40/facelets/src/test/java/com/sun/faces/test
          Adding test/servlet40/facelets/src/test/java/com/sun/faces/test/servlet40
          Adding test/servlet40/facelets/src/test/java/com/sun/faces/test/servlet40/facelets
          Adding test/servlet40/facelets/src/test/java/com/sun/faces/test/servlet40/facelets/Spec1103IT.java
          Sending test/servlet40/pom.xml
          Transmitting file data .............
          Committed revision 14463.

          Show
          Manfred Riem added a comment - Applied to 2.3 trunk, svn commit -m "Fixes https://java.net/jira/browse/JAVASERVERFACES-3785 , Implement JAVASERVERFACES_SPEC_PUBLIC-1103 UIRepeat and UIData supports iterable" Sending jsf-api/src/main/java/javax/faces/component/UIData.java Adding jsf-api/src/main/java/javax/faces/model/IterableDataModel.java Sending jsf-ri/src/main/java/com/sun/faces/facelets/component/UIRepeat.java Adding test/servlet40/facelets Adding test/servlet40/facelets/pom.xml Adding test/servlet40/facelets/src Adding test/servlet40/facelets/src/main Adding test/servlet40/facelets/src/main/java Adding test/servlet40/facelets/src/main/java/com Adding test/servlet40/facelets/src/main/java/com/sun Adding test/servlet40/facelets/src/main/java/com/sun/faces Adding test/servlet40/facelets/src/main/java/com/sun/faces/test Adding test/servlet40/facelets/src/main/java/com/sun/faces/test/servlet40 Adding test/servlet40/facelets/src/main/java/com/sun/faces/test/servlet40/facelets Adding test/servlet40/facelets/src/main/java/com/sun/faces/test/servlet40/facelets/CollectionBean.java Adding test/servlet40/facelets/src/main/java/com/sun/faces/test/servlet40/facelets/IterableBean.java Adding test/servlet40/facelets/src/main/webapp Adding test/servlet40/facelets/src/main/webapp/WEB-INF Adding test/servlet40/facelets/src/main/webapp/WEB-INF/glassfish-web.xml Adding test/servlet40/facelets/src/main/webapp/WEB-INF/web.xml Adding test/servlet40/facelets/src/main/webapp/datatableIterable.xhtml Adding test/servlet40/facelets/src/main/webapp/uirepeatCollection.xhtml Adding test/servlet40/facelets/src/main/webapp/uirepeatIterable.xhtml Adding test/servlet40/facelets/src/test Adding test/servlet40/facelets/src/test/java Adding test/servlet40/facelets/src/test/java/com Adding test/servlet40/facelets/src/test/java/com/sun Adding test/servlet40/facelets/src/test/java/com/sun/faces Adding test/servlet40/facelets/src/test/java/com/sun/faces/test Adding test/servlet40/facelets/src/test/java/com/sun/faces/test/servlet40 Adding test/servlet40/facelets/src/test/java/com/sun/faces/test/servlet40/facelets Adding test/servlet40/facelets/src/test/java/com/sun/faces/test/servlet40/facelets/Spec1103IT.java Sending test/servlet40/pom.xml Transmitting file data ............. Committed revision 14463.

            People

            • Assignee:
              Manfred Riem
              Reporter:
              Ed Burns
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: