javaserverfaces
  1. javaserverfaces
  2. JAVASERVERFACES-632

Server-side state saving sensitive to model changes

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: current
    • Fix Version/s: 1.2_05-b04
    • Component/s: None
    • Labels:
      None
    • Environment:

      Operating System: All
      Platform: All

    • Issuezilla Id:
      632

      Description

      Server-side state saving stores the state hierarchy from the component tree as
      is which means that any model changes may effect the state stored in the session.

      When using client-side state saving, this isn't the case since the state is
      serialized.

      Server-side state saving should have parity with client-side, so by default we
      should probably start serializing the state before storing it in the session.

      Additionally, add an option to disable the serialization.

        Issue Links

          Activity

          Hide
          Ryan Lubke added a comment -

          Adding Mike to the CC list since he brought this issue to my attention.

          Show
          Ryan Lubke added a comment - Adding Mike to the CC list since he brought this issue to my attention.
          Hide
          Ryan Lubke added a comment -

          Created an attachment (id=540)
          Proposed Changes (version 1)

          Show
          Ryan Lubke added a comment - Created an attachment (id=540) Proposed Changes (version 1)
          Hide
          youngm added a comment -

          r=youngm and the test jars you sent work for my test cases.

          Though I wonder if we should solicit some more opinions regarding if this should
          be on by default or not? I see the importance of matching client state saving
          functionality but it could be a rather substantial performance impact for a
          fairly irregular situation? Thoughts?

          Show
          youngm added a comment - r=youngm and the test jars you sent work for my test cases. Though I wonder if we should solicit some more opinions regarding if this should be on by default or not? I see the importance of matching client state saving functionality but it could be a rather substantial performance impact for a fairly irregular situation? Thoughts?
          Hide
          Ryan Lubke added a comment -

          Fix checked in with one difference from the attached change bundle. Server-side
          state serialization is disabled by default - per community vote.

          Show
          Ryan Lubke added a comment - Fix checked in with one difference from the attached change bundle. Server-side state serialization is disabled by default - per community vote.
          Hide
          Manfred Riem added a comment -

          Closing issue out

          Show
          Manfred Riem added a comment - Closing issue out

            People

            • Assignee:
              Ryan Lubke
              Reporter:
              Ryan Lubke
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: