javaserverfaces
  1. javaserverfaces
  2. JAVASERVERFACES-98

Redundant comparison to null in two instances of jsf-impl

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.1
    • Fix Version/s: 1.0
    • Component/s: None
    • Labels:
      None
    • Environment:

      Operating System: All
      Platform: All

    • Issuezilla Id:
      98

      Description

      There are two instances in the implementation where there is an incorrect comparison to null where
      either both of the values compared are definitely null, or one of the values is definitely not null and one
      is definitely null:

      Case 1:

      com.sun.faces.renderkit.html_basic.MessagesRenderer.encodeEnd(javax.faces.context.FacesContext,jav
      ax.faces.component.UIComponent)
      In class com.sun.faces.renderkit.html_basic.MessagesRenderer
      In method
      com.sun.faces.renderkit.html_basic.MessagesRenderer.encodeEnd(javax.faces.context.FacesContext,jav
      ax.faces.component.UIComponent)
      At MessagesRenderer.java:[line 91]

      Case 2:

      Redundant comparison to null in com.sun.faces.taglib.jsf_core.ViewTag.doAfterBody()
      In class com.sun.faces.taglib.jsf_core.ViewTag
      In method com.sun.faces.taglib.jsf_core.ViewTag.doAfterBody()
      At ViewTag.java:[line 168]

        Activity

        Hide
        Ryan Lubke added a comment -

        Fixed for 1.2

        Show
        Ryan Lubke added a comment - Fixed for 1.2
        Hide
        Manfred Riem added a comment -

        Closing issue out

        Show
        Manfred Riem added a comment - Closing issue out

          People

          • Assignee:
            javaserverfowner
            Reporter:
            rajprem
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: