javaserverfaces-spec-public
  1. javaserverfaces-spec-public
  2. JAVASERVERFACES_SPEC_PUBLIC-1092

Exception silently swallowed: exception within method referenced by methodExpression.

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 1.2, 2.0, 2.1
    • Fix Version/s: 2.2 Sprint 12
    • Component/s: EL
    • Labels:
      None

      Description

      Exceptions are being incorrectly swallowed in at least two cases.

      Case MethodExpressionValueChangeListener.processValueChange():

      The spec for that method ends with, "If that fails for any reason, throw an AbortProcessingException, including the cause of the failure." This is incorrect. The method referenced by the MethodExpression needs to be able to signal that no further processing should occur just as any other implementation of ValueChangeListener.processValueChange() would.

      Case MethodExpressionActionListener.processAction():

      This method has same problem as processValueChange().

        Issue Links

          Activity

          Hide
          Ed Burns added a comment -

          The fix for this will be to simply remove that last sentence from both cases.

          Show
          Ed Burns added a comment - The fix for this will be to simply remove that last sentence from both cases.
          Hide
          aschwart added a comment -

          Thanks for logging this Ed. Just wanted to provide a pointer to this old issue:

          http://java.net/jira/browse/JAVASERVERFACES_SPEC_PUBLIC-659

          Which seems to cover the same ground. (Meant to include this in my email yesterday.)

          Show
          aschwart added a comment - Thanks for logging this Ed. Just wanted to provide a pointer to this old issue: http://java.net/jira/browse/JAVASERVERFACES_SPEC_PUBLIC-659 Which seems to cover the same ground. (Meant to include this in my email yesterday.)
          Hide
          Ed Burns added a comment -

          Fix committed to trunk in javadoc and framemaker. Still need to apply the change as mentioned in JAVASERVERFACES-2397.

          Show
          Ed Burns added a comment - Fix committed to trunk in javadoc and framemaker. Still need to apply the change as mentioned in JAVASERVERFACES-2397 .
          Hide
          Manfred Riem added a comment -

          Closing resolved issue out

          Show
          Manfred Riem added a comment - Closing resolved issue out

            People

            • Assignee:
              Ed Burns
              Reporter:
              Ed Burns
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Time Tracking

                Estimated:
                Original Estimate - 1 day
                1d
                Remaining:
                Time Spent - 1 hour, 15 minutes Remaining Estimate - 22 hours, 45 minutes
                22h 45m
                Logged:
                Time Spent - 1 hour, 15 minutes Remaining Estimate - 22 hours, 45 minutes
                1h 15m