Details

    • Type: Sub-task Sub-task
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: Components/Renderers
    • Labels:
      None
    1. 20120706-1842-i_spec_1111.patch
      36 kB
      Ed Burns
    2. 20120706-2248-i_spec_1111.patch
      188 kB
      Ed Burns
    3. 20120709-1625-i_spec_1111.patch
      206 kB
      Ed Burns
    4. 20120710-0105-i_spec_1111.patch
      212 kB
      Ed Burns
    5. 20120710-1123-i_spec_1111.patch
      211 kB
      Ed Burns
    6. 20120710-1853-i_spec_1111.patch
      251 kB
      Ed Burns
    7. 20120913-1810-i_spec_1111.patch
      10 kB
      Ed Burns

      Issue Links

        Activity

        Hide
        Ed Burns added a comment -

        M jsf-ri/src/main/java/com/sun/faces/facelets/tag/composite/BehaviorHolderWrapper.java

        • Remove getPassThroughAttributes(), it's available on the parent. Andy
          was it safe to do this? I think so, but I could use your oversight.

        M jsf-api/src/main/java/javax/faces/component/UIComponent.java
        M jsf-api/src/main/java/javax/faces/component/UIComponentBase.java

        • Per Andy Schwartz's recommendation, remove
          UIComponentBase.getPassThroughAttributes(), moving it to the
          superclass and making it final.
          Sending jsf-api/src/main/java/javax/faces/component/UIComponent.java
          Sending jsf-api/src/main/java/javax/faces/component/UIComponentBase.java
          Sending jsf-ri/src/main/java/com/sun/faces/facelets/tag/composite/BehaviorHolderWrapper.java
          Transmitting file data ...
          Committed revision 11667.
        Show
        Ed Burns added a comment - M jsf-ri/src/main/java/com/sun/faces/facelets/tag/composite/BehaviorHolderWrapper.java Remove getPassThroughAttributes(), it's available on the parent. Andy was it safe to do this? I think so, but I could use your oversight. M jsf-api/src/main/java/javax/faces/component/UIComponent.java M jsf-api/src/main/java/javax/faces/component/UIComponentBase.java Per Andy Schwartz's recommendation, remove UIComponentBase.getPassThroughAttributes(), moving it to the superclass and making it final. Sending jsf-api/src/main/java/javax/faces/component/UIComponent.java Sending jsf-api/src/main/java/javax/faces/component/UIComponentBase.java Sending jsf-ri/src/main/java/com/sun/faces/facelets/tag/composite/BehaviorHolderWrapper.java Transmitting file data ... Committed revision 11667.
        Hide
        Ed Burns added a comment -

        After discussing with Frank today, I need some more work on button renderer.

        Show
        Ed Burns added a comment - After discussing with Frank today, I need some more work on button renderer.
        Hide
        Ed Burns added a comment -

        Ready for PRD

        Show
        Ed Burns added a comment - Ready for PRD
        Show
        Ed Burns added a comment - - edited Monitor DONE: < http://hudson-sca.us.oracle.com/view/MOJARRA_ALL/job/MOJARRA_TRUNK_GLASSFISH_TRUNK_MINUS_ONE_NO_CLUSTER/593/ > and DONE: < http://tim-vm9.us.oracle.com:7070/hudson/view/Trunk/job/trunk-test-glassfish-3_1_2_2/44/ > for successful completion.
        Hide
        Ed Burns added a comment -

        Snapshot. Was about to commit but now I see the test failure Manfred found when enabling matrix testing for these matrices:

        ++++++++++++++++++++SECTION: -Dwebapp.projectStage=Production -Dwebapp.stateSavingMethod=client -Dwebapp.partialStateSaving=false

        Tests run: 3, Failures: 0, Errors: 2, Skipped: 0, Time elapsed: 1.507 sec <<< FAILURE!

        ++++++++++++++++++++SECTION: -Dwebapp.projectStage=Development -Dwebapp.stateSavingMethod=client -Dwebapp.partialStateSaving=false

        Tests run: 3, Failures: 0, Errors: 2, Skipped: 0, Time elapsed: 1.507 sec <<< FAILURE!

        I wasn't seeing them before because my script was not correctly passing the matrix test parameters to the test harness.

        Now, I really have to fix this!

        Show
        Ed Burns added a comment - Snapshot. Was about to commit but now I see the test failure Manfred found when enabling matrix testing for these matrices: ++++++++++++++++++++SECTION: -Dwebapp.projectStage=Production -Dwebapp.stateSavingMethod=client -Dwebapp.partialStateSaving=false Tests run: 3, Failures: 0, Errors: 2, Skipped: 0, Time elapsed: 1.507 sec <<< FAILURE! ++++++++++++++++++++SECTION: -Dwebapp.projectStage=Development -Dwebapp.stateSavingMethod=client -Dwebapp.partialStateSaving=false Tests run: 3, Failures: 0, Errors: 2, Skipped: 0, Time elapsed: 1.507 sec <<< FAILURE! I wasn't seeing them before because my script was not correctly passing the matrix test parameters to the test harness. Now, I really have to fix this!

          People

          • Assignee:
            Ed Burns
            Reporter:
            Ed Burns
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Time Tracking

              Estimated:
              Original Estimate - 4 weeks, 2 days
              4w 2d
              Remaining:
              Time Spent - 1 day, 10 hours, 33 minutes Remaining Estimate - 4 weeks, 13 hours, 27 minutes
              4w 13h 27m
              Logged:
              Time Spent - 1 day, 10 hours, 33 minutes Remaining Estimate - 4 weeks, 13 hours, 27 minutes
              1d 10h 33m