Details

      Description

      Many of the context-param values introduced in JSF 2.0 appear in Mojarra as literal strings. This is error prone. There should be symbolic constants for every context-param in the section "Application Configuration Parameters" in the spec prose document.

        Activity

        Hide
        Ed Burns added a comment -

        While fixing this, I noticed a cut and paste error in the spec prose document.

        The normative text in the "Application Configuration Parameters" section in the spec prose document for

        javax.faces.DISABLE_FACELET_JSF_VIEWHANDLER

        has an incorrectly inserted cross reference.

        Show
        Ed Burns added a comment - While fixing this, I noticed a cut and paste error in the spec prose document. The normative text in the "Application Configuration Parameters" section in the spec prose document for javax.faces.DISABLE_FACELET_JSF_VIEWHANDLER has an incorrectly inserted cross reference.
        Hide
        Ed Burns added a comment -

        SECTION: Modified Files
        ----------------------------
        M test/agnostic/lifecycle/unserializableServerState_negative/src/test/java/com/sun/faces/test/agnostic/lifeycle/unserializableServerState_negative/Issue1127IT.java
        M test/agnostic/lifecycle/unserializableServerState_positive/src/test/java/com/sun/faces/test/agnostic/lifeycle/unserializableServerState_positive/Issue1127IT.java

        • re-enable these since I can't get them to fail locally. I'll
          re-disable them if they fail and go back to the drawing board.

        M jsf-api/src/main/java/javax/faces/application/ViewHandler.java
        M jsf-api/src/main/java/javax/faces/application/StateManager.java
        M jsf-api/src/main/java/javax/faces/convert/Converter.java

        • Add symbolic constants

        M jsf-ri/src/main/java/com/sun/faces/config/WebConfiguration.java

        • Replace literal strings with symbolic constants
          Authentication realm: <https://svn.java.net:443> Subversion Repository
          Username: edburns
          Password for 'edburns':
          Sending jsf-api/src/main/java/javax/faces/application/StateManager.java
          Sending jsf-api/src/main/java/javax/faces/application/ViewHandler.java
          Sending jsf-api/src/main/java/javax/faces/convert/Converter.java
          Sending jsf-ri/src/main/java/com/sun/faces/config/WebConfiguration.java
          Sending test/agnostic/lifecycle/unserializableServerState_negative/src/test/java/com/sun/faces/test/agnostic/lifeycle/unserializableServerState_negative/Issue1127IT.java
          Sending test/agnostic/lifecycle/unserializableServerState_positive/src/test/java/com/sun/faces/test/agnostic/lifeycle/unserializableServerState_positive/Issue1127IT.java
          Transmitting file data ......
          Committed revision 10507.
        Show
        Ed Burns added a comment - SECTION: Modified Files ---------------------------- M test/agnostic/lifecycle/unserializableServerState_negative/src/test/java/com/sun/faces/test/agnostic/lifeycle/unserializableServerState_negative/Issue1127IT.java M test/agnostic/lifecycle/unserializableServerState_positive/src/test/java/com/sun/faces/test/agnostic/lifeycle/unserializableServerState_positive/Issue1127IT.java re-enable these since I can't get them to fail locally. I'll re-disable them if they fail and go back to the drawing board. M jsf-api/src/main/java/javax/faces/application/ViewHandler.java M jsf-api/src/main/java/javax/faces/application/StateManager.java M jsf-api/src/main/java/javax/faces/convert/Converter.java Add symbolic constants M jsf-ri/src/main/java/com/sun/faces/config/WebConfiguration.java Replace literal strings with symbolic constants Authentication realm: < https://svn.java.net:443 > Subversion Repository Username: edburns Password for 'edburns': Sending jsf-api/src/main/java/javax/faces/application/StateManager.java Sending jsf-api/src/main/java/javax/faces/application/ViewHandler.java Sending jsf-api/src/main/java/javax/faces/convert/Converter.java Sending jsf-ri/src/main/java/com/sun/faces/config/WebConfiguration.java Sending test/agnostic/lifecycle/unserializableServerState_negative/src/test/java/com/sun/faces/test/agnostic/lifeycle/unserializableServerState_negative/Issue1127IT.java Sending test/agnostic/lifecycle/unserializableServerState_positive/src/test/java/com/sun/faces/test/agnostic/lifeycle/unserializableServerState_positive/Issue1127IT.java Transmitting file data ...... Committed revision 10507.

          People

          • Assignee:
            Ed Burns
            Reporter:
            Ed Burns
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Time Tracking

              Estimated:
              Original Estimate - Not Specified
              Not Specified
              Remaining:
              Remaining Estimate - 0 minutes
              0m
              Logged:
              Time Spent - 15 minutes
              15m