Details

      Description

      The Facelets and JavaScript documentation for JSF fail accessibility requirements for color contrast. Sorry I missed this before.

      I'll attach the output of the color contrast analyzer for four pages that fail: the main page for the Facelets Tag Library doc, the main page for composite components, the main page for Facelets templating, and one of the JavaScript pages (jsf). You only have to worry about the table rows that are red.

      In most cases the colored fonts need to be darker. For the JavaScript pages, it might be sufficient to make the typeface bold for the white-on-blue table headings.

      1. changebundle.txt
        25 kB
        Ed Burns
      2. file01-cc.html
        22 kB
        Ed Burns
      3. file02-facelets-ui.html
        25 kB
        Ed Burns
      4. file03-javascript.html
        15 kB
        Ed Burns
      5. file04-mainpage.html
        20 kB
        Ed Burns

        Activity

        Kim Haase created issue -
        Hide
        Kim Haase added a comment -

        Whoops, I can't attach files. I will send them in email.

        Show
        Kim Haase added a comment - Whoops, I can't attach files. I will send them in email.
        Ed Burns made changes -
        Field Original Value New Value
        Status Open [ 1 ] In Progress [ 3 ]
        Ed Burns made changes -
        Attachment file01-cc.html [ 52440 ]
        Attachment file02-facelets-ui.html [ 52441 ]
        Attachment file03-javascript.html [ 52442 ]
        Ed Burns made changes -
        Attachment file04-mainpage.html [ 52443 ]
        Hide
        Ed Burns added a comment -

        Updated to avoid A11Y violations.

        Show
        Ed Burns added a comment - Updated to avoid A11Y violations.
        Ed Burns made changes -
        Attachment javax.faces-api-2.2-SNAPSHOT-javadoc.jar [ 52444 ]
        Ed Burns made changes -
        Attachment changebundle.txt [ 52445 ]
        Ed Burns logged work - 26/Aug/13 6:22 PM
        • Time Spent:
          53 minutes
           
          See changebundle.
        Ed Burns made changes -
        Remaining Estimate 0 minutes [ 0 ]
        Time Spent 53 minutes [ 3180 ]
        Ed Burns made changes -
        Status In Progress [ 3 ] Open [ 1 ]
        Ed Burns made changes -
        Assignee Ed Burns [ edburns ] Kim Haase [ chaase3 ]
        Hide
        Ed Burns added a comment -

        Also, I attached a javadoc jar (which you can just unzip with the zip
        tool) that has the changes applied.

        Kim, I'm assigning the issue to you. Please confirm the changes achieve
        compliance and let me know. I'll commit when whe achieve compliance.

        Thanks,

        Ed

        Show
        Ed Burns added a comment - Also, I attached a javadoc jar (which you can just unzip with the zip tool) that has the changes applied. Kim, I'm assigning the issue to you. Please confirm the changes achieve compliance and let me know. I'll commit when whe achieve compliance. Thanks, Ed
        Hide
        Kim Haase added a comment -

        Thanks very much, Ed. It's all fixed except for one page:

        vdldocs/facelets/f/tld-summary.html

        On this page, the equals signs next to the red text are green (it's hard to see between the black and the red) – so the color contrast fails. You might as well make the page black-and-white like the others.

        Show
        Kim Haase added a comment - Thanks very much, Ed. It's all fixed except for one page: vdldocs/facelets/f/tld-summary.html On this page, the equals signs next to the red text are green (it's hard to see between the black and the red) – so the color contrast fails. You might as well make the page black-and-white like the others.
        Ed Burns made changes -
        Assignee Kim Haase [ chaase3 ] Ed Burns [ edburns ]
        Ed Burns made changes -
        Status Open [ 1 ] In Progress [ 3 ]
        Ed Burns made changes -
        Attachment changebundle.txt [ 52445 ]
        Ed Burns made changes -
        Attachment javax.faces-api-2.2-SNAPSHOT-javadoc.jar [ 52444 ]
        Ed Burns made changes -
        Ed Burns made changes -
        Attachment changebundle.txt [ 52462 ]
        Ed Burns logged work - 27/Aug/13 2:41 PM
        • Time Spent:
          20 minutes
           
          <No comment>
        Ed Burns made changes -
        Time Spent 53 minutes [ 3180 ] 1 hour, 13 minutes [ 4380 ]
        Ed Burns made changes -
        Assignee Ed Burns [ edburns ] Kim Haase [ chaase3 ]
        Hide
        Ed Burns added a comment -

        I've just attached another iteration, fixing the problem you mentioned. Please verify.

        Show
        Ed Burns added a comment - I've just attached another iteration, fixing the problem you mentioned. Please verify.
        Hide
        Kim Haase added a comment -

        Thanks, Ed! The fix works.

        Show
        Kim Haase added a comment - Thanks, Ed! The fix works.
        Ed Burns made changes -
        Assignee Kim Haase [ chaase3 ] Ed Burns [ edburns ]
        Ed Burns logged work - 28/Aug/13 3:22 PM
        • Time Spent:
          1 hour, 15 minutes
           
          SECTION: Modified Files
          ----------------------------
          M jsf-ri/conf/share/tlddoc-resources/stylesheet.css
          M jsf-ri/conf/share/facelets_jsf_core.tld
          M jsf-api/doc/jsdoc-template/static/default.css

          - conform to background/foreground contrast rules per A11Y guidelines
          Sending jsf-api/doc/jsdoc-template/static/default.css
          Sending jsf-ri/conf/share/facelets_jsf_core.tld
          Sending jsf-ri/conf/share/tlddoc-resources/stylesheet.css
          Transmitting file data ...
          Committed revision 12458.
        Ed Burns made changes -
        Time Spent 1 hour, 13 minutes [ 4380 ] 2 hours, 28 minutes [ 8880 ]
        Ed Burns made changes -
        Status In Progress [ 3 ] Resolved [ 5 ]
        Fix Version/s 2.3 [ 16372 ]
        Resolution Fixed [ 1 ]
        Hide
        Ed Burns added a comment -

        Kim, please mark this closed when the docs have been published.

        Show
        Ed Burns added a comment - Kim, please mark this closed when the docs have been published.
        Ed Burns made changes -
        Assignee Ed Burns [ edburns ] Kim Haase [ chaase3 ]
        Hide
        Manfred Riem added a comment -

        Closing resolved issue out

        Show
        Manfred Riem added a comment - Closing resolved issue out
        Manfred Riem made changes -
        Status Resolved [ 5 ] Closed [ 6 ]

          People

          • Assignee:
            Kim Haase
            Reporter:
            Kim Haase
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Time Tracking

              Estimated:
              Original Estimate - Not Specified
              Not Specified
              Remaining:
              Remaining Estimate - 0 minutes
              0m
              Logged:
              Time Spent - 2 hours, 28 minutes
              2h 28m