javaserverfaces-spec-public
  1. javaserverfaces-spec-public
  2. JAVASERVERFACES_SPEC_PUBLIC-1215

Add warning to javadoc of DelegatingMetaTagHandler.getTagHandlerDelegate

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Critical Critical
    • Resolution: Fixed
    • Affects Version/s: 2.0, 2.1, 2.2
    • Fix Version/s: 2.3
    • Component/s: Facelets/VDL
    • Labels:
      None

      Description

      The current spec has no javadoc for DelegatingMetaTagHandler.getTagHandlerDelegate(). [1] This issue proposes adding the following warning to the javadoc for this method.

      Code that extends from DelagatingMetaTagHandler (directly or indirectly, as through extending ComponentHandler) must take care to decorate, not replace, the TagHandlerDelegate instance returned by this method. Failure to do so may produce unexpected results.

      [1] http://docs.oracle.com/javaee/6/api/javax/faces/view/facelets/DelegatingMetaTagHandler.html#getTagHandlerDelegate%28%29

      1. changebundle.txt
        2 kB
        Manfred Riem
      2. changebundle.txt
        1 kB
        Manfred Riem

        Activity

        Ed Burns created issue -
        Ed Burns made changes -
        Field Original Value New Value
        Assignee Ed Burns [ edburns ]
        Hide
        Ed Burns added a comment -

        Set priority to baseline ahead of JSF 2.3 triage. Priorities will be assigned accurately after this exercise.

        Show
        Ed Burns added a comment - Set priority to baseline ahead of JSF 2.3 triage. Priorities will be assigned accurately after this exercise.
        Ed Burns made changes -
        Fix Version/s 2.3 [ 16372 ]
        Manfred Riem made changes -
        Priority Trivial [ 5 ] Critical [ 2 ]
        Hide
        Manfred Riem added a comment -

        Setting priority to Critical

        Show
        Manfred Riem added a comment - Setting priority to Critical
        Manfred Riem made changes -
        Attachment changebundle.txt [ 55168 ]
        Hide
        Manfred Riem added a comment -

        Applied to 2.3 trunk,

        svn commit -m "Fixes https://java.net/jira/browse/JAVASERVERFACES_SPEC_PUBLIC-1215, Add warning to javadoc of DelegatingMetaTagHandler.getTagHandlerDelegate"
        Sending jsf-api/src/main/java/javax/faces/view/facelets/DelegatingMetaTagHandler.java
        Transmitting file data .
        Committed revision 15006.

        Show
        Manfred Riem added a comment - Applied to 2.3 trunk, svn commit -m "Fixes https://java.net/jira/browse/JAVASERVERFACES_SPEC_PUBLIC-1215 , Add warning to javadoc of DelegatingMetaTagHandler.getTagHandlerDelegate" Sending jsf-api/src/main/java/javax/faces/view/facelets/DelegatingMetaTagHandler.java Transmitting file data . Committed revision 15006.
        Manfred Riem made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Assignee Manfred Riem [ mriem ]
        Fix Version/s 2.3 [ 16372 ]
        Resolution Fixed [ 1 ]
        Manfred Riem made changes -
        Attachment changebundle.txt [ 55169 ]

          People

          • Assignee:
            Manfred Riem
            Reporter:
            Ed Burns
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Time Tracking

              Estimated:
              Original Estimate - 30 minutes
              30m
              Remaining:
              Remaining Estimate - 30 minutes
              30m
              Logged:
              Time Spent - Not Specified
              Not Specified