Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.3
    • Component/s: Validation/Conversion
    • Labels:
      None

      Description

      The resource bundle for standard validation messages (see JSR-344 section 2.5.2.4) state
      javax.faces.converter.ByteConverter.BYTE=

      {2}: ''{0}'' must be a number between 0 and 255.
      and
      javax.faces.converter.ByteConverter.BYTE_detail={2}

      : ''

      {0}

      '' must be a number between 0 and 255. Example:

      {1}

      My best understanding is that that is wrong and that they should state
      ... a number between -127 and 128 ...

      (I get the first of these error messages in a facelets page when entering values outside of -127..128 for a byte, so the validation itself works as I expect it but the validation message to the user is misleading)

        Activity

        Hide
        Ed Burns added a comment -

        ttps://java.net/jira/browse/JAVASERVERFACES_SPEC_PUBLIC-1218

        SECTION: Modified Files
        ----------------------------
        M jsf-api/src/main/java/javax/faces/Messages_zh_HK.properties
        M jsf-api/src/main/java/javax/faces/Messages_es.properties
        M jsf-api/src/main/java/javax/faces/Messages_ko.properties
        M jsf-api/src/main/java/javax/faces/Messages.properties
        M jsf-api/src/main/java/javax/faces/Messages_zh_TW.properties
        M jsf-api/src/main/java/javax/faces/Messages_zh_CN.properties
        M jsf-api/src/main/java/javax/faces/Messages_en.properties
        M jsf-api/src/main/java/javax/faces/Messages_pt_BR.properties
        M jsf-api/src/main/java/javax/faces/Messages_fr.properties
        M jsf-api/src/main/java/javax/faces/Messages_de.properties
        M jsf-api/src/main/java/javax/faces/Messages_ja.properties

        • Correct values for BYTE and BYTE_detail to reflect value of
          Byte.MIN_VALUE and Byte.MAX_VALUE.
          Sending jsf-api/src/main/java/javax/faces/Messages.properties
          Sending jsf-api/src/main/java/javax/faces/Messages_de.properties
          Sending jsf-api/src/main/java/javax/faces/Messages_en.properties
          Sending jsf-api/src/main/java/javax/faces/Messages_es.properties
          Sending jsf-api/src/main/java/javax/faces/Messages_fr.properties
          Sending jsf-api/src/main/java/javax/faces/Messages_ja.properties
          Sending jsf-api/src/main/java/javax/faces/Messages_ko.properties
          Sending jsf-api/src/main/java/javax/faces/Messages_pt_BR.properties
          Sending jsf-api/src/main/java/javax/faces/Messages_zh_CN.properties
          Sending jsf-api/src/main/java/javax/faces/Messages_zh_HK.properties
          Sending jsf-api/src/main/java/javax/faces/Messages_zh_TW.properties
          Transmitting file data ...........
          Committed revision 12423.
        Show
        Ed Burns added a comment - ttps://java.net/jira/browse/JAVASERVERFACES_SPEC_PUBLIC-1218 SECTION: Modified Files ---------------------------- M jsf-api/src/main/java/javax/faces/Messages_zh_HK.properties M jsf-api/src/main/java/javax/faces/Messages_es.properties M jsf-api/src/main/java/javax/faces/Messages_ko.properties M jsf-api/src/main/java/javax/faces/Messages.properties M jsf-api/src/main/java/javax/faces/Messages_zh_TW.properties M jsf-api/src/main/java/javax/faces/Messages_zh_CN.properties M jsf-api/src/main/java/javax/faces/Messages_en.properties M jsf-api/src/main/java/javax/faces/Messages_pt_BR.properties M jsf-api/src/main/java/javax/faces/Messages_fr.properties M jsf-api/src/main/java/javax/faces/Messages_de.properties M jsf-api/src/main/java/javax/faces/Messages_ja.properties Correct values for BYTE and BYTE_detail to reflect value of Byte.MIN_VALUE and Byte.MAX_VALUE. Sending jsf-api/src/main/java/javax/faces/Messages.properties Sending jsf-api/src/main/java/javax/faces/Messages_de.properties Sending jsf-api/src/main/java/javax/faces/Messages_en.properties Sending jsf-api/src/main/java/javax/faces/Messages_es.properties Sending jsf-api/src/main/java/javax/faces/Messages_fr.properties Sending jsf-api/src/main/java/javax/faces/Messages_ja.properties Sending jsf-api/src/main/java/javax/faces/Messages_ko.properties Sending jsf-api/src/main/java/javax/faces/Messages_pt_BR.properties Sending jsf-api/src/main/java/javax/faces/Messages_zh_CN.properties Sending jsf-api/src/main/java/javax/faces/Messages_zh_HK.properties Sending jsf-api/src/main/java/javax/faces/Messages_zh_TW.properties Transmitting file data ........... Committed revision 12423.
        Hide
        Ed Burns added a comment -

        https://java.net/jira/browse/JAVASERVERFACES_SPEC_PUBLIC-1218

        M spec/frame/requestProcessingLifecycle.fm

        • Section 2.5.2.4

        Correct values for BYTE and BYTE_detail to reflect value of
        Byte.MIN_VALUE and Byte.MAX_VALUE.

        Sending spec/frame/requestProcessingLifecycle.fm
        Transmitting file data .
        Committed revision 1148.

        Show
        Ed Burns added a comment - https://java.net/jira/browse/JAVASERVERFACES_SPEC_PUBLIC-1218 M spec/frame/requestProcessingLifecycle.fm Section 2.5.2.4 Correct values for BYTE and BYTE_detail to reflect value of Byte.MIN_VALUE and Byte.MAX_VALUE. Sending spec/frame/requestProcessingLifecycle.fm Transmitting file data . Committed revision 1148.
        Hide
        Ed Burns added a comment -

        svn commit -m "Update test after updating property file" jsf-ri/systest/src/com/sun/faces/jsptest/ConverterTestCase.java
        Sending jsf-ri/systest/src/com/sun/faces/jsptest/ConverterTestCase.java
        Transmitting file data .
        Committed revision 12425.

        Show
        Ed Burns added a comment - svn commit -m "Update test after updating property file" jsf-ri/systest/src/com/sun/faces/jsptest/ConverterTestCase.java Sending jsf-ri/systest/src/com/sun/faces/jsptest/ConverterTestCase.java Transmitting file data . Committed revision 12425.
        Hide
        Ed Burns added a comment -

        Hudson failures.

        Show
        Ed Burns added a comment - Hudson failures.
        Show
        Ed Burns added a comment - Safe to close when < http://slc03qna.us.oracle.com:7070/hudson/view/Mojarra%202.2/job/2_2_x-gf-3_1_2_2-no-cluster/193/ > is clean.
        Hide
        Manfred Riem added a comment -

        Closing resolved issue out

        Show
        Manfred Riem added a comment - Closing resolved issue out

          People

          • Assignee:
            Ed Burns
            Reporter:
            AnnTea
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: