Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.2
    • Fix Version/s: 1.2
    • Component/s: Uncategorized
    • Labels:
      None
    • Environment:

      Operating System: All
      Platform: All

    • Issuezilla Id:
      198

      Description

      SelectItem no longer throws NPE if setValue(null)

      https://javaserverfaces-spec-public.dev.java.net/issues/show_bug.cgi?id=69

      However the javadocs for all four constructors still mention the NPE. One of
      these constructors, SelectItem(Object value), throws an uncaught NPE. The NPE
      should be removed from the javadocs and the constructor could be changed from

      this(value, value, null, false, true);

      to

      this(value, value == null ? null : value.toString(), null, false, true);

      See implementation issue:

      https://javaserverfaces.dev.java.net/issues/show_bug.cgi?id=345

        Activity

        Hide
        rogerk added a comment -

        Also, the javadocs for the following methods mention
        throwing a NPE (that is not applicable):

        setValue

        public SelectItem(Object value, String label, String description,
        boolean disabled, boolean escape)

        Show
        rogerk added a comment - Also, the javadocs for the following methods mention throwing a NPE (that is not applicable): setValue public SelectItem(Object value, String label, String description, boolean disabled, boolean escape)
        Hide
        rogerk added a comment -

        Changes tracked in :
        https://javaserverfaces.dev.java.net/issues/show_bug.cgi?id=345

        Changes have been committed.

        Show
        rogerk added a comment - Changes tracked in : https://javaserverfaces.dev.java.net/issues/show_bug.cgi?id=345 Changes have been committed.
        Hide
        rogerk added a comment -

        Additional javadoc changes mentioning the default value of 'true' for the 'escape'
        constructor arg if it is not specified.

        Show
        rogerk added a comment - Additional javadoc changes mentioning the default value of 'true' for the 'escape' constructor arg if it is not specified.
        Hide
        rogerk added a comment -

        Created an attachment (id=105)
        minor javadoc additions.

        Show
        rogerk added a comment - Created an attachment (id=105) minor javadoc additions.
        Hide
        Ryan Lubke added a comment -

        r=rlubke

        Show
        Ryan Lubke added a comment - r=rlubke
        Hide
        rogerk added a comment -

        checked In.

        Show
        rogerk added a comment - checked In.
        Hide
        Ed Burns added a comment -

        Prepare to delete "spec" subcomponent.

        Show
        Ed Burns added a comment - Prepare to delete "spec" subcomponent.
        Hide
        Ed Burns added a comment -

        Move all to 1.2

        Show
        Ed Burns added a comment - Move all to 1.2
        Hide
        Manfred Riem added a comment -

        Closing resolved issue out

        Show
        Manfred Riem added a comment - Closing resolved issue out

          People

          • Assignee:
            rogerk
            Reporter:
            rogerk
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: