Details

    • Issuezilla Id:
      642
    • Status Whiteboard:
      Hide

      cat1 frame changelog

      Show
      cat1 frame changelog

      Description

      IMHO, section 14.4.1 of JSF_20090506.pdf is unclear.

      1) Table 14-4 refers to responseTxt, but in my Mojarra build (Mojarra 2.0.0
      SNAPSHOT 20090924), it is responseText. Since responseText is the property in
      the standard XMLHttpRequest, I presume that was what was intended, and Table
      14-4 is in error.

      2) It is not clear to me from reading the spec that it is the "status" property
      that should be "begin", "success", or "complete". Those three conditions are
      described clearly, but to me it is far from obvious from the spec that it is the
      status property that should contain this information. I confirmed it with
      Firebug, but I don't see it in the spec. I would think "status" should be one of
      the entries in the left column of Table 14-4. For example:

      function oneventhandler(data) {
      if (data.status == "begin")

      { showSomeAnimatedGifSayingImWorking(); }

      else if (data.status == "success")

      { hideSomeAnimatedGifSayingImWorking(); }

      }

      3) Table 14-4 says that there should be a name property that refers to the
      callback handler's name, but it was not present in my implementation. It is not
      exactly obvious to me why this property would be useful, but nevertheless, Table
      14-4 says it should be there, and it isn't.

      4) I would reorder Table 14-3 so that the entries are in chronological order
      (begin, complete, success).

      5) The use case of 14.4.1.1 is incorrect.

      First, you can't call addOnEvent(statusUpdate) until after the statusUpdate
      variable exists. Even it it existed at that point, redefining it later as shown
      would have no effect because addOnEvent would have the old value.

      Second, I don't understand why it is doing
      var statusUpdate = function statusUpdate(data)

      { ... };
      instead of just
      function statusUpdate(data) { ... }

      ;
      Aren't those two forms equivalent?

      I suggest changing the use case of 14.4.1.1 to this:

      function statusUpdate(data) {
      // do something with data.status or other parts of data payload
      }
      ...
      jsf.ajax.addOnEvent(statusUpdate);

      I also think that this part of the spec should make it a bit more obvious to
      readers that
      <f:ajax ... onevent="statusUpdate" /> invokes addOnEvent.

      Cheers-

        Activity

        Hide
        Ed Burns added a comment -

        Prepare to delete "spec" subcomponent.

        Show
        Ed Burns added a comment - Prepare to delete "spec" subcomponent.
        Hide
        Ed Burns added a comment -

        cat1

        Show
        Ed Burns added a comment - cat1
        Hide
        Ed Burns added a comment -

        frame

        Show
        Ed Burns added a comment - frame
        Hide
        Ed Burns added a comment -

        https://javaserverfaces-spec-public.dev.java.net/issues/show_bug.cgi?id=698

        Include deprecation text on <redirect><view-param> element.

        https://javaserverfaces-spec-public.dev.java.net/issues/show_bug.cgi?id=744

        • integrationWithFacelets.fm

        Section 10.3.2. Correct xref to point to section in appendix that
        includes the facelet taglib schema.

        • appendixA-metadata.fm

        To ease migration for Facelet taglibraries declared using pre-JSF 2.0
        versions of Facelets, implementations must support loading facelet
        taglibrary files that conform to the pre-JSF 2.0 Facelets DTD. Per DTD
        conventions, Facelet taglibrary files declare conformance to this DTD
        by including text similar to the following in at the top of their
        declaring file.

        <!DOCTYPE facelet-taglib PUBLIC
        "-//Sun Microsystems, Inc.//DTD Facelet Taglib 1.0//EN"
        "http://java.sun.com/dtd/facelet-taglib_1_0.dtd">

        Use of this DTD is officially deprecated. This DTD is included for
        reference in Section 1.2.1 "Deprecated DTD for Facelet Taglibraries
        Used by Versions of Facelets Prior to JSF 2.0". It is expected that
        proper JSF 2.0 Facelet Taglibraries will declare conformance to the
        following schema, rather than the deprecated DTD

        https://javaserverfaces-spec-public.dev.java.net/issues/show_bug.cgi?id=588

        • jsf-api/doc/standard-html-renderkit-base.xml

        insert <p> around text for h:link and h:button

        https://javaserverfaces-spec-public.dev.java.net/issues/show_bug.cgi?id=639

        • jsf-ri/conf/share/facelets_jsf_core.tld

        change "name" to "type" on description of f:event tag

        https://javaserverfaces-spec-public.dev.java.net/issues/show_bug.cgi?id=509

        • jsf-ri/conf/share/jstl-core.taglib.xml
        • jsf-ri/conf/share/jstl-core.tld

        Declare that the old, incorrect, Facelets decaration of the uri for
        the JSTL Core taglib be honored, as well as the new, correct one.

        https://javaserverfaces-spec-public.dev.java.net/issues/show_bug.cgi?id=673

        • jsf-api/doc/standard-html-renderkit-base.xml

        Clarify what should happen if the target attribute is not specified.

        https://javaserverfaces-spec-public.dev.java.net/issues/show_bug.cgi?id=642

        • javascriptAPI.fm

        table 14.4.1, change responseTxt to responseText

        reorder rows in table 14.3

        make use case for event listeners be correct.

        https://javaserverfaces-spec-public.dev.java.net/issues/show_bug.cgi?id=635

        • userInterfaceComponentModel.fm

        3.5.3, 3.5.6.1: remove references to UInput.encodeEnd(). Not for a
        very long time has this method been used to instigate validation.

        https://javaserverfaces-spec-public.dev.java.net/issues/show_bug.cgi?id=740

        • requestProcessingLifecycle.fm
        • 2.6.1.3 Tighten spec for the localePrefix, libraryName, and
          resourceVersion segments of the resource identifier
        Show
        Ed Burns added a comment - https://javaserverfaces-spec-public.dev.java.net/issues/show_bug.cgi?id=698 Include deprecation text on <redirect><view-param> element. https://javaserverfaces-spec-public.dev.java.net/issues/show_bug.cgi?id=744 integrationWithFacelets.fm Section 10.3.2. Correct xref to point to section in appendix that includes the facelet taglib schema. appendixA-metadata.fm To ease migration for Facelet taglibraries declared using pre-JSF 2.0 versions of Facelets, implementations must support loading facelet taglibrary files that conform to the pre-JSF 2.0 Facelets DTD. Per DTD conventions, Facelet taglibrary files declare conformance to this DTD by including text similar to the following in at the top of their declaring file. <!DOCTYPE facelet-taglib PUBLIC "-//Sun Microsystems, Inc.//DTD Facelet Taglib 1.0//EN" "http://java.sun.com/dtd/facelet-taglib_1_0.dtd"> Use of this DTD is officially deprecated. This DTD is included for reference in Section 1.2.1 "Deprecated DTD for Facelet Taglibraries Used by Versions of Facelets Prior to JSF 2.0". It is expected that proper JSF 2.0 Facelet Taglibraries will declare conformance to the following schema, rather than the deprecated DTD https://javaserverfaces-spec-public.dev.java.net/issues/show_bug.cgi?id=588 jsf-api/doc/standard-html-renderkit-base.xml insert <p> around text for h:link and h:button https://javaserverfaces-spec-public.dev.java.net/issues/show_bug.cgi?id=639 jsf-ri/conf/share/facelets_jsf_core.tld change "name" to "type" on description of f:event tag https://javaserverfaces-spec-public.dev.java.net/issues/show_bug.cgi?id=509 jsf-ri/conf/share/jstl-core.taglib.xml jsf-ri/conf/share/jstl-core.tld Declare that the old, incorrect, Facelets decaration of the uri for the JSTL Core taglib be honored, as well as the new, correct one. https://javaserverfaces-spec-public.dev.java.net/issues/show_bug.cgi?id=673 jsf-api/doc/standard-html-renderkit-base.xml Clarify what should happen if the target attribute is not specified. https://javaserverfaces-spec-public.dev.java.net/issues/show_bug.cgi?id=642 javascriptAPI.fm table 14.4.1, change responseTxt to responseText reorder rows in table 14.3 make use case for event listeners be correct. https://javaserverfaces-spec-public.dev.java.net/issues/show_bug.cgi?id=635 userInterfaceComponentModel.fm 3.5.3, 3.5.6.1: remove references to UInput.encodeEnd(). Not for a very long time has this method been used to instigate validation. https://javaserverfaces-spec-public.dev.java.net/issues/show_bug.cgi?id=740 requestProcessingLifecycle.fm 2.6.1.3 Tighten spec for the localePrefix, libraryName, and resourceVersion segments of the resource identifier
        Hide
        Ed Burns added a comment -

        These are valid 2.0 Rev a issues

        Show
        Ed Burns added a comment - These are valid 2.0 Rev a issues
        Hide
        rogerk added a comment -

        changelog

        Show
        rogerk added a comment - changelog
        Hide
        Manfred Riem added a comment -

        Closing resolved issue out

        Show
        Manfred Riem added a comment - Closing resolved issue out

          People

          • Assignee:
            javaserverfowner
            Reporter:
            martyhall
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: