Details

    • Type: Bug Bug
    • Status: Open
    • Priority: Major Major
    • Resolution: Unresolved
    • Affects Version/s: 2.0
    • Fix Version/s: None
    • Component/s: Components/Renderers
    • Labels:
      None
    • Environment:

      Operating System: All
      Platform: All

    • Issuezilla Id:
      704
    • Status Whiteboard:
      Hide

      cat2 javadoc size_medium importance_large draft

      Show
      cat2 javadoc size_medium importance_large draft

      Description

      with JSF 2.0, thanks to Facelets, there is a <ui:repeat>. While I understand
      that tags/rendering behavior is part of the internals of an implementation, I am
      not really sure if the underlying/related components should be "hidden" by the
      spec as well.

      For instance: I noticed that in MyFaces the UIRepeat extends UIComponentBase and
      implements NamingContainer, while with the JSF RI / Mojarra, the UIRepeat "just"
      extends the UINamingContainer...

      ... and oh yes... I know that UINamingContainer extends UIComponentBase and
      implements NamingContainer....

      but instanceof UINamingContainer doesn't say TRUE for the MyFaces UIRepeat

      See a community related discussion here:
      http://markmail.org/message/wllfudu4ge7n5gxa

        Activity

        Hide
        Ed Burns added a comment -

        cat2

        Show
        Ed Burns added a comment - cat2
        Hide
        Ed Burns added a comment -

        javadoc

        Show
        Ed Burns added a comment - javadoc
        Hide
        Ed Burns added a comment -

        These are targeted at 2.1.

        Show
        Ed Burns added a comment - These are targeted at 2.1.
        Hide
        Ed Burns added a comment -

        rogerk

        Show
        Ed Burns added a comment - rogerk
        Hide
        rogerk added a comment -

        triage

        Show
        rogerk added a comment - triage
        Hide
        Ed Burns added a comment -

        https://glassfish.dev.java.net/issues/show_bug.cgi?id=11785

        On Mon Apr 12 15:57:00 +0000 2010, mohammadalavi MA wrote

        MA> I've found 2 bugs in jsf 1.2 here's the list
        MA>
        MA>
        MA> 1.when h:dataTable's parent is ui:repeat from facelet duplicated ids
        MA> are generated for child component because UIData's
        MA> isNestedWithinUIData method reports true
        MA> only when the parent is an instance of UIData and UIRepeat is not.
        MA> of course the problem happens because the UIData's getClientId method
        MA> caches the parent client id when isNestedWithinUIData returns false
        MA> if it never cache parent client id this problem wont happen.
        MA>
        MA> public String getClientId(FacesContext context) {
        MA> if (context == null)

        { MA> throw new NullPointerException(); MA> }

        MA> if (rowIndex >= 0)

        { MA> String cidBuilder = new StringBuilder(); MA> return cidBuilder.append(super.getClientId(context)) MA> .append(NamingContainer.SEPARATOR_CHAR).append(rowIndex) MA> .toString(); MA> }

        else

        { MA> return super.getClientId(context); MA> }

        MA> }
        MA> 2.TableMetaInfo a static inner class in BaseTableRenderer is used for
        MA> managing style for columns and rows, the getCurrentColumnClass method
        MA> doesn't work as expected it doesn't repeat the styles when number of
        MA> columns is grater than column classes it should be implemented as
        MA> follows:
        MA>
        MA> public String getCurrentColumnClass() {
        MA>
        MA> String style = null;
        MA> if (columnStyleCounter < columnClasses.length &&
        MA> columnStyleCounter < columnCount)

        { MA> style = columnClasses[columnStyleCounter++]; MA> }

        MA> if(columnStyleCounter >= columnClasses.length)

        { MA> columnStyleCounter = 0; MA> }

        MA> return ((style != null && style.length() > 0) ? style : null);

        Show
        Ed Burns added a comment - https://glassfish.dev.java.net/issues/show_bug.cgi?id=11785 On Mon Apr 12 15:57:00 +0000 2010, mohammadalavi MA wrote MA> I've found 2 bugs in jsf 1.2 here's the list MA> MA> MA> 1.when h:dataTable's parent is ui:repeat from facelet duplicated ids MA> are generated for child component because UIData's MA> isNestedWithinUIData method reports true MA> only when the parent is an instance of UIData and UIRepeat is not. MA> of course the problem happens because the UIData's getClientId method MA> caches the parent client id when isNestedWithinUIData returns false MA> if it never cache parent client id this problem wont happen. MA> MA> public String getClientId(FacesContext context) { MA> if (context == null) { MA> throw new NullPointerException(); MA> } MA> if (rowIndex >= 0) { MA> String cidBuilder = new StringBuilder(); MA> return cidBuilder.append(super.getClientId(context)) MA> .append(NamingContainer.SEPARATOR_CHAR).append(rowIndex) MA> .toString(); MA> } else { MA> return super.getClientId(context); MA> } MA> } MA> 2.TableMetaInfo a static inner class in BaseTableRenderer is used for MA> managing style for columns and rows, the getCurrentColumnClass method MA> doesn't work as expected it doesn't repeat the styles when number of MA> columns is grater than column classes it should be implemented as MA> follows: MA> MA> public String getCurrentColumnClass() { MA> MA> String style = null; MA> if (columnStyleCounter < columnClasses.length && MA> columnStyleCounter < columnCount) { MA> style = columnClasses[columnStyleCounter++]; MA> } MA> if(columnStyleCounter >= columnClasses.length) { MA> columnStyleCounter = 0; MA> } MA> return ((style != null && style.length() > 0) ? style : null);
        Hide
        rogerk added a comment -

        triage

        Show
        rogerk added a comment - triage
        Hide
        rogerk added a comment -

        triage

        Show
        rogerk added a comment - triage
        Hide
        Ed Burns added a comment -

        Set priority to baseline ahead of JSF 2.3 triage. Priorities will be assigned accurately after this exercise.

        Show
        Ed Burns added a comment - Set priority to baseline ahead of JSF 2.3 triage. Priorities will be assigned accurately after this exercise.

          People

          • Assignee:
            Unassigned
            Reporter:
            mwessendorf
          • Votes:
            1 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated: