Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 2.0
    • Fix Version/s: 2.2 Sprint 11 B
    • Component/s: Resources
    • Labels:
      None
    • Environment:

      Operating System: All
      Platform: All

    • Issuezilla Id:
      719
    • Status Whiteboard:
      Hide

      cat2 frame size_medium importance_medium

      Show
      cat2 frame size_medium importance_medium
    • Tags:

      Description

      The current JSF specification does not provide a standard plugable mechanism for
      mapping a viewId to the resource path for the resource that will render the
      view. Although the specification doesn't state that the requested viewId be
      literally the resource path of the VDL document some parts of the RI assume this
      with code similar to:

      String viewId = FacesContext.getViewRoot().getViewId();
      Object resource = externalContext.getResource(viewId);

      This breaks applications that want to have some type of indirection or mapping
      between viewIds and physical resources (e.g. viewId "/x/y/z" is rendered using
      document "/a/b/foo.jspx").

      Apache Trinidad solves this problem with a plugable interface called a
      PageResolver (see
      http://myfaces.apache.org/trinidad/trinidad-api/apidocs/index.html). This may
      server as an model for how to provide this capability in the standard.

      1. 20120307-0002-i_spec_719_snapshot.patch
        90 kB
        Ed Burns
      2. 20120309-0034-i_spec_719.patch
        36 kB
        Ed Burns
      3. changebundle.txt
        14 kB
        Ed Burns

        Issue Links

          Activity

          Hide
          dougd added a comment -

          It appears that there is a side effect with the fix on this issue.

          The code that appears to be causing the failures is below. What it looks like to me is that if toStream is not an instanceof ClientResourceInfo we just end up going off into the weeds.

          public InputStream getInputStream(ResourceInfo toStream, FacesContext ctx)
          throws IOException {

          // PENDING(edburns): this is a sub-optimal implementation choice
          // done in the interest of prototyping. It's never a good idea
          // to do a switch statement based on the type of an object.

          InputStream in = null;

          if (toStream instanceof ClientResourceInfo) {
          ClientResourceInfo resource = (ClientResourceInfo) toStream;

          in = getInputStreamFromClientInfo(resource, ctx);
          if (null == in) {
          ClientResourceInfo resourceWithoutLocalePrefix =
          new ClientResourceInfo(resource, false);
          in = getInputStreamFromClientInfo(resourceWithoutLocalePrefix, ctx);
          if (null != in)

          { resource.copy(resourceWithoutLocalePrefix); }

          }

          } else

          { // PENDING(edburns): get the input stream from the facelet ResourceInfo. <------- "Offending Code" }

          return in;

          }

          Show
          dougd added a comment - It appears that there is a side effect with the fix on this issue. The code that appears to be causing the failures is below. What it looks like to me is that if toStream is not an instanceof ClientResourceInfo we just end up going off into the weeds. public InputStream getInputStream(ResourceInfo toStream, FacesContext ctx) throws IOException { // PENDING(edburns): this is a sub-optimal implementation choice // done in the interest of prototyping. It's never a good idea // to do a switch statement based on the type of an object. InputStream in = null; if (toStream instanceof ClientResourceInfo) { ClientResourceInfo resource = (ClientResourceInfo) toStream; in = getInputStreamFromClientInfo(resource, ctx); if (null == in) { ClientResourceInfo resourceWithoutLocalePrefix = new ClientResourceInfo(resource, false); in = getInputStreamFromClientInfo(resourceWithoutLocalePrefix, ctx); if (null != in) { resource.copy(resourceWithoutLocalePrefix); } } } else { // PENDING(edburns): get the input stream from the facelet ResourceInfo. <------- "Offending Code" } return in; }
          Hide
          Ed Burns added a comment -

          http://java.net/jira/browse/JAVASERVERFACES_SPEC_PUBLIC-1085 http://java.net/jira/browse/JAVASERVERFACES_SPEC_PUBLIC-719

          SECTION: 1085 changes
          ----------------------------

          M jsf-api/src/main/java/javax/faces/context/ExternalContext.java

          • Specify support for httpOnly.

          M jsf-ri/src/main/java/com/sun/faces/context/ExternalContextImpl.java

          • implement new spec requirement.

          A test/agnostic/externalContext
          A test/agnostic/externalContext/basic
          A test/agnostic/externalContext/basic/nbactions.xml
          A test/agnostic/externalContext/basic/src
          A test/agnostic/externalContext/basic/src/test
          A test/agnostic/externalContext/basic/src/test/java
          A test/agnostic/externalContext/basic/src/test/java/com
          A test/agnostic/externalContext/basic/src/test/java/com/sun
          A test/agnostic/externalContext/basic/src/test/java/com/sun/faces
          A test/agnostic/externalContext/basic/src/test/java/com/sun/faces/test
          A test/agnostic/externalContext/basic/src/test/java/com/sun/faces/test/agnostic
          A test/agnostic/externalContext/basic/src/test/java/com/sun/faces/test/agnostic/externalContext
          A test/agnostic/externalContext/basic/src/test/java/com/sun/faces/test/agnostic/externalContext/basic
          A test/agnostic/externalContext/basic/src/test/java/com/sun/faces/test/agnostic/externalContext/basic/CookieIT.java
          A test/agnostic/externalContext/basic/src/main
          A test/agnostic/externalContext/basic/src/main/java
          A test/agnostic/externalContext/basic/src/main/java/com
          A test/agnostic/externalContext/basic/src/main/java/com/sun
          A test/agnostic/externalContext/basic/src/main/java/com/sun/faces
          A test/agnostic/externalContext/basic/src/main/java/com/sun/faces/test
          A test/agnostic/externalContext/basic/src/main/java/com/sun/faces/test/agnostic
          A test/agnostic/externalContext/basic/src/main/java/com/sun/faces/test/agnostic/externalContext
          A test/agnostic/externalContext/basic/src/main/java/com/sun/faces/test/agnostic/externalContext/basic
          A test/agnostic/externalContext/basic/src/main/java/com/sun/faces/test/agnostic/externalContext/basic/Bean.java
          A test/agnostic/externalContext/basic/src/main/resources
          A test/agnostic/externalContext/basic/src/main/resources/META-INF
          A test/agnostic/externalContext/basic/src/main/resources/META-INF/services
          A test/agnostic/externalContext/basic/src/main/webapp
          A test/agnostic/externalContext/basic/src/main/webapp/index.xhtml
          A test/agnostic/externalContext/basic/src/main/webapp/WEB-INF
          A test/agnostic/externalContext/basic/src/main/webapp/WEB-INF/beans.xml
          A test/agnostic/externalContext/basic/src/main/webapp/WEB-INF/web.xml
          A test/agnostic/externalContext/basic/pom.xml
          A test/agnostic/externalContext/pom.xml
          A test/util/src/main/java/com/sun/faces/test/util/HttpUtils.java

          • I was forced to test this using the new system because Cactus doesn't
            support the new cookie methods introduced in Servlet 3.0.

          SECTION: 719 changes
          ----------------------------

          M jsf-ri/src/main/java/com/sun/faces/application/resource/ClasspathResourceHelper.java

          • No test for this one because the TCK test has it. I plan to copy the
            intent of the TCK test, though.

          SECTION: Build changes
          ----------------------

          M jsf-ri/systest/build-tests.xml
          A test/agnostic/renderKit
          A test/agnostic/renderKit/basic
          A test/agnostic/renderKit/basic/nbactions.xml
          A test/agnostic/renderKit/basic/src
          A test/agnostic/renderKit/basic/src/test
          A test/agnostic/renderKit/basic/src/test/java
          A test/agnostic/renderKit/basic/src/test/java/com
          A test/agnostic/renderKit/basic/src/test/java/com/sun
          A test/agnostic/renderKit/basic/src/test/java/com/sun/faces
          A test/agnostic/renderKit/basic/src/test/java/com/sun/faces/test
          A test/agnostic/renderKit/basic/src/test/java/com/sun/faces/test/agnostic
          A test/agnostic/renderKit/basic/src/test/java/com/sun/faces/test/agnostic/renderKit
          A test/agnostic/renderKit/basic/src/test/java/com/sun/faces/test/agnostic/renderKit/basic
          A test/agnostic/renderKit/basic/src/test/java/com/sun/faces/test/agnostic/renderKit/basic/CustomRenderKitIT.java
          A test/agnostic/renderKit/basic/src/main
          A test/agnostic/renderKit/basic/src/main/java
          A test/agnostic/renderKit/basic/src/main/java/com
          A test/agnostic/renderKit/basic/src/main/java/com/sun
          A test/agnostic/renderKit/basic/src/main/java/com/sun/faces
          A test/agnostic/renderKit/basic/src/main/java/com/sun/faces/test
          A test/agnostic/renderKit/basic/src/main/java/com/sun/faces/test/render
          A + test/agnostic/renderKit/basic/src/main/java/com/sun/faces/test/render/ButtonRenderer.java
          A + test/agnostic/renderKit/basic/src/main/java/com/sun/faces/test/render/CustomRenderKitImpl.java
          A + test/agnostic/renderKit/basic/src/main/java/com/sun/faces/test/render/CustomResponseWriter.java
          A + test/agnostic/renderKit/basic/src/main/java/com/sun/faces/test/render/FormRenderer.java
          A + test/agnostic/renderKit/basic/src/main/java/com/sun/faces/test/render/TextRenderer.java
          A test/agnostic/renderKit/basic/src/main/webapp
          A + test/agnostic/renderKit/basic/src/main/webapp/renderkit03.jsp
          A + test/agnostic/renderKit/basic/src/main/webapp/renderkit03A.jsp
          A test/agnostic/renderKit/basic/src/main/webapp/WEB-INF
          A test/agnostic/renderKit/basic/src/main/webapp/WEB-INF/faces-config.xml
          A test/agnostic/renderKit/basic/src/main/webapp/WEB-INF/beans.xml
          A test/agnostic/renderKit/basic/src/main/webapp/WEB-INF/web.xml
          A test/agnostic/renderKit/basic/pom.xml
          A test/agnostic/renderKit/pom.xml
          D jsf-ri/systest/web/renderkit03.jsp
          D jsf-ri/systest/web/renderkit03A.jsp

          • remove troublesome test testrenderkit03, move it over to the new system.

          This reduces the test count by two on the old side, but increases it
          by one on the new side.

          M test/agnostic/pom.xml

          • add two new modules:

          + <module>externalContext</module>
          + <module>renderKit</module>

          M test/pom.xml

          • Move util to the top. Manfred said it wasn't necessary, but I observed it was.

          SECTION: 730 changes

          M jsf-api/src/main/java/javax/faces/flow/Flow.java

          • Make this serializable.

          Sending jsf-api/src/main/java/javax/faces/context/ExternalContext.java
          Sending jsf-api/src/main/java/javax/faces/flow/Flow.java
          Sending jsf-ri/build-tests.xml
          Sending jsf-ri/src/main/java/com/sun/faces/application/resource/ClasspathResourceHelper.java
          Sending jsf-ri/src/main/java/com/sun/faces/context/ExternalContextImpl.java
          Sending jsf-ri/systest/build-tests.xml
          Deleting jsf-ri/systest/web/renderkit03.jsp
          Deleting jsf-ri/systest/web/renderkit03A.jsp
          Adding test/agnostic/externalContext
          Adding test/agnostic/externalContext/basic
          Adding test/agnostic/externalContext/basic/nbactions.xml
          Adding test/agnostic/externalContext/basic/pom.xml
          Adding test/agnostic/externalContext/basic/src
          Adding test/agnostic/externalContext/basic/src/main
          Adding test/agnostic/externalContext/basic/src/main/java
          Adding test/agnostic/externalContext/basic/src/main/java/com
          Adding test/agnostic/externalContext/basic/src/main/java/com/sun
          Adding test/agnostic/externalContext/basic/src/main/java/com/sun/faces
          Adding test/agnostic/externalContext/basic/src/main/java/com/sun/faces/test
          Adding test/agnostic/externalContext/basic/src/main/java/com/sun/faces/test/agnostic
          Adding test/agnostic/externalContext/basic/src/main/java/com/sun/faces/test/agnostic/externalContext
          Adding test/agnostic/externalContext/basic/src/main/java/com/sun/faces/test/agnostic/externalContext/basic
          Adding test/agnostic/externalContext/basic/src/main/java/com/sun/faces/test/agnostic/externalContext/basic/Bean.java
          Adding test/agnostic/externalContext/basic/src/main/resources
          Adding test/agnostic/externalContext/basic/src/main/resources/META-INF
          Adding test/agnostic/externalContext/basic/src/main/resources/META-INF/services
          Adding test/agnostic/externalContext/basic/src/main/webapp
          Adding test/agnostic/externalContext/basic/src/main/webapp/WEB-INF
          Adding test/agnostic/externalContext/basic/src/main/webapp/WEB-INF/beans.xml
          Adding test/agnostic/externalContext/basic/src/main/webapp/WEB-INF/web.xml
          Adding test/agnostic/externalContext/basic/src/main/webapp/index.xhtml
          Adding test/agnostic/externalContext/basic/src/test
          Adding test/agnostic/externalContext/basic/src/test/java
          Adding test/agnostic/externalContext/basic/src/test/java/com
          Adding test/agnostic/externalContext/basic/src/test/java/com/sun
          Adding test/agnostic/externalContext/basic/src/test/java/com/sun/faces
          Adding test/agnostic/externalContext/basic/src/test/java/com/sun/faces/test
          Adding test/agnostic/externalContext/basic/src/test/java/com/sun/faces/test/agnostic
          Adding test/agnostic/externalContext/basic/src/test/java/com/sun/faces/test/agnostic/externalContext
          Adding test/agnostic/externalContext/basic/src/test/java/com/sun/faces/test/agnostic/externalContext/basic
          Adding test/agnostic/externalContext/basic/src/test/java/com/sun/faces/test/agnostic/externalContext/basic/CookieIT.java
          Adding test/agnostic/externalContext/pom.xml
          Sending test/agnostic/pom.xml
          Adding test/agnostic/renderKit
          Adding test/agnostic/renderKit/basic
          Adding test/agnostic/renderKit/basic/nbactions.xml
          Adding test/agnostic/renderKit/basic/pom.xml
          Adding test/agnostic/renderKit/basic/src
          Adding test/agnostic/renderKit/basic/src/main
          Adding test/agnostic/renderKit/basic/src/main/java
          Adding test/agnostic/renderKit/basic/src/main/java/com
          Adding test/agnostic/renderKit/basic/src/main/java/com/sun
          Adding test/agnostic/renderKit/basic/src/main/java/com/sun/faces
          Adding test/agnostic/renderKit/basic/src/main/java/com/sun/faces/test
          Adding test/agnostic/renderKit/basic/src/main/java/com/sun/faces/test/render
          Adding test/agnostic/renderKit/basic/src/main/java/com/sun/faces/test/render/ButtonRenderer.java
          Adding test/agnostic/renderKit/basic/src/main/java/com/sun/faces/test/render/CustomRenderKitImpl.java
          Adding test/agnostic/renderKit/basic/src/main/java/com/sun/faces/test/render/CustomResponseWriter.java
          Adding test/agnostic/renderKit/basic/src/main/java/com/sun/faces/test/render/FormRenderer.java
          Adding test/agnostic/renderKit/basic/src/main/java/com/sun/faces/test/render/TextRenderer.java
          Adding test/agnostic/renderKit/basic/src/main/webapp
          Adding test/agnostic/renderKit/basic/src/main/webapp/WEB-INF
          Adding test/agnostic/renderKit/basic/src/main/webapp/WEB-INF/beans.xml
          Adding test/agnostic/renderKit/basic/src/main/webapp/WEB-INF/faces-config.xml
          Adding test/agnostic/renderKit/basic/src/main/webapp/WEB-INF/web.xml
          Adding test/agnostic/renderKit/basic/src/main/webapp/renderkit03.jsp
          Adding test/agnostic/renderKit/basic/src/main/webapp/renderkit03A.jsp
          Adding test/agnostic/renderKit/basic/src/test
          Adding test/agnostic/renderKit/basic/src/test/java
          Adding test/agnostic/renderKit/basic/src/test/java/com
          Adding test/agnostic/renderKit/basic/src/test/java/com/sun
          Adding test/agnostic/renderKit/basic/src/test/java/com/sun/faces
          Adding test/agnostic/renderKit/basic/src/test/java/com/sun/faces/test
          Adding test/agnostic/renderKit/basic/src/test/java/com/sun/faces/test/agnostic
          Adding test/agnostic/renderKit/basic/src/test/java/com/sun/faces/test/agnostic/renderKit
          Adding test/agnostic/renderKit/basic/src/test/java/com/sun/faces/test/agnostic/renderKit/basic
          Adding test/agnostic/renderKit/basic/src/test/java/com/sun/faces/test/agnostic/renderKit/basic/CustomRenderKitIT.java
          Adding test/agnostic/renderKit/pom.xml
          Sending test/pom.xml
          Adding test/util/src/main/java/com/sun/faces/test/util/HttpUtils.java
          Transmitting file data .............................
          Committed revision 9794.

          Show
          Ed Burns added a comment - http://java.net/jira/browse/JAVASERVERFACES_SPEC_PUBLIC-1085 http://java.net/jira/browse/JAVASERVERFACES_SPEC_PUBLIC-719 SECTION: 1085 changes ---------------------------- M jsf-api/src/main/java/javax/faces/context/ExternalContext.java Specify support for httpOnly. M jsf-ri/src/main/java/com/sun/faces/context/ExternalContextImpl.java implement new spec requirement. A test/agnostic/externalContext A test/agnostic/externalContext/basic A test/agnostic/externalContext/basic/nbactions.xml A test/agnostic/externalContext/basic/src A test/agnostic/externalContext/basic/src/test A test/agnostic/externalContext/basic/src/test/java A test/agnostic/externalContext/basic/src/test/java/com A test/agnostic/externalContext/basic/src/test/java/com/sun A test/agnostic/externalContext/basic/src/test/java/com/sun/faces A test/agnostic/externalContext/basic/src/test/java/com/sun/faces/test A test/agnostic/externalContext/basic/src/test/java/com/sun/faces/test/agnostic A test/agnostic/externalContext/basic/src/test/java/com/sun/faces/test/agnostic/externalContext A test/agnostic/externalContext/basic/src/test/java/com/sun/faces/test/agnostic/externalContext/basic A test/agnostic/externalContext/basic/src/test/java/com/sun/faces/test/agnostic/externalContext/basic/CookieIT.java A test/agnostic/externalContext/basic/src/main A test/agnostic/externalContext/basic/src/main/java A test/agnostic/externalContext/basic/src/main/java/com A test/agnostic/externalContext/basic/src/main/java/com/sun A test/agnostic/externalContext/basic/src/main/java/com/sun/faces A test/agnostic/externalContext/basic/src/main/java/com/sun/faces/test A test/agnostic/externalContext/basic/src/main/java/com/sun/faces/test/agnostic A test/agnostic/externalContext/basic/src/main/java/com/sun/faces/test/agnostic/externalContext A test/agnostic/externalContext/basic/src/main/java/com/sun/faces/test/agnostic/externalContext/basic A test/agnostic/externalContext/basic/src/main/java/com/sun/faces/test/agnostic/externalContext/basic/Bean.java A test/agnostic/externalContext/basic/src/main/resources A test/agnostic/externalContext/basic/src/main/resources/META-INF A test/agnostic/externalContext/basic/src/main/resources/META-INF/services A test/agnostic/externalContext/basic/src/main/webapp A test/agnostic/externalContext/basic/src/main/webapp/index.xhtml A test/agnostic/externalContext/basic/src/main/webapp/WEB-INF A test/agnostic/externalContext/basic/src/main/webapp/WEB-INF/beans.xml A test/agnostic/externalContext/basic/src/main/webapp/WEB-INF/web.xml A test/agnostic/externalContext/basic/pom.xml A test/agnostic/externalContext/pom.xml A test/util/src/main/java/com/sun/faces/test/util/HttpUtils.java I was forced to test this using the new system because Cactus doesn't support the new cookie methods introduced in Servlet 3.0. SECTION: 719 changes ---------------------------- M jsf-ri/src/main/java/com/sun/faces/application/resource/ClasspathResourceHelper.java No test for this one because the TCK test has it. I plan to copy the intent of the TCK test, though. SECTION: Build changes ---------------------- M jsf-ri/systest/build-tests.xml A test/agnostic/renderKit A test/agnostic/renderKit/basic A test/agnostic/renderKit/basic/nbactions.xml A test/agnostic/renderKit/basic/src A test/agnostic/renderKit/basic/src/test A test/agnostic/renderKit/basic/src/test/java A test/agnostic/renderKit/basic/src/test/java/com A test/agnostic/renderKit/basic/src/test/java/com/sun A test/agnostic/renderKit/basic/src/test/java/com/sun/faces A test/agnostic/renderKit/basic/src/test/java/com/sun/faces/test A test/agnostic/renderKit/basic/src/test/java/com/sun/faces/test/agnostic A test/agnostic/renderKit/basic/src/test/java/com/sun/faces/test/agnostic/renderKit A test/agnostic/renderKit/basic/src/test/java/com/sun/faces/test/agnostic/renderKit/basic A test/agnostic/renderKit/basic/src/test/java/com/sun/faces/test/agnostic/renderKit/basic/CustomRenderKitIT.java A test/agnostic/renderKit/basic/src/main A test/agnostic/renderKit/basic/src/main/java A test/agnostic/renderKit/basic/src/main/java/com A test/agnostic/renderKit/basic/src/main/java/com/sun A test/agnostic/renderKit/basic/src/main/java/com/sun/faces A test/agnostic/renderKit/basic/src/main/java/com/sun/faces/test A test/agnostic/renderKit/basic/src/main/java/com/sun/faces/test/render A + test/agnostic/renderKit/basic/src/main/java/com/sun/faces/test/render/ButtonRenderer.java A + test/agnostic/renderKit/basic/src/main/java/com/sun/faces/test/render/CustomRenderKitImpl.java A + test/agnostic/renderKit/basic/src/main/java/com/sun/faces/test/render/CustomResponseWriter.java A + test/agnostic/renderKit/basic/src/main/java/com/sun/faces/test/render/FormRenderer.java A + test/agnostic/renderKit/basic/src/main/java/com/sun/faces/test/render/TextRenderer.java A test/agnostic/renderKit/basic/src/main/webapp A + test/agnostic/renderKit/basic/src/main/webapp/renderkit03.jsp A + test/agnostic/renderKit/basic/src/main/webapp/renderkit03A.jsp A test/agnostic/renderKit/basic/src/main/webapp/WEB-INF A test/agnostic/renderKit/basic/src/main/webapp/WEB-INF/faces-config.xml A test/agnostic/renderKit/basic/src/main/webapp/WEB-INF/beans.xml A test/agnostic/renderKit/basic/src/main/webapp/WEB-INF/web.xml A test/agnostic/renderKit/basic/pom.xml A test/agnostic/renderKit/pom.xml D jsf-ri/systest/web/renderkit03.jsp D jsf-ri/systest/web/renderkit03A.jsp remove troublesome test testrenderkit03, move it over to the new system. This reduces the test count by two on the old side, but increases it by one on the new side. M test/agnostic/pom.xml add two new modules: + <module>externalContext</module> + <module>renderKit</module> M test/pom.xml Move util to the top. Manfred said it wasn't necessary, but I observed it was. SECTION: 730 changes M jsf-api/src/main/java/javax/faces/flow/Flow.java Make this serializable. Sending jsf-api/src/main/java/javax/faces/context/ExternalContext.java Sending jsf-api/src/main/java/javax/faces/flow/Flow.java Sending jsf-ri/build-tests.xml Sending jsf-ri/src/main/java/com/sun/faces/application/resource/ClasspathResourceHelper.java Sending jsf-ri/src/main/java/com/sun/faces/context/ExternalContextImpl.java Sending jsf-ri/systest/build-tests.xml Deleting jsf-ri/systest/web/renderkit03.jsp Deleting jsf-ri/systest/web/renderkit03A.jsp Adding test/agnostic/externalContext Adding test/agnostic/externalContext/basic Adding test/agnostic/externalContext/basic/nbactions.xml Adding test/agnostic/externalContext/basic/pom.xml Adding test/agnostic/externalContext/basic/src Adding test/agnostic/externalContext/basic/src/main Adding test/agnostic/externalContext/basic/src/main/java Adding test/agnostic/externalContext/basic/src/main/java/com Adding test/agnostic/externalContext/basic/src/main/java/com/sun Adding test/agnostic/externalContext/basic/src/main/java/com/sun/faces Adding test/agnostic/externalContext/basic/src/main/java/com/sun/faces/test Adding test/agnostic/externalContext/basic/src/main/java/com/sun/faces/test/agnostic Adding test/agnostic/externalContext/basic/src/main/java/com/sun/faces/test/agnostic/externalContext Adding test/agnostic/externalContext/basic/src/main/java/com/sun/faces/test/agnostic/externalContext/basic Adding test/agnostic/externalContext/basic/src/main/java/com/sun/faces/test/agnostic/externalContext/basic/Bean.java Adding test/agnostic/externalContext/basic/src/main/resources Adding test/agnostic/externalContext/basic/src/main/resources/META-INF Adding test/agnostic/externalContext/basic/src/main/resources/META-INF/services Adding test/agnostic/externalContext/basic/src/main/webapp Adding test/agnostic/externalContext/basic/src/main/webapp/WEB-INF Adding test/agnostic/externalContext/basic/src/main/webapp/WEB-INF/beans.xml Adding test/agnostic/externalContext/basic/src/main/webapp/WEB-INF/web.xml Adding test/agnostic/externalContext/basic/src/main/webapp/index.xhtml Adding test/agnostic/externalContext/basic/src/test Adding test/agnostic/externalContext/basic/src/test/java Adding test/agnostic/externalContext/basic/src/test/java/com Adding test/agnostic/externalContext/basic/src/test/java/com/sun Adding test/agnostic/externalContext/basic/src/test/java/com/sun/faces Adding test/agnostic/externalContext/basic/src/test/java/com/sun/faces/test Adding test/agnostic/externalContext/basic/src/test/java/com/sun/faces/test/agnostic Adding test/agnostic/externalContext/basic/src/test/java/com/sun/faces/test/agnostic/externalContext Adding test/agnostic/externalContext/basic/src/test/java/com/sun/faces/test/agnostic/externalContext/basic Adding test/agnostic/externalContext/basic/src/test/java/com/sun/faces/test/agnostic/externalContext/basic/CookieIT.java Adding test/agnostic/externalContext/pom.xml Sending test/agnostic/pom.xml Adding test/agnostic/renderKit Adding test/agnostic/renderKit/basic Adding test/agnostic/renderKit/basic/nbactions.xml Adding test/agnostic/renderKit/basic/pom.xml Adding test/agnostic/renderKit/basic/src Adding test/agnostic/renderKit/basic/src/main Adding test/agnostic/renderKit/basic/src/main/java Adding test/agnostic/renderKit/basic/src/main/java/com Adding test/agnostic/renderKit/basic/src/main/java/com/sun Adding test/agnostic/renderKit/basic/src/main/java/com/sun/faces Adding test/agnostic/renderKit/basic/src/main/java/com/sun/faces/test Adding test/agnostic/renderKit/basic/src/main/java/com/sun/faces/test/render Adding test/agnostic/renderKit/basic/src/main/java/com/sun/faces/test/render/ButtonRenderer.java Adding test/agnostic/renderKit/basic/src/main/java/com/sun/faces/test/render/CustomRenderKitImpl.java Adding test/agnostic/renderKit/basic/src/main/java/com/sun/faces/test/render/CustomResponseWriter.java Adding test/agnostic/renderKit/basic/src/main/java/com/sun/faces/test/render/FormRenderer.java Adding test/agnostic/renderKit/basic/src/main/java/com/sun/faces/test/render/TextRenderer.java Adding test/agnostic/renderKit/basic/src/main/webapp Adding test/agnostic/renderKit/basic/src/main/webapp/WEB-INF Adding test/agnostic/renderKit/basic/src/main/webapp/WEB-INF/beans.xml Adding test/agnostic/renderKit/basic/src/main/webapp/WEB-INF/faces-config.xml Adding test/agnostic/renderKit/basic/src/main/webapp/WEB-INF/web.xml Adding test/agnostic/renderKit/basic/src/main/webapp/renderkit03.jsp Adding test/agnostic/renderKit/basic/src/main/webapp/renderkit03A.jsp Adding test/agnostic/renderKit/basic/src/test Adding test/agnostic/renderKit/basic/src/test/java Adding test/agnostic/renderKit/basic/src/test/java/com Adding test/agnostic/renderKit/basic/src/test/java/com/sun Adding test/agnostic/renderKit/basic/src/test/java/com/sun/faces Adding test/agnostic/renderKit/basic/src/test/java/com/sun/faces/test Adding test/agnostic/renderKit/basic/src/test/java/com/sun/faces/test/agnostic Adding test/agnostic/renderKit/basic/src/test/java/com/sun/faces/test/agnostic/renderKit Adding test/agnostic/renderKit/basic/src/test/java/com/sun/faces/test/agnostic/renderKit/basic Adding test/agnostic/renderKit/basic/src/test/java/com/sun/faces/test/agnostic/renderKit/basic/CustomRenderKitIT.java Adding test/agnostic/renderKit/pom.xml Sending test/pom.xml Adding test/util/src/main/java/com/sun/faces/test/util/HttpUtils.java Transmitting file data ............................. Committed revision 9794.
          Hide
          rogerk added a comment -

          This fix caused a regression. See: http://java.net/jira/browse/JAVASERVERFACES-2401

          Show
          rogerk added a comment - This fix caused a regression. See: http://java.net/jira/browse/JAVASERVERFACES-2401
          Hide
          rogerk added a comment -

          Specifically, it was trunk commit revision 9752 that caused the regression.

          Show
          rogerk added a comment - Specifically, it was trunk commit revision 9752 that caused the regression.
          Hide
          Ed Burns added a comment -

          Re-closing this because I have created JAVASERVERFACES_SPEC_PUBLIC-1141 to cover the specific case mentioned in JAVASERVERFACES-2401.

          Show
          Ed Burns added a comment - Re-closing this because I have created JAVASERVERFACES_SPEC_PUBLIC-1141 to cover the specific case mentioned in JAVASERVERFACES-2401 .

            People

            • Assignee:
              Ed Burns
              Reporter:
              daschneider
            • Votes:
              13 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Time Tracking

                Estimated:
                Original Estimate - 3 days
                3d
                Remaining:
                Remaining Estimate - 3 days
                3d
                Logged:
                Time Spent - Not Specified
                Not Specified