Details

    • Type: Sub-task Sub-task
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 2.0
    • Fix Version/s: 2.2 Sprint 8
    • Component/s: Lifecycle
    • Labels:
      None
    • Environment:

      Operating System: All
      Platform: All

    • Issuezilla Id:
      766
    • Status Whiteboard:
      Hide

      size_medium importance_large

      Show
      size_medium importance_large

      Description

      we need to be consistent w/ the way the JSF scopes are handled. We currently
      have these events:

      javax.faces.event.PostConstructViewMapEvent
      javax.faces.event.PreDestroyViewMapEvent

      javax.faces.event.PostConstructCustomScopeEvent
      javax.faces.event.PreDestroyCustomScopeEvent

      So we definitely need the following events in JSF 2.0 Rev a

      javax.faces.event.PostConstructFlashEvent
      javax.faces.event.PreDestroyFlashEvent

      Also, can we consider adding the @javax.faces.bean.FlashScoped annotation like
      (Dan) mentioned in the last EG meeting? I'm not concerned about enhancing the
      JSF bean container. We just needs a common annotation for CDI or Spring
      integration. We need a common touch point, so we avoid introducing
      @org.jboss.seam.faces.context.FlashScoped.

        Activity

        Hide
        Ed Burns added a comment -

        I agree we need this. Put to 2.1

        Show
        Ed Burns added a comment - I agree we need this. Put to 2.1
        Hide
        Ed Burns added a comment -

        triage

        Show
        Ed Burns added a comment - triage
        Hide
        Ed Burns added a comment -

        importance_large

        Show
        Ed Burns added a comment - importance_large
        Hide
        Ed Burns added a comment -

        GlassFish 3.1 M6 at the latest.

        Show
        Ed Burns added a comment - GlassFish 3.1 M6 at the latest.
        Hide
        Ed Burns added a comment -

        Move these to 2.2

        Show
        Ed Burns added a comment - Move these to 2.2
        Hide
        Ed Burns added a comment - - edited

        After discussion with the reporter on IRC, we have agreed to these names for the events

        PostPutFlashValueEvent
        PostKeepFlashValueEvent
        PreClearFlashEvent

        .

        Show
        Ed Burns added a comment - - edited After discussion with the reporter on IRC, we have agreed to these names for the events PostPutFlashValueEvent PostKeepFlashValueEvent PreClearFlashEvent .
        Hide
        lincolnbaxter added a comment -

        Ok, no need to implement the additional @FlashScoped annotation within JSF. You can drop that part of this request.

        Show
        lincolnbaxter added a comment - Ok, no need to implement the additional @FlashScoped annotation within JSF. You can drop that part of this request.
        Hide
        Ed Burns added a comment -

        Committed to trunk.

        Sending jsf-api/src/main/java/javax/faces/context/Flash.java
        Adding jsf-api/src/main/java/javax/faces/event/PostKeepFlashValueEvent.java
        Adding jsf-api/src/main/java/javax/faces/event/PostPutFlashValueEvent.java
        Adding jsf-api/src/main/java/javax/faces/event/PreClearFlashEvent.java
        Adding jsf-api/src/main/java/javax/faces/event/PreRemoveFlashValueEvent.java
        Sending jsf-ri/src/main/java/com/sun/faces/context/flash/ELFlash.java
        Adding jsf-ri/systest-per-webapp/flash/src/java/com/sun/faces/model/SessionScopedBean.java
        Sending jsf-ri/systest-per-webapp/flash/src/java/com/sun/faces/systest/FlashTestCase.java
        Adding jsf-ri/systest-per-webapp/flash/web/flash14.xhtml
        Sending jsf-ri/systest-per-webapp/flash/web/index.xhtml
        Transmitting file data ..........
        Committed revision 9437.

        Show
        Ed Burns added a comment - Committed to trunk. Sending jsf-api/src/main/java/javax/faces/context/Flash.java Adding jsf-api/src/main/java/javax/faces/event/PostKeepFlashValueEvent.java Adding jsf-api/src/main/java/javax/faces/event/PostPutFlashValueEvent.java Adding jsf-api/src/main/java/javax/faces/event/PreClearFlashEvent.java Adding jsf-api/src/main/java/javax/faces/event/PreRemoveFlashValueEvent.java Sending jsf-ri/src/main/java/com/sun/faces/context/flash/ELFlash.java Adding jsf-ri/systest-per-webapp/flash/src/java/com/sun/faces/model/SessionScopedBean.java Sending jsf-ri/systest-per-webapp/flash/src/java/com/sun/faces/systest/FlashTestCase.java Adding jsf-ri/systest-per-webapp/flash/web/flash14.xhtml Sending jsf-ri/systest-per-webapp/flash/web/index.xhtml Transmitting file data .......... Committed revision 9437.
        Hide
        Ed Burns added a comment -

        On Friday, I noticed that the newly-enhanced flash testcase failed in clustered environments. Upon investigation, I learned that it can't work in a clustered environment, as written. This commit modifies the testcase so that it does work in a clustered environment.

        Sending jsf-ri/systest-per-webapp/flash/src/java/com/sun/faces/systest/FlashTestCase.java
        Transmitting file data .
        Committed revision 9441.

        Show
        Ed Burns added a comment - On Friday, I noticed that the newly-enhanced flash testcase failed in clustered environments. Upon investigation, I learned that it can't work in a clustered environment, as written. This commit modifies the testcase so that it does work in a clustered environment. Sending jsf-ri/systest-per-webapp/flash/src/java/com/sun/faces/systest/FlashTestCase.java Transmitting file data . Committed revision 9441.
        Hide
        Manfred Riem added a comment -

        Closing resolved issue out

        Show
        Manfred Riem added a comment - Closing resolved issue out

          People

          • Assignee:
            Ed Burns
            Reporter:
            lincolnbaxter
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: