javaserverfaces-spec-public
  1. javaserverfaces-spec-public
  2. JAVASERVERFACES_SPEC_PUBLIC-79

Should UIColumn.encodeAll() be overridden due to TCCI changes ?

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Won't Fix
    • Affects Version/s: 1.2
    • Fix Version/s: 1.2
    • Component/s: Uncategorized
    • Labels:
      None
    • Environment:

      Operating System: All
      Platform: All

    • Issuezilla Id:
      79

      Description

      There is an impact on rendersChildren = false components after TCCI changes as
      we all know. Previously encodeChildren() was called only if "rendersChildren"
      was true but now we invoke it regardless. Due to this I ran into to a problem
      with our Repeater Demo which is why I am filing this isssue for clarification.

      Problem description:
      RepeaterRenderer.encodeChildren() calls super.encodeChildren() as the first
      step, which calls Renderer.encodeChildren() which in turn invokes
      UIComponent.encodeAll() on its children. This results in UIColumn's encodeAll()
      being called, which results in an extra row being rendered. (Before TCCI, this
      was not a problem because UIColumn's encodeChildren() would never be called due
      to rendersChildren being false.)

      Question: Since UIColumn is not a rendersChildren=true component, do we need to
      override encodeAll() to not recurse its children ? That way, applications like
      Repeaterdemo would function as they used to before TCCI.

      If we feel thats not needed, I can fix the Repeater Renderer not to call
      super.encodeChildren(). (Since the RepeaterRenderer takes reponsibility for
      rendering its children, this call shouldn't be necessary.)

      Thanks
      -Jayashri

        Activity

        Hide
        rogerk added a comment -

        Didn't get a response from the EG - so leaving things as they are.

        Show
        rogerk added a comment - Didn't get a response from the EG - so leaving things as they are.
        Hide
        rogerk added a comment -

        closed.

        Show
        rogerk added a comment - closed.
        Hide
        Ed Burns added a comment -

        Prepare to delete api subcomponent

        Show
        Ed Burns added a comment - Prepare to delete api subcomponent
        Hide
        Ed Burns added a comment -

        Move all to 1.2

        Show
        Ed Burns added a comment - Move all to 1.2

          People

          • Assignee:
            javaserverfowner
            Reporter:
            jayashri
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: