Details

    • Type: Bug Bug
    • Status: Open
    • Priority: Minor Minor
    • Resolution: Unresolved
    • Affects Version/s: 2.0
    • Fix Version/s: None
    • Component/s: Lifecycle
    • Labels:
      None
    • Environment:

      Operating System: All
      Platform: All

    • Issuezilla Id:
      816
    • Status Whiteboard:
      Hide

      size_medium importance_medium

      Show
      size_medium importance_medium

      Description

      In my examples I have a phase listener that outputs all request parameters . I
      accidentially did this before restore view and got some strange behaviour. With
      MyFaces 2.0, reading the request parameters before the restore view phase kills
      german umlauts. This happens because the character encoding is calculated and
      set in the request at the beginning of restore view but after the before phase
      listeners are executed.

      As this is not happening with Mojarra, I set a breakpoint in
      ServletRequest.setCharacterEncoding and saw that they are setting this somewhere
      at the beginning of the lifecycle.

      The spec says the following about this problem:

      *) Spec section 2.2.1: "The JSF implementation must perform the following tasks
      during the Restore View phase of the request processing lifecycle: Call
      initView() on the ViewHandler. This will set the character encoding properly for
      this request. ....."

      *) Spec section 7.5.1: "The initView() method must be called as the first method
      in the implementation of the Restore View Phase of the request processing
      lifecycle, immediately after checking for the existence of the FacesContext
      parameter...."

      In my understanding, the phase listeners belong to the lifecycle and not to the
      phases. This would mean that according to the spec ViewHandler.initView() should
      be called AFTER the invocation of the before phase listeners, which is too late.

        Activity

        michael_kurz created issue -
        Hide
        Ed Burns added a comment -

        sheetalv

        Show
        Ed Burns added a comment - sheetalv
        Hide
        rogerk added a comment -

        triage

        Show
        rogerk added a comment - triage
        kenaiadmin made changes -
        Field Original Value New Value
        issue.field.bugzillaimportkey 816 20421
        Hide
        Ed Burns added a comment -

        Bulk assign all of Sheetal's spec issues to me.

        Show
        Ed Burns added a comment - Bulk assign all of Sheetal's spec issues to me.
        Ed Burns made changes -
        Assignee sheetalv [ sheetalv ] Ed Burns [ edburns ]
        Ed Burns made changes -
        Assignee Ed Burns [ edburns ]
        Ed Burns made changes -
        Fix Version/s 2.3 [ 16372 ]
        Fix Version/s 2.2 [ 10403 ]
        Hide
        Ed Burns added a comment -

        Set priority to baseline ahead of JSF 2.3 triage. Priorities will be assigned accurately after this exercise.

        Show
        Ed Burns added a comment - Set priority to baseline ahead of JSF 2.3 triage. Priorities will be assigned accurately after this exercise.
        Ed Burns made changes -
        Priority Major [ 3 ] Trivial [ 5 ]
        Fix Version/s 2.3 [ 16372 ]
        Ed Burns made changes -
        Priority Trivial [ 5 ] Minor [ 4 ]

          People

          • Assignee:
            Unassigned
            Reporter:
            michael_kurz
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated: