Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Blocker Blocker
    • Resolution: Fixed
    • Affects Version/s: 2.0
    • Fix Version/s: 2.2
    • Component/s: Components/Renderers
    • Labels:
      None
    • Environment:

      Operating System: All
      Platform: All

    • Issuezilla Id:
      859
    • Status Whiteboard:
      Hide

      size_medium importance_large

      Show
      size_medium importance_large

      Description

      As far as I have seen there is no way to make a composite component properly
      support more than one action (actionListener...) attribute. While the
      re-targeting works fine for one action attribute, it is not possible to have two
      action sources with two independant action attributes.

      Here is a very simple and not so uncommon example of what I mean:

      <cc:interface>
      <cc:attribute name="submitAction" targets="submitButton"/>
      <cc:attribute name="cancelAction" targets="cancelButton"/>
      <cc:actionSource name="submitButton"/>
      <cc:actionSource name="cancelButton"/>
      </cc:interface>

      The attributes are not handled completely (can be a string or a method
      expression) as they are not named action.

      One solution for this problem might be to have a targetName attribute:

      <cc:interface>
      <cc:attribute name="submitAction" targets="submitButton" targetName="action"/>
      <cc:attribute name="cancelAction" targets="cancelButton" targetName="action"/>
      <cc:actionSource name="submitButton" targets="myForm:submitBtnId"/>
      <cc:actionSource name="cancelButton" targets="myForm:cancelBtnId"/>
      </cc:interface>

      1. 859-cc-attribute-methodType.patch
        4 kB
        lu4242
      2. changebundle.txt
        27 kB
        Ed Burns

        Activity

        Hide
        Ed Burns added a comment -

        Created an attachment (id=329)
        Alternat patch, includes spec language, feature, and automated test

        Show
        Ed Burns added a comment - Created an attachment (id=329) Alternat patch, includes spec language, feature, and automated test
        Hide
        Ed Burns added a comment -

        >>>>> On Thu, 28 Oct 2010 12:11:52 +0200, Jakob Korherr <jakob.korherr@irian.at>
        said:

        JK> The patch looks very good, however I don't really like the idea of
        JK> pushing the "target-approach". By reasons explained on the
        JK> jsr-314-open list it is much easier for the user to refer from the
        JK> implementation to the interface via #

        {cc.attrs.submitAction}

        or
        JK> #

        {cc.attrs.cancelAction}

        .

        Yes, and this is the crux of issue 755. I do not feel the two are mutually
        exclusive.

        Show
        Ed Burns added a comment - >>>>> On Thu, 28 Oct 2010 12:11:52 +0200, Jakob Korherr <jakob.korherr@irian.at> said: JK> The patch looks very good, however I don't really like the idea of JK> pushing the "target-approach". By reasons explained on the JK> jsr-314-open list it is much easier for the user to refer from the JK> implementation to the interface via # {cc.attrs.submitAction} or JK> # {cc.attrs.cancelAction} . Yes, and this is the crux of issue 755. I do not feel the two are mutually exclusive.
        Hide
        Ed Burns added a comment -

        Committed revision 8688.

        Show
        Ed Burns added a comment - Committed revision 8688.
        Hide
        Ed Burns added a comment -

        Marking fixed.

        Show
        Ed Burns added a comment - Marking fixed.
        Hide
        Manfred Riem added a comment -

        Closing resolved issue out

        Show
        Manfred Riem added a comment - Closing resolved issue out

          People

          • Assignee:
            Ed Burns
            Reporter:
            michael_kurz
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: