Details

    • Type: Bug Bug
    • Status: Open
    • Priority: Major Major
    • Resolution: Unresolved
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: Components/Renderers
    • Labels:
      None
    • Status Whiteboard:
      Hide

      size_medium importance_medium

      Show
      size_medium importance_medium

      Description

      Note that the following will most likely apply to 1.2 as well

      From Martin Marinschek:
      -----------------------------

      a) if invokeOnComponent returns successfully for any of the facets,
      invokeOnComponent should return with true - currently it doesn't (maybe there is
      a reason for this I fail to see?)

      b) I think that the NumberConversionException thrown from the current version of
      this method is dangerous in the sense that if the client-id is not actually
      valid (the component is not yet anymore in the table) but was a sub-component of
      a naming-container in a facet (client-id
      tableClientId:namContainerId:subCompId), the long client-id will trigger the
      code to check if the component is in one of the rows and you will suddenly get a
      number conversion exception popping up from the table. This is not the case with
      other components and invokeOnComponent, and so should be done differently.
      Instead, this NumberConversion exception has to be silently ignored - or a
      better solution for this algorithm has to be found (I didn't find one in a
      decent time-frame, however, and just ignored the NumberConversion exception in
      my version).

      As a side-note: could it be that you guys keep track of the state of children of
      transient nodes? I seem to be running into this from time to time. Leonardo
      mentioned this as an implementation difference to MyFaces to me, so maybe you
      could check if this is the case (I don't think this would make sense - a
      transient component would certainly mean every sub-component has to be transient
      as well).

        Activity

        Hide
        lu4242 added a comment -

        The most important problem I see with UIData current implementation is the clientId append the rowIndex and it could be better if we can just create some property called rowKey or a converter or whatever that allow us to generate this part of the id in a clean way. Right now, there is a solution for this one committed on tomahawk code if you want to take a look. I'm willing to write the solution for mojarra too.

        Show
        lu4242 added a comment - The most important problem I see with UIData current implementation is the clientId append the rowIndex and it could be better if we can just create some property called rowKey or a converter or whatever that allow us to generate this part of the id in a clean way. Right now, there is a solution for this one committed on tomahawk code if you want to take a look. I'm willing to write the solution for mojarra too.
        Hide
        Ed Burns added a comment -

        Set priority to baseline ahead of JSF 2.3 triage. Priorities will be assigned accurately after this exercise.

        Show
        Ed Burns added a comment - Set priority to baseline ahead of JSF 2.3 triage. Priorities will be assigned accurately after this exercise.
        Hide
        Manfred Riem added a comment -

        Setting priority to Major

        Show
        Manfred Riem added a comment - Setting priority to Major

          People

          • Assignee:
            Unassigned
            Reporter:
            rogerk
          • Votes:
            4 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:

              Time Tracking

              Estimated:
              Original Estimate - Not Specified
              Not Specified
              Remaining:
              Time Spent - 1 hour, 16 minutes Remaining Estimate - 3 days, 23 hours, 30 minutes
              3d 23h 30m
              Logged:
              Time Spent - 1 hour, 16 minutes Remaining Estimate - 3 days, 23 hours, 30 minutes
              1h 16m