java-state-managemen
  1. java-state-managemen
  2. JAVA_STATE_MANAGEMEN-2

getVersion() method in StateManager might be misnamed

    Details

    • Type: Bug Bug
    • Status: Open
    • Priority: Critical Critical
    • Resolution: Unresolved
    • Labels:
      None

      Description

      I noticed, the StateManager has a method getVersion() which actually returns a Collection of String values.
      JavaDoc states
      /**

      • Retrieve the versions of {@link javax.state.ext.version.VersionableState}

        supported by this manager.
        *

      • @return the collection of versions supported
        */
        Collection<String> getVersion();

      Unless the strings are parts of a single version, e.g. Major, Minor, Patch, etc. I believe this should better be called getVersions().

        Activity

        Hide
        peteraymond added a comment -

        Agreed. I suggested getSupportedVersions just before you came on the call.

        Show
        peteraymond added a comment - Agreed. I suggested getSupportedVersions just before you came on the call.

          People

          • Assignee:
            Unassigned
            Reporter:
            keilw
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated: