jawr
  1. jawr
  2. JAWR-243

Allow Jawr Grails plugin message generator to retrieve message from others grails plugins

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 3.3.3
    • Fix Version/s: 3.6
    • Component/s: Jawr Core
    • Labels:
      None
    • Environment:

      Linux, OSX, Grails

      Description

      Note that this is a fundamental problem with JAWR, not just a Grails problem. I discovered it via the Grails plugin.

      I have the following JAWR configuration in my app's Config.groovy.

      {{
      jawr {
      js {
      bundle {
      names = "pluginlib"
      pluginlib

      { id = "plugin-messages.js" mappings = "messages:/plugins/plugin-client-interface-0.1/grails-app/i18n/messages" }

      }
      }
      }
      }}

      Because the default bundle mapping defined by ResourceBundleMessagesGenerator.GRAILS_APP_I18N_RESOURCE_PREFIX is "grails-app.i18n.", LocaleUtils currently has to replace all instances of '.' with '/'. Completely ignoring the fact that this isn't platform-independent (windows uses \ for path separation), this strictly forbids the use of any path with an actual '.' as part of the name.

        Activity

        Hide
        icefox added a comment -

        Hi,

        The intent of the Jawr Grails message generator is to retrieve message from application i18n folder.
        The orignial intent was not to be able to use it to retrieve message from grails plugin.

        So this is a new feature for the Jawr Grails message generator.
        I've updated the title of the issue to reflect this.

        Cheers,

        Show
        icefox added a comment - Hi, The intent of the Jawr Grails message generator is to retrieve message from application i18n folder. The orignial intent was not to be able to use it to retrieve message from grails plugin. So this is a new feature for the Jawr Grails message generator. I've updated the title of the issue to reflect this. Cheers,
        Hide
        icefox added a comment -

        this issue has been fixed in the master branch.

        Show
        icefox added a comment - this issue has been fixed in the master branch.
        Hide
        icefox added a comment -

        The fix for this issue is part of the 3.6 release, which has been delivered the 06th Oct. 2014

        Show
        icefox added a comment - The fix for this issue is part of the 3.6 release, which has been delivered the 06th Oct. 2014

          People

          • Assignee:
            icefox
            Reporter:
            kevin.mershon
          • Votes:
            1 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: