jawr
  1. jawr
  2. JAWR-362

Provide JRuby sass compiler for Sass Generator

    Details

    • Type: Improvement Improvement
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 3.9
    • Component/s: None
    • Labels:
      None

      Description

      The vaadin sass compiler, which is used by the Sass generator is behind in term of feature compared to the JRuby Sass compiler.

      The goal of this improvement is to switch from the vaadin sass compiler to the JRuby one

        Activity

        Hide
        dtrunk90 added a comment -

        I've made a small test app which uses JRuby to compile SCSS to CSS: https://drive.google.com/file/d/0B2Zzvj-a9J2GQjNBYW9JckZIcWM/view?usp=sharing
        It's not too much work to switch from vaadin sass compiler to the JRuby one.
        I just didn't get how to configure the assembly plugin correctly to only include the jruby artifact. I got the configuration from here: https://github.com/torquebox/jruby-maven-plugins/blob/master/gem-assembly-descriptors/src/main/resources/assemblies/jar-with-dependencies-and-gems.xml

        Maybe this small test app will save you some research time.

        Show
        dtrunk90 added a comment - I've made a small test app which uses JRuby to compile SCSS to CSS: https://drive.google.com/file/d/0B2Zzvj-a9J2GQjNBYW9JckZIcWM/view?usp=sharing It's not too much work to switch from vaadin sass compiler to the JRuby one. I just didn't get how to configure the assembly plugin correctly to only include the jruby artifact. I got the configuration from here: https://github.com/torquebox/jruby-maven-plugins/blob/master/gem-assembly-descriptors/src/main/resources/assemblies/jar-with-dependencies-and-gems.xml Maybe this small test app will save you some research time.
        Hide
        icefox added a comment -

        Hi dtrunk90,

        Thanks for your help. It's greatly appreciated.
        I'll take a look at it.

        Cheers,
        icefox

        Show
        icefox added a comment - Hi dtrunk90, Thanks for your help. It's greatly appreciated. I'll take a look at it. Cheers, icefox
        Hide
        icefox added a comment -

        This issue has been fixed in the master branch.

        Jawr enhance the ruby compiler by allowing url reference to be relative. (https://github.com/sass/sass/issues/1015)
        Please check the jawr generator documentation for more detail

        Show
        icefox added a comment - This issue has been fixed in the master branch. Jawr enhance the ruby compiler by allowing url reference to be relative. ( https://github.com/sass/sass/issues/1015 ) Please check the jawr generator documentation for more detail

          People

          • Assignee:
            icefox
            Reporter:
            icefox
          • Votes:
            1 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: