jawr
  1. jawr
  2. JAWR-398

Support crossorigin attribute in script tag

    Details

    • Type: New Feature New Feature
    • Status: Resolved
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 3.8
    • Fix Version/s: 3.9
    • Component/s: Jawr Core
    • Labels:
      None

      Description

      We host our scripts on a CDN with a completely different domain to our website. This leads error handling not working well (see http://ravikiranj.net/posts/2014/code/how-fix-cryptic-script-error-javascript/).

      Part of the solution is to include the crossorigin attribute in the script tag.

      So I'd like some way to make the JAWR JSP tag library generate script tags with the crossorigin attribute.

      I'm planning to make this work in a similar way to the async and defer attributes and I'll submit a pull request soon.

        Activity

        Hide
        davidwebster48 added a comment -

        I've submitted pull request #33. https://github.com/ic3fox/jawr-main-repo/pull/33

        Show
        davidwebster48 added a comment - I've submitted pull request #33. https://github.com/ic3fox/jawr-main-repo/pull/33
        Hide
        icefox added a comment -

        This issue has been fixed in the master branch.

        Thanks for reporting the issue and for providing the pull request.

        Show
        icefox added a comment - This issue has been fixed in the master branch. Thanks for reporting the issue and for providing the pull request.

          People

          • Assignee:
            icefox
            Reporter:
            davidwebster48
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: