jax-rs-spec
  1. jax-rs-spec
  2. JAX_RS_SPEC-385

Remove Configurable support from client side Invocation and Invocation.Builder APIs.

    Details

    • Type: Improvement Improvement
    • Status: Resolved
    • Priority: Critical Critical
    • Resolution: Fixed
    • Affects Version/s: 2.0
    • Fix Version/s: 2.0
    • Component/s: client
    • Labels:
      None

      Description

      FWIW, I'd be happy to remove the Configurable support from Invocation.Builder and Invocation. After working with the API for quite some time now my feeling is that in these two cases we went just too far. I have not run into a single use case where I would need to configure these types. And I find it annoying that the IDE code completion offers me these methods when I do not need them at all.

        Issue Links

          Activity

          Hide
          patriot1burke added a comment -

          I've already implemented it, so, I don't care if you remove it or not.....BUT.....You still need to be able to set properties so interceptors/filters can pick up config info.

          Show
          patriot1burke added a comment - I've already implemented it, so, I don't care if you remove it or not.....BUT.....You still need to be able to set properties so interceptors/filters can pick up config info.
          Hide
          Marek Potociar added a comment - - edited

          So did I - it's been implemented for a long time now. IOW, troubles with implementing it is really not the reason for this RFE...

          Anyway, are you saying that everything can be removed but property setter needs to stay? I'd be fine with having per-request properties. But that's something that should not be mixed with per-client runtime configuration properties, right? Note that these request-scoped properties are exposed to providers via request contexts. IOW, it's not the same thing as runtime-wide Configuration properties.

          Show
          Marek Potociar added a comment - - edited So did I - it's been implemented for a long time now. IOW, troubles with implementing it is really not the reason for this RFE... Anyway, are you saying that everything can be removed but property setter needs to stay? I'd be fine with having per-request properties. But that's something that should not be mixed with per-client runtime configuration properties, right? Note that these request-scoped properties are exposed to providers via request contexts. IOW, it's not the same thing as runtime-wide Configuration properties.
          Hide
          Marek Potociar added a comment -
          • Removed Configurable from Invocation and Invocation.Builder APIs.
          • Added property(String, Object) to Invocation and Invocation.Builder APIs to support setting of request-scoped properties.
          Show
          Marek Potociar added a comment - Removed Configurable from Invocation and Invocation.Builder APIs. Added property(String, Object) to Invocation and Invocation.Builder APIs to support setting of request-scoped properties.

            People

            • Assignee:
              Marek Potociar
              Reporter:
              Marek Potociar
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: