jdic
  1. jdic
  2. JDIC-446

Build has a dependency that breaks on Mac OS

    Details

    • Type: Bug Bug
    • Status: Open
    • Priority: Blocker Blocker
    • Resolution: Unresolved
    • Affects Version/s: current
    • Fix Version/s: None
    • Component/s: Misc Project
    • Labels:
      None
    • Environment:

      Operating System: All
      Platform: All

    • Issuezilla Id:
      446

      Description

      The instructions for building this project (as given here:
      https://jdic.dev.java.net/documentation/README.html#Build%20the%20Source

      include this instruction:

      Set javaws.jar to the class path, which is under jre_home/lib for java5+ and
      jre/javaws for java1.4.2.

      There is no such jar file in either the 1.4 or 1.5 JDK implementations on the
      Mac; therefore it is impossible to build as-is on a Mac.

      A work-around is to copy this jar file from a Windows JDK to the Mac.

      However, this should not be a build dependency. If some functionality is
      required from that lib that is not provided on all platforms, it needs to be
      part of the source or lib distribution of the JDIC project so it can build on a Mac.

      Rob Ross

        Activity

        Hide
        lordy added a comment -

        Not quite right, Mac OS X comes with javaws.jar file, you only need to find it: /Applications/Utilities/Java/
        J2SE\ 5.0/Java\ Cache\ Viewer.app/Contents/MacOS/lib/javaws.jar

        But it is right we should fix this problem that other user simple can use "ant buildall" without changing
        build.xml by hand.

        So please Michael import my patch.

        Show
        lordy added a comment - Not quite right, Mac OS X comes with javaws.jar file, you only need to find it: /Applications/Utilities/Java/ J2SE\ 5.0/Java\ Cache\ Viewer.app/Contents/MacOS/lib/javaws.jar But it is right we should fix this problem that other user simple can use "ant buildall" without changing build.xml by hand. So please Michael import my patch.
        Hide
        lordy added a comment -

        Created an attachment (id=254)
        patch which add javaws.jar to classpath for Mac OS X

        Show
        lordy added a comment - Created an attachment (id=254) patch which add javaws.jar to classpath for Mac OS X
        Hide
        michael_shan added a comment -

        Hi Chris,
        I think we should let users specify the javaws.jar's location, since we can't
        write version dependent info into the build.xml,thus,if users use different
        version java,they will still meet errors, right?
        Instead of doing that,I think it's better to clarify that clearly in the readme
        to tell users to set the javaws.jar's location correctly,of course,correct path
        of java5.0's will be given as a sample. Any suggestions? Thanks!

        Michael

        Show
        michael_shan added a comment - Hi Chris, I think we should let users specify the javaws.jar's location, since we can't write version dependent info into the build.xml,thus,if users use different version java,they will still meet errors, right? Instead of doing that,I think it's better to clarify that clearly in the readme to tell users to set the javaws.jar's location correctly,of course,correct path of java5.0's will be given as a sample. Any suggestions? Thanks! Michael
        Hide
        robross added a comment -

        I think using a build.properties file might be helpful. In my own projects, I
        use a build.properties file that is read by the main build.xml file, and I
        include things that might be build-environment-dependent, so that it's easy to
        tweak the build.properties file without having to change the build.xml file. For
        example, on my webapp projects one of the properties might be tomcat.dir; thus,
        I don't have to expect a specific location in the build.xml file, but each
        developer can just write where their particular tomcat directory is located.

        You could get the location of the javaws.jar file from this file, and then the
        developer trying to build only has to adjust that property (or a small set of
        properties).

        Rob

        Show
        robross added a comment - I think using a build.properties file might be helpful. In my own projects, I use a build.properties file that is read by the main build.xml file, and I include things that might be build-environment-dependent, so that it's easy to tweak the build.properties file without having to change the build.xml file. For example, on my webapp projects one of the properties might be tomcat.dir; thus, I don't have to expect a specific location in the build.xml file, but each developer can just write where their particular tomcat directory is located. You could get the location of the javaws.jar file from this file, and then the developer trying to build only has to adjust that property (or a small set of properties). Rob
        Hide
        michael_shan added a comment -

        Yes, you're right. In fact,we use .bat or .sh file to set environment first then
        call build.xml to build jdic. We'll upload them to the cvs.

        Show
        michael_shan added a comment - Yes, you're right. In fact,we use .bat or .sh file to set environment first then call build.xml to build jdic. We'll upload them to the cvs.

          People

          • Assignee:
            michael_shan
            Reporter:
            robross
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated: