jersey
  1. jersey
  2. JERSEY-1825

jersey-gf-cdi module cleanup and refactoring

    Details

    • Type: Task Task
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 2.0-rc1, 2.0
    • Fix Version/s: 2.0-rc2, 2.0
    • Component/s: extensions
    • Labels:
      None

      Description

      demo meeting based comments:

      • add more tests (including qualifiers, ..) for CdiComponentProvider.CdiFactory. Evaluate whether is ok to pick and use one bean from set returned to BeanManager.getBeans(...) call. Relevant code:
      final Set<Bean<?>> beans = beanManager.getBeans(clazz);
      for (Bean b : beans) {
          final Object instance = beanManager.getReference(b, clazz, beanManager.createCreationalContext(b));
          return (T) instance;
      }
      
      • evaluate/test postConstruct/preDestroy calls on beans returned from BeanManager.
      • rename ProviderSkippingClassAnalyzer
      • investigate whether is necessary to have 2 instances of CdiComponentProvider. Relevant code:
      private static BeanManager beanManagerFromJndi() {
          try {
              return (BeanManager)new InitialContext().lookup("java:comp/BeanManager");
          } catch (Exception ex) {
              LOGGER.config(LocalizationMessages.CDI_BEAN_MANAGER_JNDI_LOOKUP_FAILED());
              return null;
          }
      }

        Activity

        There are no comments yet on this issue.

          People

          • Assignee:
            Jakub Podlesak
            Reporter:
            Pavel Bucek
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Time Tracking

              Estimated:
              Original Estimate - 6 hours Original Estimate - 6 hours
              6h
              Remaining:
              Remaining Estimate - 0 minutes
              0m
              Logged:
              Time Spent - 9 hours
              9h